From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6776C4338F for ; Tue, 27 Jul 2021 17:20:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1ADD61006 for ; Tue, 27 Jul 2021 17:20:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A1ADD61006 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hyUzRrc814KsuBywUvgMNN8HZ5KFU4gVzdmFqAq7A8M=; b=H2OL/eECfPjr/r oQc/lsPooCVm0m4qamhiVWzhpIRI1GTkBXXkQsdrFP/onhjghQnRzaHoMtAcPr/ha5hsav18pLFAR ZJOciPb0jMPb6e0Asy4pO+69pXkiq53S80iClOebG6toVRj7Zi2p8+bczfJQNCCuMWEzk1OAi0CNh ySu3+9JZqMq46fswAcJtnnYxLTYejH5Ej8g5lPvEnKaEeWbpF6bnoGEejTZrPLhnoq2yKXbk2PZf2 q11hfQ53iJPVg+gxWd6FXsWQYlRGj8oVHfJz0OUjvzwKMOTxgqK31j9ST6U0Lwc9QSYKc+f6FL0sA vHO8LCozdbIqeEBv/qjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Qjb-00FYBj-Mc; Tue, 27 Jul 2021 17:19:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8QjV-00FY8t-Pj for linux-arm-kernel@lists.infradead.org; Tue, 27 Jul 2021 17:19:11 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A39C61006; Tue, 27 Jul 2021 17:19:08 +0000 (UTC) Date: Tue, 27 Jul 2021 18:19:05 +0100 From: Catalin Marinas To: Peter Collingbourne Cc: Vincenzo Frascino , Will Deacon , Evgenii Stepanov , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: mte: avoid TFSR related operations unless in async mode Message-ID: <20210727171905.GR13920@arm.com> References: <20210709023532.2133673-1-pcc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210709023532.2133673-1-pcc@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_101909_875065_2141A042 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 08, 2021 at 07:35:32PM -0700, Peter Collingbourne wrote: > There is no reason to touch TFSR nor issue a DSB unless our task is > in asynchronous mode. Since these operations (especially the DSB) > may be expensive on certain microarchitectures, only perform them > if necessary. > > Furthermore, stop clearing TFSR on entry because it will be cleared > on exit and it is not necessary to have any particular value in TFSR > between entry and exit. Nitpick: this should be clearer that it's about TFSRE0_EL1 not the kernel's TFSR_EL1. Anyway, the patch looks fine, no need to repost. I can change the comment. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel