From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: memleak dir descriptor
Date: Tue, 27 Jul 2021 22:50:29 +0000 (GMT) [thread overview]
Message-ID: <20210727225029.9784E385040A@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=ec9dd728aa00de692f4b003e12394aa9cdda9446
Commit: ec9dd728aa00de692f4b003e12394aa9cdda9446
Parent: 308c6f31c3d79b370b163660f3ec38042a00289f
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Tue Jul 27 15:36:48 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Jul 28 00:49:22 2021 +0200
cov: memleak dir descriptor
opendir() missed closedir().
---
lib/device/dev-type.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/device/dev-type.c b/lib/device/dev-type.c
index 067a9ffad..89791bebe 100644
--- a/lib/device/dev-type.c
+++ b/lib/device/dev-type.c
@@ -180,6 +180,9 @@ int dev_is_used_by_active_lv(struct cmd_context *cmd, struct device *dev, int *u
}
}
+ if (closedir(d))
+ log_sys_debug("closedir", holders_path);
+
if (used_by_lv_count)
*used_by_lv_count = used_count;
if (used_by_dm_name)
reply other threads:[~2021-07-27 22:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727225029.9784E385040A@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.