All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: dev-mpath: check config_wwids_file
Date: Tue, 27 Jul 2021 22:50:35 +0000 (GMT)	[thread overview]
Message-ID: <20210727225035.58EF8383B82C@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=b2db01b530e995a80abe3379019503a8cae72b10
Commit:        b2db01b530e995a80abe3379019503a8cae72b10
Parent:        b7edda8a98281b6eb400fe41f2498e031bce7ccf
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Tue Jul 27 16:57:39 2021 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed Jul 28 00:49:28 2021 +0200

cov: dev-mpath: check config_wwids_file

Since config_wwids_file is checked for NULL,
test is also before calling _read_wwid_file()
that is directly dereferencing it.
---
 lib/device/dev-mpath.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/device/dev-mpath.c b/lib/device/dev-mpath.c
index d3eaf42a3..ba7bf9740 100644
--- a/lib/device/dev-mpath.c
+++ b/lib/device/dev-mpath.c
@@ -124,7 +124,8 @@ int dev_mpath_init(const char *config_wwids_file)
 
 	_wwid_hash_tab = wwid_tab;
 
-	_read_wwid_file(config_wwids_file);
+	if (config_wwids_file)
+		_read_wwid_file(config_wwids_file);
 
 	return 1;
 }



                 reply	other threads:[~2021-07-27 22:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727225035.58EF8383B82C@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.