From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6976C4338F for ; Wed, 28 Jul 2021 08:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A36660F9D for ; Wed, 28 Jul 2021 08:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234655AbhG1Ihi convert rfc822-to-8bit (ORCPT ); Wed, 28 Jul 2021 04:37:38 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:43759 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbhG1Ihf (ORCPT ); Wed, 28 Jul 2021 04:37:35 -0400 Received: (Authenticated sender: clement.leger@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 2BE601BF20E; Wed, 28 Jul 2021 08:37:33 +0000 (UTC) Date: Wed, 28 Jul 2021 10:37:32 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Vinod Koul Cc: Ludovic Desroches , Tudor Ambarus , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: at_xdmac: use module_platform_driver Message-ID: <20210728103732.3befa390@fixe.home> In-Reply-To: References: <20210625090042.17085-1-clement.leger@bootlin.com> <20210728093831.27430737@fixe.home> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Le Wed, 28 Jul 2021 13:53:48 +0530, Vinod Koul a écrit : > On 28-07-21, 09:38, Clément Léger wrote: > > Le Wed, 28 Jul 2021 12:26:50 +0530, > > Vinod Koul a écrit : > > > > > On 25-06-21, 11:00, Clément Léger wrote: > > > > The driver was previously probed with platform_driver_probe. > > > > This does not allow the driver to be probed again later if > > > > probe function returns -EPROBE_DEFER. This patch replace the > > > > use of platform_driver_probe with module_platform_driver which > > > > allows that. > > > > > > > > Signed-off-by: Clément Léger > > > > --- > > > > drivers/dma/at_xdmac.c | 6 +----- > > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > > > > index 64a52bf4d737..109a4c0895f4 100644 > > > > --- a/drivers/dma/at_xdmac.c > > > > +++ b/drivers/dma/at_xdmac.c > > > > @@ -2238,11 +2238,7 @@ static struct platform_driver > > > > at_xdmac_driver = { } > > > > }; > > > > > > > > -static int __init at_xdmac_init(void) > > > > -{ > > > > - return platform_driver_probe(&at_xdmac_driver, > > > > at_xdmac_probe); -} > > > > -subsys_initcall(at_xdmac_init); > > > > +module_platform_driver(at_xdmac_driver); > > > > > > You are also changing the init call here, there is a reason why > > > dmaengine drivers are subsys_initcall.. have you tested this? > > > > > > > I understood that the subsys initcall was there to probe the DMA > > driver earlier than other drivers (at least I guess this was the > > reason). I > > That is correct > > > also tested it and can confirm you this works as expected on my > > platform (sama5d2_xplained and sama5d27_som1). > > > > In my configuration, the clocks are provided using SCMI and the SCMI > > driver probes them later than other drivers. > > Heh, clocks should get probed even earlier Yes, even clocksources might need them... But that's another story. > > > With the current subsys_initcall, platform_driver_probe calls > > __platform_driver_probe which will eventually calls platform_probe. > > This one will fails because SCMI clocks are not available at this > > time. And as said in the kernel doc, __platform_driver_probe is > > incompatible with deferred probing. This leads to failure of all > > drivers that needs DMA channels provbided by at_xdmac. > > > > With module_platform_driver, the at_xdmac driver is correctly probed > > again later and all drivers that depends on DMA channels provided by > > this one are also correctly probed. The deferred probing mechanism > > seems to do its job correctly (at least in my case). > > OK would then recommend making it like module_platform_driver ie > remove platform_driver_probe, so the defer probe would work, but keep > the init at subsys level. That should work for you while keeping this > sane for folks that dont need this > Ok, I'll modify it this way, thanks. -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D3BDC4338F for ; Wed, 28 Jul 2021 08:39:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BD1A60F46 for ; Wed, 28 Jul 2021 08:39:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2BD1A60F46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mXIBz0oRfxlni4vMGyTj2c4y494zLa3mniBNLNovfxg=; b=ySuJ3a+lOrexLM qwQZDRQwkaPH+qGqxXk/stZIoneWOqbWJHOPA4k1IoqhzhGoirM6TXBTJksfRskcFZfqVMXXjGcWK 22oIF406WyPstegJQRq7xgg63gUT9ONo9OjE3NBOsrxTMPokemFNJSN77F1Z0NlI+OQq0qJUYf8EZ ogYNKs0zo6bCn0I0K7uuzLo2w7VmwQZ9Ae2efAaIQMOlJNhEo9SAV25j9v6qT+eTUER6m3dEhF5K7 KHBVtTckIWk3yY1Tx6ioMKo2M5vTFZMYQLVgEjbsd4R+khiTWb57SZF7GFCJtmtxppL8/HEKVRTER sVSmNtNUBzIduAkI/VaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8f4O-00HZvL-2d; Wed, 28 Jul 2021 08:37:40 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8f4J-00HZuG-CV for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 08:37:37 +0000 Received: (Authenticated sender: clement.leger@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 2BE601BF20E; Wed, 28 Jul 2021 08:37:33 +0000 (UTC) Date: Wed, 28 Jul 2021 10:37:32 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Vinod Koul Cc: Ludovic Desroches , Tudor Ambarus , Alexandre Belloni , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: at_xdmac: use module_platform_driver Message-ID: <20210728103732.3befa390@fixe.home> In-Reply-To: References: <20210625090042.17085-1-clement.leger@bootlin.com> <20210728093831.27430737@fixe.home> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_013735_740062_72E6752D X-CRM114-Status: GOOD ( 38.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgV2VkLCAyOCBKdWwgMjAyMSAxMzo1Mzo0OCArMDUzMCwKVmlub2QgS291bCA8dmtvdWxAa2Vy bmVsLm9yZz4gYSDDqWNyaXQgOgoKPiBPbiAyOC0wNy0yMSwgMDk6MzgsIENsw6ltZW50IEzDqWdl ciB3cm90ZToKPiA+IExlIFdlZCwgMjggSnVsIDIwMjEgMTI6MjY6NTAgKzA1MzAsCj4gPiBWaW5v ZCBLb3VsIDx2a291bEBrZXJuZWwub3JnPiBhIMOpY3JpdCA6Cj4gPiAgIAo+ID4gPiBPbiAyNS0w Ni0yMSwgMTE6MDAsIENsw6ltZW50IEzDqWdlciB3cm90ZTogIAo+ID4gPiA+IFRoZSBkcml2ZXIg d2FzIHByZXZpb3VzbHkgcHJvYmVkIHdpdGggcGxhdGZvcm1fZHJpdmVyX3Byb2JlLgo+ID4gPiA+ IFRoaXMgZG9lcyBub3QgYWxsb3cgdGhlIGRyaXZlciB0byBiZSBwcm9iZWQgYWdhaW4gbGF0ZXIg aWYKPiA+ID4gPiBwcm9iZSBmdW5jdGlvbiByZXR1cm5zIC1FUFJPQkVfREVGRVIuIFRoaXMgcGF0 Y2ggcmVwbGFjZSB0aGUKPiA+ID4gPiB1c2Ugb2YgcGxhdGZvcm1fZHJpdmVyX3Byb2JlIHdpdGgg bW9kdWxlX3BsYXRmb3JtX2RyaXZlciB3aGljaAo+ID4gPiA+IGFsbG93cyB0aGF0Lgo+ID4gPiA+ IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IENsw6ltZW50IEzDqWdlciA8Y2xlbWVudC5sZWdlckBi b290bGluLmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9kbWEvYXRfeGRtYWMuYyB8 IDYgKy0tLS0tCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNSBkZWxl dGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEvYXRfeGRt YWMuYyBiL2RyaXZlcnMvZG1hL2F0X3hkbWFjLmMKPiA+ID4gPiBpbmRleCA2NGE1MmJmNGQ3Mzcu LjEwOWE0YzA4OTVmNCAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2RtYS9hdF94ZG1hYy5j Cj4gPiA+ID4gKysrIGIvZHJpdmVycy9kbWEvYXRfeGRtYWMuYwo+ID4gPiA+IEBAIC0yMjM4LDEx ICsyMjM4LDcgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIKPiA+ID4gPiBhdF94ZG1h Y19kcml2ZXIgPSB7IH0KPiA+ID4gPiAgfTsKPiA+ID4gPiAgCj4gPiA+ID4gLXN0YXRpYyBpbnQg X19pbml0IGF0X3hkbWFjX2luaXQodm9pZCkKPiA+ID4gPiAtewo+ID4gPiA+IC0JcmV0dXJuIHBs YXRmb3JtX2RyaXZlcl9wcm9iZSgmYXRfeGRtYWNfZHJpdmVyLAo+ID4gPiA+IGF0X3hkbWFjX3By b2JlKTsgLX0KPiA+ID4gPiAtc3Vic3lzX2luaXRjYWxsKGF0X3hkbWFjX2luaXQpOwo+ID4gPiA+ ICttb2R1bGVfcGxhdGZvcm1fZHJpdmVyKGF0X3hkbWFjX2RyaXZlcik7ICAgIAo+ID4gPiAKPiA+ ID4gWW91IGFyZSBhbHNvIGNoYW5naW5nIHRoZSBpbml0IGNhbGwgaGVyZSwgdGhlcmUgaXMgYSBy ZWFzb24gd2h5Cj4gPiA+IGRtYWVuZ2luZSBkcml2ZXJzIGFyZSBzdWJzeXNfaW5pdGNhbGwuLiBo YXZlIHlvdSB0ZXN0ZWQgdGhpcz8KPiA+ID4gICAKPiA+IAo+ID4gSSB1bmRlcnN0b29kIHRoYXQg dGhlIHN1YnN5cyBpbml0Y2FsbCB3YXMgdGhlcmUgdG8gcHJvYmUgdGhlIERNQQo+ID4gZHJpdmVy IGVhcmxpZXIgdGhhbiBvdGhlciBkcml2ZXJzIChhdCBsZWFzdCBJIGd1ZXNzIHRoaXMgd2FzIHRo ZQo+ID4gcmVhc29uKS4gSSAgCj4gCj4gVGhhdCBpcyBjb3JyZWN0Cj4gCj4gPiBhbHNvIHRlc3Rl ZCBpdCBhbmQgY2FuIGNvbmZpcm0geW91IHRoaXMgd29ya3MgYXMgZXhwZWN0ZWQgb24gbXkKPiA+ IHBsYXRmb3JtIChzYW1hNWQyX3hwbGFpbmVkIGFuZCBzYW1hNWQyN19zb20xKS4KPiA+IAo+ID4g SW4gbXkgY29uZmlndXJhdGlvbiwgdGhlIGNsb2NrcyBhcmUgcHJvdmlkZWQgdXNpbmcgU0NNSSBh bmQgdGhlIFNDTUkKPiA+IGRyaXZlciBwcm9iZXMgdGhlbSBsYXRlciB0aGFuIG90aGVyIGRyaXZl cnMuICAgCj4gCj4gSGVoLCBjbG9ja3Mgc2hvdWxkIGdldCBwcm9iZWQgZXZlbiBlYXJsaWVyCgpZ ZXMsIGV2ZW4gY2xvY2tzb3VyY2VzIG1pZ2h0IG5lZWQgdGhlbS4uLiBCdXQgdGhhdCdzIGFub3Ro ZXIgc3RvcnkuCgo+IAo+ID4gV2l0aCB0aGUgY3VycmVudCBzdWJzeXNfaW5pdGNhbGwsIHBsYXRm b3JtX2RyaXZlcl9wcm9iZSBjYWxscwo+ID4gX19wbGF0Zm9ybV9kcml2ZXJfcHJvYmUgd2hpY2gg d2lsbCBldmVudHVhbGx5IGNhbGxzIHBsYXRmb3JtX3Byb2JlLgo+ID4gVGhpcyBvbmUgd2lsbCBm YWlscyBiZWNhdXNlIFNDTUkgY2xvY2tzIGFyZSBub3QgYXZhaWxhYmxlIGF0IHRoaXMKPiA+IHRp bWUuIEFuZCBhcyBzYWlkIGluIHRoZSBrZXJuZWwgZG9jLCBfX3BsYXRmb3JtX2RyaXZlcl9wcm9i ZSBpcwo+ID4gaW5jb21wYXRpYmxlIHdpdGggZGVmZXJyZWQgcHJvYmluZy4gVGhpcyBsZWFkcyB0 byBmYWlsdXJlIG9mIGFsbAo+ID4gZHJpdmVycyB0aGF0IG5lZWRzIERNQSBjaGFubmVscyBwcm92 YmlkZWQgYnkgYXRfeGRtYWMuCj4gPiAKPiA+IFdpdGggbW9kdWxlX3BsYXRmb3JtX2RyaXZlciwg dGhlIGF0X3hkbWFjIGRyaXZlciBpcyBjb3JyZWN0bHkgcHJvYmVkCj4gPiBhZ2FpbiBsYXRlciBh bmQgYWxsIGRyaXZlcnMgdGhhdCBkZXBlbmRzIG9uIERNQSBjaGFubmVscyBwcm92aWRlZCBieQo+ ID4gdGhpcyBvbmUgYXJlIGFsc28gY29ycmVjdGx5IHByb2JlZC4gVGhlIGRlZmVycmVkIHByb2Jp bmcgbWVjaGFuaXNtCj4gPiBzZWVtcyB0byBkbyBpdHMgam9iIGNvcnJlY3RseSAoYXQgbGVhc3Qg aW4gbXkgY2FzZSkuICAKPiAKPiBPSyB3b3VsZCB0aGVuIHJlY29tbWVuZCBtYWtpbmcgaXQgbGlr ZSBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyIGllCj4gcmVtb3ZlIHBsYXRmb3JtX2RyaXZlcl9wcm9i ZSwgc28gdGhlIGRlZmVyIHByb2JlIHdvdWxkIHdvcmssIGJ1dCBrZWVwCj4gdGhlIGluaXQgYXQg c3Vic3lzIGxldmVsLiBUaGF0IHNob3VsZCB3b3JrIGZvciB5b3Ugd2hpbGUga2VlcGluZyB0aGlz Cj4gc2FuZSBmb3IgZm9sa3MgdGhhdCBkb250IG5lZWQgdGhpcwo+IAoKT2ssIEknbGwgbW9kaWZ5 IGl0IHRoaXMgd2F5LCB0aGFua3MuCgoKCi0tIApDbMOpbWVudCBMw6lnZXIsCkVtYmVkZGVkIExp bnV4IGFuZCBLZXJuZWwgZW5naW5lZXIgYXQgQm9vdGxpbgpodHRwczovL2Jvb3RsaW4uY29tCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==