From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5B8C4338F for ; Wed, 28 Jul 2021 16:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 293676101C for ; Wed, 28 Jul 2021 16:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229581AbhG1Qil (ORCPT ); Wed, 28 Jul 2021 12:38:41 -0400 Received: from foss.arm.com ([217.140.110.172]:60614 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbhG1Qik (ORCPT ); Wed, 28 Jul 2021 12:38:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E3326D; Wed, 28 Jul 2021 09:38:39 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 26EE43F70D; Wed, 28 Jul 2021 09:38:38 -0700 (PDT) Date: Wed, 28 Jul 2021 17:37:17 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration Message-ID: <20210728163716.GG1724@arm.com> References: <20210727180649.12943-1-broonie@kernel.org> <20210727180649.12943-4-broonie@kernel.org> <20210728094158.GC1724@arm.com> <20210728125918.GD4670@sirena.org.uk> <20210728134405.GF1724@arm.com> <20210728162953.GF4670@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728162953.GF4670@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Jul 28, 2021 at 05:29:53PM +0100, Mark Brown wrote: > On Wed, Jul 28, 2021 at 02:44:07PM +0100, Dave Martin wrote: > > > This might be a bit clearer if the setup code was clearly separate from > > the tests, but so long as the ordering requirements are clearly > > documented that seems reasonably OK. > > We can't really split the setup code out since the setup code would have > to rely on one of the ABIs we're trying to test which is all fine and > good until the tests actually help us catch something, we have to build > up knowledge of the values as we go and hope that the cross checking we > end up with helps us at least catch inconsistencies. Ack. The setup code could be defensive, but you would in effect be doing some of the tests twice then. Or the fact that the setup code is "separate" from the tests might be a bit of an illusion. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A4DC4338F for ; Wed, 28 Jul 2021 16:41:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5DCF60F01 for ; Wed, 28 Jul 2021 16:41:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D5DCF60F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SFiLyOQzOMDYjdw1rwLOf7zt7NAW0qZen2xsjRYzkM8=; b=bObIdnbpOJUxdO ZGrNBVjcQumDCFyVYJ2bBtqU0M9xWcOVdLk38i5pcXTzU7+pwFjU5oIelKFKYMdcrGVaMsztySbdk tzc6O/ROfl3yg9t/8LP+lJ6YKVl3DbhLPbLtmJ2Za06R3nbczgdaEkBBq42VoEzl4lVQXuk82iT2S XWAYAGZrJtjetZD+3G1R98RzopRqxMYTDt4T2Ou4VdA9pR3PPrhHHVALoDqRaNUNolH2/tOopk5dL KQ5Ccik0Ayr9N1B2/b0WJdcKqUOSqSD0mwpLVX9Eg7Qf74I2xje/q+XOU5Rf3eCZQKwMQ0jSbwLDW JfTrg7UmRR843p5NKloQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8mZx-001fRJ-BT; Wed, 28 Jul 2021 16:38:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8mZs-001fPq-Sc for linux-arm-kernel@lists.infradead.org; Wed, 28 Jul 2021 16:38:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E3326D; Wed, 28 Jul 2021 09:38:39 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 26EE43F70D; Wed, 28 Jul 2021 09:38:38 -0700 (PDT) Date: Wed, 28 Jul 2021 17:37:17 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration Message-ID: <20210728163716.GG1724@arm.com> References: <20210727180649.12943-1-broonie@kernel.org> <20210727180649.12943-4-broonie@kernel.org> <20210728094158.GC1724@arm.com> <20210728125918.GD4670@sirena.org.uk> <20210728134405.GF1724@arm.com> <20210728162953.GF4670@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210728162953.GF4670@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210728_093841_051237_3EF0698B X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 05:29:53PM +0100, Mark Brown wrote: > On Wed, Jul 28, 2021 at 02:44:07PM +0100, Dave Martin wrote: > > > This might be a bit clearer if the setup code was clearly separate from > > the tests, but so long as the ordering requirements are clearly > > documented that seems reasonably OK. > > We can't really split the setup code out since the setup code would have > to rely on one of the ABIs we're trying to test which is all fine and > good until the tests actually help us catch something, we have to build > up knowledge of the values as we go and hope that the cross checking we > end up with helps us at least catch inconsistencies. Ack. The setup code could be defensive, but you would in effect be doing some of the tests twice then. Or the fact that the setup code is "separate" from the tests might be a bit of an illusion. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel