All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Chuck Lever III <chuck.lever@oracle.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Haakon Bugge <haakon.bugge@oracle.com>
Subject: Re: NFS RDMA test failure as of 5.14-rc1
Date: Wed, 28 Jul 2021 14:05:40 -0300	[thread overview]
Message-ID: <20210728170540.GA2316423@nvidia.com> (raw)
In-Reply-To: <CH0PR01MB71535949BACC7C43261EDAD2F2EA9@CH0PR01MB7153.prod.exchangelabs.com>

On Wed, Jul 28, 2021 at 01:50:48PM +0000, Marciniszyn, Mike wrote:
> > >
> > > commit dc70f7c3ed34b081c02a611591c5079c53b771b8
> > > Author: H kon Bugge <haakon.bugge@oracle.com>
> > > Date:   Tue Jun 22 15:39:56 2021 +0200
> > >
> > >     RDMA/cma: Remove unnecessary INIT->INIT transition
> > >
> > >     In rdma_create_qp(), a connected QP will be transitioned to the INIT
> > >     state.
> > >
> > >     Afterwards, the QP will be transitioned to the RTR state by the
> > >     cma_modify_qp_rtr() function. But this function starts by performing an
> > >     ib_modify_qp() to the INIT state again, before another ib_modify_qp() is
> > >     performed to transition the QP to the RTR state.
> > >
> > >     Hence, there is no need to transition the QP to the INIT state in
> > >     rdma_create_qp().
> > >
> > >     Link: https://lore.kernel.org/r/1624369197-24578-2-git-send-email-
> > > haakon.bugge@oracle.com
> > >     Signed-off-by: H kon Bugge <haakon.bugge@oracle.com>
> > >     Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> > >     Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > 
> > A brief unit test with the patch reverted in 5.14-rc3 shows that this patch may
> > be responsible for iSer CI regressions there as well.
> 
> A test of 5.15-rc3 + a revert tested clean.
> 
> Jason, do you need a patch to revert or should I send one.

Please, I would like to hear from Haakon as well

Jason

  reply	other threads:[~2021-07-28 17:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 13:43 NFS RDMA test failure as of 5.14-rc1 Marciniszyn, Mike
2021-07-27 17:14 ` Marciniszyn, Mike
2021-07-27 17:26   ` Chuck Lever III
2021-07-27 17:35     ` Marciniszyn, Mike
2021-07-27 17:38       ` Jason Gunthorpe
2021-07-27 17:45         ` Chuck Lever III
2021-07-27 21:20           ` Marciniszyn, Mike
2021-07-27 23:10             ` Chuck Lever III
2021-07-28  4:31               ` Leon Romanovsky
2021-07-27 18:12         ` Leon Romanovsky
2021-07-27 20:17 ` Marciniszyn, Mike
2021-07-28 13:50   ` Marciniszyn, Mike
2021-07-28 17:05     ` Jason Gunthorpe [this message]
2021-07-29 18:28       ` Marciniszyn, Mike
2021-08-09 13:38         ` Haakon Bugge
2021-08-09 14:00           ` Chuck Lever III
2021-08-10 15:09             ` Marciniszyn, Mike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728170540.GA2316423@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=chuck.lever@oracle.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=dledford@redhat.com \
    --cc=haakon.bugge@oracle.com \
    --cc=leonro@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@cornelisnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.