All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Baker <len.baker@gmx.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Len Baker <len.baker@gmx.com>,
	David Laight <David.Laight@ACULAB.COM>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pavel Skripkin <paskripkin@gmail.com>,
	"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of strscpy()
Date: Wed, 28 Jul 2021 19:45:27 +0200	[thread overview]
Message-ID: <20210728174527.GA4275@titan> (raw)
In-Reply-To: <20210726081148.GF1931@kadam>

On Mon, Jul 26, 2021 at 11:11:48AM +0300, Dan Carpenter wrote:
> On Fri, Jul 23, 2021 at 05:15:10PM +0200, Len Baker wrote:
> > Hi,
> >
> > On Wed, Jul 21, 2021 at 11:06:24AM +0300, Dan Carpenter wrote:
> > > On Mon, Jul 19, 2021 at 03:24:38PM +0000, David Laight wrote:
> > > >
> > > > I know only root can set module parameters, but having one
> > > > that contains a string used as a printf format seems
> > > > dangerous at best.
> > > >
> > > > Isn't it best to let userspace rename the interfaces later on?
> > >
> > > Yeah.  I think you're right.
> >
> > Sorry, but I don't understand if the code needs to be improved or not.
> > Is the code shown by Dan not correct?
>
> We should remove the ifname[] array and the module option completely.

Thanks for the clarification.

Regards,
Len

      reply	other threads:[~2021-07-28 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17 15:51 [PATCH] staging/rtl8712: Remove all strcpy() uses in favor of strscpy() Len Baker
2021-07-19  5:37 ` Dan Carpenter
2021-07-19 15:24   ` David Laight
2021-07-21  8:06     ` Dan Carpenter
2021-07-23 15:15       ` Len Baker
2021-07-26  8:11         ` Dan Carpenter
2021-07-28 17:45           ` Len Baker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728174527.GA4275@titan \
    --to=len.baker@gmx.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=paskripkin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.