Re: [Intel-gfx] [RFC PATCH 01/42] drm/i915/guc: GuC submission squashed into single patch

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 6885 bytes --]

Hi Matthew,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm/drm-next v5.14-rc3 next-20210727]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210721-044431
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-a004-20210721 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c781eb153bfbd1b52b03efe34f56bbeccbb8aba6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/b0216b025067b85590916d67e9ea1311f6f068c1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210721-044431
        git checkout b0216b025067b85590916d67e9ea1311f6f068c1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/gt/intel_reset.c:1508:
>> drivers/gpu/drm/i915/gt/selftest_hangcheck.c:464:62: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
                           pr_err("[%s] Create context failed: %d!\n", engine->name, err);
                                                                                     ^~~
   include/linux/printk.h:390:33: note: expanded from macro 'pr_err'
           printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
                                          ^~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c:452:10: note: initialize the variable 'err' to silence this warning
                   int err;
                          ^
                           = 0
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c:579:62: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
                           pr_err("[%s] Create context failed: %d!\n", engine->name, err);
                                                                                     ^~~
   include/linux/printk.h:390:33: note: expanded from macro 'pr_err'
           printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
                                          ^~~~~~~~~~~
   drivers/gpu/drm/i915/gt/selftest_hangcheck.c:571:10: note: initialize the variable 'err' to silence this warning
                   int err;
                          ^
                           = 0
   2 errors generated.


vim +/err +464 drivers/gpu/drm/i915/gt/selftest_hangcheck.c

   435	
   436	static int igt_reset_nop_engine(void *arg)
   437	{
   438		struct intel_gt *gt = arg;
   439		struct i915_gpu_error *global = &gt->i915->gpu_error;
   440		struct intel_engine_cs *engine;
   441		enum intel_engine_id id;
   442	
   443		/* Check that we can engine-reset during non-user portions */
   444	
   445		if (!intel_has_reset_engine(gt))
   446			return 0;
   447	
   448		for_each_engine(engine, gt, id) {
   449			unsigned int reset_count, reset_engine_count, count;
   450			struct intel_context *ce;
   451			IGT_TIMEOUT(end_time);
   452			int err;
   453	
   454			if (intel_engine_uses_guc(engine)) {
   455				/* Engine level resets are triggered by GuC when a hang
   456				 * is detected. They can't be triggered by the KMD any
   457				 * more. Thus a nop batch cannot be used as a reset test
   458				 */
   459				continue;
   460			}
   461	
   462			ce = intel_context_create(engine);
   463			if (IS_ERR(ce)) {
 > 464				pr_err("[%s] Create context failed: %d!\n", engine->name, err);
   465				return PTR_ERR(ce);
   466			}
   467	
   468			reset_count = i915_reset_count(global);
   469			reset_engine_count = i915_reset_engine_count(global, engine);
   470			count = 0;
   471	
   472			st_engine_heartbeat_disable(engine);
   473			set_bit(I915_RESET_ENGINE + id, &gt->reset.flags);
   474			do {
   475				int i;
   476	
   477				if (!wait_for_idle(engine)) {
   478					pr_err("%s failed to idle before reset\n",
   479					       engine->name);
   480					err = -EIO;
   481					break;
   482				}
   483	
   484				for (i = 0; i < 16; i++) {
   485					struct i915_request *rq;
   486	
   487					rq = intel_context_create_request(ce);
   488					if (IS_ERR(rq)) {
   489						struct drm_printer p =
   490							drm_info_printer(gt->i915->drm.dev);
   491						intel_engine_dump(engine, &p,
   492								  "%s(%s): failed to submit request\n",
   493								  __func__,
   494								  engine->name);
   495	
   496						GEM_TRACE("%s(%s): failed to submit request\n",
   497							  __func__,
   498							  engine->name);
   499						GEM_TRACE_DUMP();
   500	
   501						intel_gt_set_wedged(gt);
   502	
   503						err = PTR_ERR(rq);
   504						break;
   505					}
   506	
   507					i915_request_add(rq);
   508				}
   509				err = intel_engine_reset(engine, NULL);
   510				if (err) {
   511					pr_err("intel_engine_reset(%s) failed, err:%d\n",
   512					       engine->name, err);
   513					break;
   514				}
   515	
   516				if (i915_reset_count(global) != reset_count) {
   517					pr_err("Full GPU reset recorded! (engine reset expected)\n");
   518					err = -EINVAL;
   519					break;
   520				}
   521	
   522				if (i915_reset_engine_count(global, engine) !=
   523				    reset_engine_count + ++count) {
   524					pr_err("%s engine reset not recorded!\n",
   525					       engine->name);
   526					err = -EINVAL;
   527					break;
   528				}
   529			} while (time_before(jiffies, end_time));
   530			clear_bit(I915_RESET_ENGINE + id, &gt->reset.flags);
   531			st_engine_heartbeat_enable(engine);
   532	
   533			pr_info("%s(%s): %d resets\n", __func__, engine->name, count);
   534	
   535			intel_context_put(ce);
   536			if (igt_flush_test(gt->i915))
   537				err = -EIO;
   538			if (err)
   539				return err;
   540		}
   541	
   542		return 0;
   543	}
   544	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39912 bytes --]