From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [ogabbay:habanalabs-next 11/40] drivers/misc/habanalabs/common/state_dump.c:434:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores]
Date: Thu, 29 Jul 2021 15:05:21 +0800 [thread overview]
Message-ID: <202107291514.R2ZxdANL-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 15990 bytes --]
CC: clang-built-linux(a)googlegroups.com
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Yuri Nudelman <ynudelman@habana.ai>
CC: Oded Gabbay <ogabbay@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git habanalabs-next
head: ed1ec0f6c655003eb3f092f47e98181646e88173
commit: 2b6cdda5981340a654d48826992fbb07c59f6c68 [11/40] habanalabs: expose state dump
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-c001-20210727 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c658b472f3e61e1818e1909bf02f3d65470018a5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git/commit/?id=2b6cdda5981340a654d48826992fbb07c59f6c68
git remote add ogabbay https://git.kernel.org/pub/scm/linux/kernel/git/ogabbay/linux.git
git fetch --no-tags ogabbay habanalabs-next
git checkout 2b6cdda5981340a654d48826992fbb07c59f6c68
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 clang-analyzer
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
clang-analyzer warnings: (new ones prefixed by >>)
^
include/linux/compiler.h:48:41: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
include/linux/compiler.h:33:34: note: expanded from macro '__branch_check__'
______r = __builtin_expect(!!(x), expect); \
^
include/linux/hid.h:1005:15: note: 'c' is <= 'limit'
if (unlikely(c > limit || !bmap)) {
^
include/linux/compiler.h:48:68: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
include/linux/compiler.h:35:19: note: expanded from macro '__branch_check__'
expect, is_constant); \
^~~~~~~~~~~
include/linux/hid.h:1005:15: note: Left side of '||' is false
if (unlikely(c > limit || !bmap)) {
^
include/linux/hid.h:1005:29: note: 'bmap' is null
if (unlikely(c > limit || !bmap)) {
^
include/linux/compiler.h:48:68: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^
include/linux/compiler.h:35:19: note: expanded from macro '__branch_check__'
expect, is_constant); \
^~~~~~~~~~~
include/linux/hid.h:1005:2: note: Taking true branch
if (unlikely(c > limit || !bmap)) {
^
include/linux/hid.h:1006:3: note: Assuming the condition is true
pr_warn_ratelimited("%s: Invalid code %d type %d\n",
^
include/linux/printk.h:557:2: note: expanded from macro 'pr_warn_ratelimited'
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/printk.h:540:6: note: expanded from macro 'printk_ratelimited'
if (__ratelimit(&_rs)) \
^~~~~~~~~~~~~~~~~
include/linux/ratelimit_types.h:41:28: note: expanded from macro '__ratelimit'
#define __ratelimit(state) ___ratelimit(state, __func__)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/hid.h:1006:3: note: Taking true branch
pr_warn_ratelimited("%s: Invalid code %d type %d\n",
^
include/linux/printk.h:557:2: note: expanded from macro 'pr_warn_ratelimited'
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^
include/linux/printk.h:540:2: note: expanded from macro 'printk_ratelimited'
if (__ratelimit(&_rs)) \
^
include/linux/hid.h:1007:9: note: Access to field 'name' results in a dereference of a null pointer (loaded from variable 'input')
input->name, c, type);
^
include/linux/printk.h:557:49: note: expanded from macro 'pr_warn_ratelimited'
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
include/linux/printk.h:541:17: note: expanded from macro 'printk_ratelimited'
printk(fmt, ##__VA_ARGS__); \
^~~~~~~~~~~
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
7 warnings generated.
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
drivers/misc/habanalabs/common/firmware_if.c:1231:2: warning: Value stored to 'cpu_boot_dev_sts1' is never read [clang-analyzer-deadcode.DeadStores]
cpu_boot_dev_sts1 = prop->fw_preboot_cpu_boot_dev_sts1;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/habanalabs/common/firmware_if.c:1231:2: note: Value stored to 'cpu_boot_dev_sts1' is never read
cpu_boot_dev_sts1 = prop->fw_preboot_cpu_boot_dev_sts1;
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/habanalabs/common/firmware_if.c:1516:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores]
rc = hl_fw_dynamic_send_clear_cmd(hdev, fw_loader);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/habanalabs/common/firmware_if.c:1516:2: note: Value stored to 'rc' is never read
rc = hl_fw_dynamic_send_clear_cmd(hdev, fw_loader);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
8 warnings generated.
>> drivers/misc/habanalabs/common/state_dump.c:434:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores]
rc = hl_snprintf_resize(&buf, &size, &offset,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/habanalabs/common/state_dump.c:434:2: note: Value stored to 'rc' is never read
rc = hl_snprintf_resize(&buf, &size, &offset,
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 7 warnings (7 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
5 warnings generated.
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
9 warnings generated.
drivers/w1/slaves/w1_therm.c:159:8: warning: Excessive padding in 'struct w1_therm_family_converter' (12 padding bytes, where 4 is optimal).
Optimal fields order:
f,
convert,
get_conversion_time,
set_resolution,
get_resolution,
write_data,
reserved,
broken,
bulk_read,
consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding]
struct w1_therm_family_converter {
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:159:8: note: Excessive padding in 'struct w1_therm_family_converter' (12 padding bytes, where 4 is optimal). Optimal fields order: f, convert, get_conversion_time, set_resolution, get_resolution, write_data, reserved, broken, bulk_read, consider reordering the fields or adding explicit padding members
struct w1_therm_family_converter {
~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:1252:5: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = -EIO;
^ ~~~~
drivers/w1/slaves/w1_therm.c:1252:5: note: Value stored to 'ret' is never read
ret = -EIO;
^ ~~~~
drivers/w1/slaves/w1_therm.c:1799:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
strcpy(p_args, buf);
^~~~~~
drivers/w1/slaves/w1_therm.c:1799:2: note: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy(p_args, buf);
^~~~~~
drivers/w1/slaves/w1_therm.c:2090:22: warning: The right operand of '==' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
if (sl->reg_num.id == reg_num->id)
^ ~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:2067:6: note: Assuming the condition is false
if (w1_reset_bus(sl->master))
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:2067:2: note: Taking false branch
if (w1_reset_bus(sl->master))
^
drivers/w1/slaves/w1_therm.c:2077:6: note: Assuming 'ack' is equal to W1_42_SUCCESS_CONFIRM_BYTE
if (ack != W1_42_SUCCESS_CONFIRM_BYTE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:2077:2: note: Taking false branch
if (ack != W1_42_SUCCESS_CONFIRM_BYTE)
^
drivers/w1/slaves/w1_therm.c:2081:2: note: Loop condition is true. Entering loop body
for (i = 0; i <= 64; i++) {
^
drivers/w1/slaves/w1_therm.c:2082:7: note: Assuming the condition is false
if (w1_reset_bus(sl->master))
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:2082:3: note: Taking false branch
if (w1_reset_bus(sl->master))
^
drivers/w1/slaves/w1_therm.c:2088:7: note: Assuming field 'family' is not equal to W1_42_FINISHED_BYTE
if (reg_num->family == W1_42_FINISHED_BYTE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/w1/slaves/w1_therm.c:2088:3: note: Taking false branch
if (reg_num->family == W1_42_FINISHED_BYTE)
^
drivers/w1/slaves/w1_therm.c:2090:22: note: The right operand of '==' is a garbage value
if (sl->reg_num.id == reg_num->id)
^ ~~~~~~~~~~~
Suppressed 5 warnings (5 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
10 warnings generated.
Suppressed 10 warnings (10 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
63 warnings generated.
drivers/net/fddi/skfp/pmf.c:63:21: warning: Excessive padding in 'struct s_p_tab' (2 padding bytes, where 0 is optimal).
Optimal fields order:
p_num,
p_offset,
p_access,
p_swap,
consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding]
static const struct s_p_tab {
~~~~~~~^~~~~~~~~
drivers/net/fddi/skfp/pmf.c:63:21: note: Excessive padding in 'struct s_p_tab' (2 padding bytes, where 0 is optimal). Optimal fields order: p_num, p_offset, p_access, p_swap, consider reordering the fields or adding explicit padding members
static const struct s_p_tab {
~~~~~~~^~~~~~~~~
vim +/rc +434 drivers/misc/habanalabs/common/state_dump.c
2b6cdda5981340 Yuri Nudelman 2021-06-06 423
2b6cdda5981340 Yuri Nudelman 2021-06-06 424 /**
2b6cdda5981340 Yuri Nudelman 2021-06-06 425 * hl_state_dump() - dump system state
2b6cdda5981340 Yuri Nudelman 2021-06-06 426 * @hdev: pointer to device structure
2b6cdda5981340 Yuri Nudelman 2021-06-06 427 */
2b6cdda5981340 Yuri Nudelman 2021-06-06 428 int hl_state_dump(struct hl_device *hdev)
2b6cdda5981340 Yuri Nudelman 2021-06-06 429 {
2b6cdda5981340 Yuri Nudelman 2021-06-06 430 char *buf = NULL;
2b6cdda5981340 Yuri Nudelman 2021-06-06 431 size_t offset = 0, size = 0;
2b6cdda5981340 Yuri Nudelman 2021-06-06 432 int rc;
2b6cdda5981340 Yuri Nudelman 2021-06-06 433
2b6cdda5981340 Yuri Nudelman 2021-06-06 @434 rc = hl_snprintf_resize(&buf, &size, &offset,
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34139 bytes --]
next reply other threads:[~2021-07-29 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 7:05 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-27 23:26 [ogabbay:habanalabs-next 11/40] drivers/misc/habanalabs/common/state_dump.c:434:2: warning: Value stored to 'rc' is never read [clang-analyzer-deadcode.DeadStores] kernel test robot
2021-07-28 0:41 ` kernel test robot
2021-07-28 0:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107291514.R2ZxdANL-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.