From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F5AC4338F for ; Fri, 30 Jul 2021 09:44:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24E22603E9 for ; Fri, 30 Jul 2021 09:44:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 24E22603E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y1q/uPPyHAb4aDrlPagCdM7c/oEQUGj5msGh8OF0wP4=; b=HAdkjifcLzA+0t 5+pU/rQe1THfa54oyFqe2HPzAQ/DRKgM3EN+tk3Cq6cQJUmPbFscpbtkm2/AOl9HqDNjByuiX0VK1 2CPw9aaC63Oi4x2H9Foo4yrEDGEHUYKZV2IMvSmR0Rkjjdef5f1yoSA2anatEFbscVEaZVQTVG1AR IvT9epXoVJoKMKpCAnvmnsS8OEAkb2O32qCwAEY/tsoWGi4EMIq7C6cTgo9vud3IX8Cc/eYlN5uty QOo5EvijYOVWPHioOw5Gj15P3PcTba/lMr7/79vxTRazrD12aCPENWtfadYKgOjH3M2ktUrpvux2l cRscgaDxpSoVHcaNpRnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2a-007xnm-Oy; Fri, 30 Jul 2021 09:42:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9P2B-007xgS-JV for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 09:42:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3741D603E9; Fri, 30 Jul 2021 09:42:25 +0000 (UTC) Date: Fri, 30 Jul 2021 10:42:22 +0100 From: Catalin Marinas To: Guangbin Huang Cc: davem@davemloft.net, kuba@kernel.org, will@kernel.org, maz@kernel.org, mark.rutland@arm.com, dbrazdil@google.com, qperret@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lipeng321@huawei.com Subject: Re: [PATCH net-next 2/4] io: add function to flush the write combine buffer to device immediately Message-ID: <20210730094222.GB8570@arm.com> References: <1627614864-50824-1-git-send-email-huangguangbin2@huawei.com> <1627614864-50824-3-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1627614864-50824-3-git-send-email-huangguangbin2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_024227_718460_C7795366 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 30, 2021 at 11:14:22AM +0800, Guangbin Huang wrote: > From: Xiongfeng Wang > > Device registers can be mapped as write-combine type. In this case, data > are not written into the device immediately. They are temporarily stored > in the write combine buffer and written into the device when the buffer > is full. But in some situation, we need to flush the write combine > buffer to device immediately for better performance. So we add a general > function called 'flush_wc_write()'. We use DGH instruction to implement > this function for ARM64. Isn't this slightly misleading? IIUC DGH does not guarantee flushing, it just prevents writes merging (maybe this was already discussed on the previous RFC). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DF9C4320A for ; Fri, 30 Jul 2021 09:42:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82B35603E9 for ; Fri, 30 Jul 2021 09:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238304AbhG3Jmf (ORCPT ); Fri, 30 Jul 2021 05:42:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:53758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbhG3Jmb (ORCPT ); Fri, 30 Jul 2021 05:42:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3741D603E9; Fri, 30 Jul 2021 09:42:25 +0000 (UTC) Date: Fri, 30 Jul 2021 10:42:22 +0100 From: Catalin Marinas To: Guangbin Huang Cc: davem@davemloft.net, kuba@kernel.org, will@kernel.org, maz@kernel.org, mark.rutland@arm.com, dbrazdil@google.com, qperret@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lipeng321@huawei.com Subject: Re: [PATCH net-next 2/4] io: add function to flush the write combine buffer to device immediately Message-ID: <20210730094222.GB8570@arm.com> References: <1627614864-50824-1-git-send-email-huangguangbin2@huawei.com> <1627614864-50824-3-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1627614864-50824-3-git-send-email-huangguangbin2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 11:14:22AM +0800, Guangbin Huang wrote: > From: Xiongfeng Wang > > Device registers can be mapped as write-combine type. In this case, data > are not written into the device immediately. They are temporarily stored > in the write combine buffer and written into the device when the buffer > is full. But in some situation, we need to flush the write combine > buffer to device immediately for better performance. So we add a general > function called 'flush_wc_write()'. We use DGH instruction to implement > this function for ARM64. Isn't this slightly misleading? IIUC DGH does not guarantee flushing, it just prevents writes merging (maybe this was already discussed on the previous RFC). -- Catalin