Re: [RFC PATCH v3 3/6] drm/color: Add output transfer function to crtc

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4410 bytes --]

Hi Harry,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on linus/master v5.14-rc3 next-20210730]
[cannot apply to linux-arm/drm-armada-devel linux-arm/drm-armada-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/155348b7b734809c9952b773cf44a3f055f29588
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Harry-Wentland/A-drm_plane-API-to-support-HDR-planes/20210731-044401
        git checkout 155348b7b734809c9952b773cf44a3f055f29588
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/vc4/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vc4/vc4_crtc.c: In function 'vc4_crtc_init':
>> drivers/gpu/drm/vc4/vc4_crtc.c:1121:3: error: 'ret' undeclared (first use in this function); did you mean 'net'?
    1121 |   ret = drm_crtc_enable_color_mgmt(crtc, 0, false, crtc->gamma_size,
         |   ^~~
         |   net
   drivers/gpu/drm/vc4/vc4_crtc.c:1121:3: note: each undeclared identifier is reported only once for each function it appears in


vim +1121 drivers/gpu/drm/vc4/vc4_crtc.c

  1092	
  1093	int vc4_crtc_init(struct drm_device *drm, struct vc4_crtc *vc4_crtc,
  1094			  const struct drm_crtc_funcs *crtc_funcs,
  1095			  const struct drm_crtc_helper_funcs *crtc_helper_funcs)
  1096	{
  1097		struct vc4_dev *vc4 = to_vc4_dev(drm);
  1098		struct drm_crtc *crtc = &vc4_crtc->base;
  1099		struct drm_plane *primary_plane;
  1100		unsigned int i;
  1101	
  1102		/* For now, we create just the primary and the legacy cursor
  1103		 * planes.  We should be able to stack more planes on easily,
  1104		 * but to do that we would need to compute the bandwidth
  1105		 * requirement of the plane configuration, and reject ones
  1106		 * that will take too much.
  1107		 */
  1108		primary_plane = vc4_plane_init(drm, DRM_PLANE_TYPE_PRIMARY);
  1109		if (IS_ERR(primary_plane)) {
  1110			dev_err(drm->dev, "failed to construct primary plane\n");
  1111			return PTR_ERR(primary_plane);
  1112		}
  1113	
  1114		drm_crtc_init_with_planes(drm, crtc, primary_plane, NULL,
  1115					  crtc_funcs, NULL);
  1116		drm_crtc_helper_add(crtc, crtc_helper_funcs);
  1117	
  1118		if (!vc4->hvs->hvs5) {
  1119			drm_mode_crtc_set_gamma_size(crtc, ARRAY_SIZE(vc4_crtc->lut_r));
  1120	
> 1121			ret = drm_crtc_enable_color_mgmt(crtc, 0, false, crtc->gamma_size,
  1122							 BIT(DRM_TF_1D_LUT), DRM_TF_1D_LUT);
  1123			if (ret) {
  1124				dev_err(drm->dev, "failed to enable color management\n");
  1125				drm_crtc_cleanup(crtc);
  1126				return ret;
  1127			}
  1128	
  1129			/* We support CTM, but only for one CRTC at a time. It's therefore
  1130			 * implemented as private driver state in vc4_kms, not here.
  1131			 */
  1132			ret = drm_crtc_enable_color_mgmt(crtc, 0, true, crtc->gamma_size,
  1133							 BIT(DRM_TF_1D_LUT), DRM_TF_1D_LUT);
  1134			if (ret) {
  1135				dev_err(drm->dev, "failed to enable color management\n");
  1136				drm_crtc_cleanup(crtc);
  1137				return ret;
  1138			}
  1139		}
  1140	
  1141		for (i = 0; i < crtc->gamma_size; i++) {
  1142			vc4_crtc->lut_r[i] = i;
  1143			vc4_crtc->lut_g[i] = i;
  1144			vc4_crtc->lut_b[i] = i;
  1145		}
  1146	
  1147		return 0;
  1148	}
  1149	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54373 bytes --]