Re: [RFC PATCH v2 1/2] Add virtio Admin Virtqueue specification

["Michael S. Tsirkin" <mst@redhat.com>]

On Sun, Aug 01, 2021 at 01:53:10AM +0300, Max Gurtovoy wrote:
> > 
> > And yes, it also allows you to unload the generic driver and load
> > a vendor driver. Which can then go wild if it wants to - nothing
> > we can or want to do about it.
> 
> I don't get your point.

Talking about virtio admin interface (you are using a VQ now), it seems
to include or be planned to include several unrelated features, which
I'm not sure is appropriate and it sure makes review harder. I would
advise focusing on hypervisor management features such as live migration
etc, or some other subset. Also, there's overlap with existing
functionality such as feature negotiation.

Talking about vendor specific commands, I don't feel you demonstrated a
need for these beyond what already exists in the spec. In particular it
is unclear why there a need to layer vendor specific commands on top of
virtio. Using the existing capability would work at the PCI level which
seems more appropriate as vendor things are likely to be low level.

It might be a good idea to address these concerns in your next revision,
narrowing the scope as much as possible and explaining the motivation
for the new interfaces.

Thanks!

-- 
MST