From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D95C4320A for ; Sun, 1 Aug 2021 16:44:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96F2060720 for ; Sun, 1 Aug 2021 16:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbhHAQon (ORCPT ); Sun, 1 Aug 2021 12:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbhHAQon (ORCPT ); Sun, 1 Aug 2021 12:44:43 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A412C06175F for ; Sun, 1 Aug 2021 09:44:35 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id b6so22093078pji.4 for ; Sun, 01 Aug 2021 09:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9NdtZ+M8WQCeVD4BIR2vaRk3pqeGSmk7XeEKy9q9h0U=; b=gP9XuhvHdBGh2F/SVek/ldY7uGeyWNqBgqR+kyntTfIRo1AKeeIbuXK7RtRD4MIerb isiCbUkixUh/ohRFX82skqpOzeWgIyWs8ElZSJ3HdAUBXeQ7NEEzGm27PXaQCAOb4hHz DGWFM52KQXs1CcQ8eXEYBMgNyY+F3E2hmToqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9NdtZ+M8WQCeVD4BIR2vaRk3pqeGSmk7XeEKy9q9h0U=; b=gkKHZVSQjya1D+HfOsOfPHrxSyuSyS0g5bhFBPuRfFIWEojJaFKCKOJbk9V5ZTr3BU z+4rKk51fMv6vr0eVRoJQ0yAlO1MDCqXaAtkIzxmiQ1s4uWpVL6exPbWHydjrg+f8nIK fE91dpaiBHf4IvYsn5NQvlWUrYa0krpmAq0NIN6LmVIFodKJIT8+cc6j5Hgyz5FFsbRl oJGZ4qdC91MFsL/6BnS0eih30CaPz3xRnUR2Cvb9TjTu8zDnH9swi7cCUlIBBLudf3vj GHt5tR1APq0h0LqZpDguCjrUo5ajK3J+oBgSu//sy1gE3TJwUd/EQAk2931/cql5X/Z4 9baQ== X-Gm-Message-State: AOAM533EMzn5vRALTxO3xXPoQhHpP2GKVcEF/4B1kUE4NfHQYO5VP/nx qtrmAyBWWyu/x+lTcuadKonj8A== X-Google-Smtp-Source: ABdhPJz8VbM5XQgXgUec6CExsiHwloVTLYiatWTmTcvkZiJ+WLe2l2Yv3aDhTYwhCKRcPUCBFCT8EQ== X-Received: by 2002:a17:90a:c085:: with SMTP id o5mr3925399pjs.9.1627836274852; Sun, 01 Aug 2021 09:44:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g71sm8945302pfb.139.2021.08.01.09.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Aug 2021 09:44:34 -0700 (PDT) Date: Sun, 1 Aug 2021 09:44:33 -0700 From: Kees Cook To: Len Baker Cc: "Russell King (Oracle)" , Dmitry Torokhov , Lee Jones , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-hardening@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches Subject: Re: [PATCH] drivers/input: Remove all strcpy() uses in favor of strscpy() Message-ID: <202108010934.FA668DEB28@keescook> References: <20210801144316.12841-1-len.baker@gmx.com> <20210801145959.GI22278@shell.armlinux.org.uk> <20210801155732.GA16547@titan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210801155732.GA16547@titan> Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Sun, Aug 01, 2021 at 05:57:32PM +0200, Len Baker wrote: > Hi, > > On Sun, Aug 01, 2021 at 04:00:00PM +0100, Russell King (Oracle) wrote: > > On Sun, Aug 01, 2021 at 04:43:16PM +0200, Len Baker wrote: > > > strcpy() performs no bounds checking on the destination buffer. This > > > could result in linear overflows beyond the end of the buffer, leading > > > to all kinds of misbehaviors. The safe replacement is strscpy(). > > > > > > Signed-off-by: Len Baker > > > --- > > > This is a task of the KSPP [1] > > > > > > [1] https://github.com/KSPP/linux/issues/88 > > > > > > drivers/input/keyboard/locomokbd.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/input/keyboard/locomokbd.c b/drivers/input/keyboard/locomokbd.c > > > index dae053596572..dbb3dc48df12 100644 > > > --- a/drivers/input/keyboard/locomokbd.c > > > +++ b/drivers/input/keyboard/locomokbd.c > > > @@ -254,7 +254,7 @@ static int locomokbd_probe(struct locomo_dev *dev) > > > locomokbd->suspend_jiffies = jiffies; > > > > > > locomokbd->input = input_dev; > > > - strcpy(locomokbd->phys, "locomokbd/input0"); > > > + strscpy(locomokbd->phys, "locomokbd/input0", sizeof(locomokbd->phys)); > > > > So if the string doesn't fit, it's fine to silently truncate it? > > I think it is better than overflow :) > > > Rather than converting every single strcpy() in the kernel to > > strscpy(), maybe there should be some consideration given to how the > > issue of a strcpy() that overflows the buffer should be handled. > > E.g. in the case of a known string such as the above, if it's longer > > than the destination, should we find a way to make the compiler issue > > a warning at compile time? > > Good point. I am a kernel newbie and have no experience. So this > question should be answered by some kernel hacker :) But I agree > with your proposals. > > Kees and folks: Any comments? > > Note: Kees is asked the same question in [2] > > [2] https://lore.kernel.org/lkml/20210731135957.GB1979@titan/ Hi! Sorry for the delay at looking into this. It didn't use to be a problem (there would always have been a compile-time warning generated for known-too-small cases), but that appears to have regressed when, ironically, strscpy() coverage was added. I've detailed it in the bug report: https://github.com/KSPP/linux/issues/88 So, bottom line: we need to fix the missing compile-time warnings for strcpy() and strscpy() under CONFIG_FORTIFY_SOURCE=y. In the past we'd tried to add a stracpy()[1] that would only work with const string sources. Linus got angry[2] about API explosion, though, so we're mostly faced with doing the strscpy() replacements. Another idea might be to have strcpy() do the "constant strings only" thing, leaving strscpy() for the dynamic lengths. One thing is clear: replacing strlcpy() with strscpy() is probably the easiest and best first step to cleaning up the proliferation of str*() functions. -Kees [1] https://lore.kernel.org/lkml/ed4611a4a96057bf8076856560bfbf9b5e95d390.1563889130.git.joe@perches.com/ [2] https://lore.kernel.org/lkml/CAHk-=wgqQKoAnhmhGE-2PBFt7oQs9LLAATKbYa573UO=DPBE0Q@mail.gmail.com/ -- Kees Cook