From: kernel test robot <lkp@intel.com>
To: Amey Narkhede <ameynarkhede03@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
alex.williamson@redhat.com,
Raphael Norwitz <raphael.norwitz@nutanix.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
kw@linux.com, Shanker Donthineni <sdonthineni@nvidia.com>,
Sinan Kaya <okaya@kernel.org>, Len Brown <lenb@kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods
Date: Mon, 2 Aug 2021 02:17:44 +0800 [thread overview]
Message-ID: <202108020257.WIyTlyUI-lkp@intel.com> (raw)
In-Reply-To: <20210801142518.1224-3-ameynarkhede03@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3268 bytes --]
Hi Amey,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pci/next]
[also build test WARNING on pm/linux-next cryptodev/master crypto/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-r025-20210801 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
git checkout ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/pci.c:4636:6: warning: no previous prototype for function 'pcie_has_flr' [-Wmissing-prototypes]
bool pcie_has_flr(struct pci_dev *dev)
^
drivers/pci/pci.c:4636:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool pcie_has_flr(struct pci_dev *dev)
^
static
1 warning generated.
vim +/pcie_has_flr +4636 drivers/pci/pci.c
3775a209d38aa3 Casey Leedom 2013-08-06 4628
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4629 /**
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4630 * pcie_has_flr - check if a device supports function level resets
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4631 * @dev: device to check
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4632 *
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4633 * Returns true if the device advertises support for PCIe function level
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4634 * resets.
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4635 */
2d2917f7747805 Alex Williamson 2018-08-09 @4636 bool pcie_has_flr(struct pci_dev *dev)
3775a209d38aa3 Casey Leedom 2013-08-06 4637 {
f65fd1aa4f9881 Sasha Neftin 2017-04-03 4638 if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4639 return false;
3775a209d38aa3 Casey Leedom 2013-08-06 4640
e8213ae6f11e62 Amey Narkhede 2021-08-01 4641 return FIELD_GET(PCI_EXP_DEVCAP_FLR, dev->devcap) == 1;
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4642 }
3775a209d38aa3 Casey Leedom 2013-08-06 4643
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35557 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods
Date: Mon, 02 Aug 2021 02:17:44 +0800 [thread overview]
Message-ID: <202108020257.WIyTlyUI-lkp@intel.com> (raw)
In-Reply-To: <20210801142518.1224-3-ameynarkhede03@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3331 bytes --]
Hi Amey,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pci/next]
[also build test WARNING on pm/linux-next cryptodev/master crypto/master linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-r025-20210801 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Amey-Narkhede/PCI-Expose-and-manage-PCI-device-reset/20210801-222806
git checkout ce304ecb5f2709fa58ef6f16cf8e89ddbd7e42cd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/pci.c:4636:6: warning: no previous prototype for function 'pcie_has_flr' [-Wmissing-prototypes]
bool pcie_has_flr(struct pci_dev *dev)
^
drivers/pci/pci.c:4636:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool pcie_has_flr(struct pci_dev *dev)
^
static
1 warning generated.
vim +/pcie_has_flr +4636 drivers/pci/pci.c
3775a209d38aa3 Casey Leedom 2013-08-06 4628
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4629 /**
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4630 * pcie_has_flr - check if a device supports function level resets
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4631 * @dev: device to check
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4632 *
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4633 * Returns true if the device advertises support for PCIe function level
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4634 * resets.
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4635 */
2d2917f7747805 Alex Williamson 2018-08-09 @4636 bool pcie_has_flr(struct pci_dev *dev)
3775a209d38aa3 Casey Leedom 2013-08-06 4637 {
f65fd1aa4f9881 Sasha Neftin 2017-04-03 4638 if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4639 return false;
3775a209d38aa3 Casey Leedom 2013-08-06 4640
e8213ae6f11e62 Amey Narkhede 2021-08-01 4641 return FIELD_GET(PCI_EXP_DEVCAP_FLR, dev->devcap) == 1;
a60a2b73ba69ab Christoph Hellwig 2017-04-14 4642 }
3775a209d38aa3 Casey Leedom 2013-08-06 4643
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35557 bytes --]
next prev parent reply other threads:[~2021-08-01 18:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-01 14:25 [PATCH v13 0/9] PCI: Expose and manage PCI device reset Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 1/9] PCI: Cache PCIe FLR capability Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods Amey Narkhede
2021-08-01 17:04 ` kernel test robot
2021-08-01 17:04 ` kernel test robot
2021-08-01 17:05 ` [RFC PATCH] PCI: pcie_has_flr() can be static kernel test robot
2021-08-01 17:05 ` kernel test robot
2021-08-01 18:17 ` kernel test robot [this message]
2021-08-01 18:17 ` [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods kernel test robot
2021-08-02 22:44 ` Bjorn Helgaas
2021-08-03 4:49 ` Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 3/9] PCI: Add new array for keeping track of ordering of " Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 4/9] PCI: Remove reset_fn field from pci_dev Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 5/9] PCI: Allow userspace to query and set device reset mechanism Amey Narkhede
2021-08-02 22:55 ` Bjorn Helgaas
2021-08-03 6:34 ` Amey Narkhede
2021-08-03 13:45 ` Shanker R Donthineni
2021-08-01 14:25 ` [PATCH v13 6/9] PCI: Define a function to set ACPI_COMPANION in pci_dev Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 7/9] PCI: Setup ACPI fwnode early and at the same time with OF Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 8/9] PCI: Add support for ACPI _RST reset method Amey Narkhede
2021-08-01 14:25 ` [PATCH v13 9/9] PCI: Change the type of probe argument in reset functions Amey Narkhede
2021-08-02 22:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108020257.WIyTlyUI-lkp@intel.com \
--to=lkp@intel.com \
--cc=alex.williamson@redhat.com \
--cc=ameynarkhede03@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kw@linux.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=raphael.norwitz@nutanix.com \
--cc=rjw@rjwysocki.net \
--cc=sdonthineni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.