Re: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines

["Bruce Ashfield" <bruce.ashfield@gmail.com>]

Looks good to me.

I'll wait to hear from Jon that it fixes his problem before merging.

Cheers,

Bruce

In message: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
on 01/08/2021 Christopher Clark wrote:
> The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
> requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
> binary to use. Skip the task if it is not set.
> 
> Reported-by: Jon Mason <jdmason@kudzu.us>
> Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
> ---
>  classes/qemuboot-xen-dtb.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> index 08f9b02..2d37e91 100644
> --- a/classes/qemuboot-xen-dtb.bbclass
> +++ b/classes/qemuboot-xen-dtb.bbclass
> @@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
>      # Not all architectures qemuboot with a device tree binary, so check
>      # to see if one is needed. This allows this bbclass file to be used
>      # in the same image recipe for multiple architectures.
> -    if [ -n "${QB_DTB}" ] ; then
> +    if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
>          generate_xen_qemuboot_dtb
>      fi
>  }
> -- 
> 2.25.1
>