From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5530145454551588874==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] counter: fix stream_open.cocci warnings Date: Wed, 04 Aug 2021 00:39:59 +0800 Message-ID: <20210803163959.GA31656@e94a524e3eb9> In-Reply-To: <202108040052.XtK6a9wi-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============5530145454551588874== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org In-Reply-To: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhe= lm.gray@gmail.com> References: <2c51fa594245c3396400617caa686b8bf0887d16.1627990337.git.vilhel= m.gray@gmail.com> TO: William Breathitt Gray From: kernel test robot drivers/counter/counter-chrdev.c:370:8-24: WARNING: counter_fops: .read() h= as stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci CC: William Breathitt Gray Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Int= roduce-the-Counter-character-device-interface/20210803-201000 base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git s= tm32-next :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago Please take the patch only if it's a positive warning. Thanks! counter-chrdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/counter/counter-chrdev.c +++ b/drivers/counter/counter-chrdev.c @@ -367,7 +367,7 @@ static int counter_chrdev_open(struct in get_device(&counter->dev); filp->private_data =3D counter; = - return nonseekable_open(inode, filp); + return stream_open(inode, filp); } = static int counter_chrdev_release(struct inode *inode, struct file *filp) --===============5530145454551588874==--