From: Corey Minyard <cminyard@mvista.com>
To: Shengtan Mao <stmao@google.com>
Cc: venture@google.com, qemu-devel@nongnu.org, wuhaotsh@google.com,
qemu-arm@nongnu.org, maoshengtan2011@gmail.com,
crauer@google.com
Subject: Re: [PATCH v2 0/1] Add remote I2C device to support external I2C device
Date: Tue, 3 Aug 2021 14:29:08 -0500 [thread overview]
Message-ID: <20210803192908.GU3431@minyard.net> (raw)
In-Reply-To: <20210802230323.1164787-3-stmao@google.com>
On Mon, Aug 02, 2021 at 11:03:22PM +0000, Shengtan Mao wrote:
> This patch implements the remote I2C device.
> The remote I2C device allows an external I2C device to communicate with the I2C controller in QEMU through the remote I2C protocol.
> Users no longer have to directly modify QEMU to add new I2C devices and can instead implement the emulated device externally and connect it to the remote I2C device.
I apologise, I haven't had time to look at this, and I'm going to be
really busy for a little while.
I looked it over a bit, and is there some description of the protocol?
Could you add a reference to it in the code?
-corey
>
> Previous work by Wolfram Sang (https://git.kernel.org/pub/scm/virt/qemu/wsa/qemu.git/commit/?h=i2c-passthrough) was referenced.
> It shares the similar idea of redirecting the actual I2C device functionalities, but Sang focuses on physical devices, and we focus on emulated devices.
> The work by Sang mainly utilizes file descriptors while ours utilizes character devices, which offers better support for emulated devices.
> The work by Sang is not meant to offer full I2C device support; it only implements the receive functionality.
> Our work implements full support for I2C devices: send, recv, and event (match_and_add is not applicable for external devices).
>
> Shengtan Mao (1):
> hw/i2c: add remote I2C device
>
> hw/arm/Kconfig | 1 +
> hw/i2c/Kconfig | 4 +
> hw/i2c/meson.build | 1 +
> hw/i2c/remote-i2c.c | 117 ++++++++++++++++++
> tests/qtest/meson.build | 1 +
> tests/qtest/remote-i2c-test.c | 216 ++++++++++++++++++++++++++++++++++
> 6 files changed, 340 insertions(+)
> create mode 100644 hw/i2c/remote-i2c.c
> create mode 100644 tests/qtest/remote-i2c-test.c
>
> --
> 2.32.0.554.ge1b32706d8-goog
>
next prev parent reply other threads:[~2021-08-03 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 23:03 [PATCH v2 0/1] Add remote I2C device to support external I2C device Shengtan Mao
2021-08-02 23:03 ` [PATCH 1/1] hw/i2c: add remote " Shengtan Mao
2021-08-02 23:48 ` Shengtan Mao
2021-08-02 23:03 ` [PATCH v2 0/1] Add remote I2C device to support external " Shengtan Mao
2021-08-03 19:29 ` Corey Minyard [this message]
2021-08-02 23:03 ` [PATCH v2 1/1] hw/i2c: add remote " Shengtan Mao
2021-08-02 23:47 ` [PATCH v2 0/1] Add remote I2C device to support external " Shengtan Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803192908.GU3431@minyard.net \
--to=cminyard@mvista.com \
--cc=crauer@google.com \
--cc=maoshengtan2011@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stmao@google.com \
--cc=venture@google.com \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.