Re: [PATCH v14 06/17] counter: Internalize sysfs interface code

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5958 bytes --]

Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on stm32/stm32-next]
[also build test WARNING on linus/master v5.14-rc4 next-20210802]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210803-201000
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/490c9a9a44e9c680fa6658f0710bb81831173299
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20210803-201000
        git checkout 490c9a9a44e9c680fa6658f0710bb81831173299
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/counter/stm32-timer-cnt.c:55:2: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
      55 |  STM32_COUNT_SLAVE_MODE_DISABLED,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-timer-cnt.c:56:2: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
      56 |  STM32_COUNT_ENCODER_MODE_1,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-timer-cnt.c:57:2: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
      57 |  STM32_COUNT_ENCODER_MODE_2,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-timer-cnt.c:58:2: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
      58 |  STM32_COUNT_ENCODER_MODE_3,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-timer-cnt.c: In function 'stm32_count_function_read':
   drivers/counter/stm32-timer-cnt.c:97:13: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
      97 |   *function = STM32_COUNT_SLAVE_MODE_DISABLED;
         |             ^
   drivers/counter/stm32-timer-cnt.c:100:13: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
     100 |   *function = STM32_COUNT_ENCODER_MODE_1;
         |             ^
   drivers/counter/stm32-timer-cnt.c:103:13: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
     103 |   *function = STM32_COUNT_ENCODER_MODE_2;
         |             ^
   drivers/counter/stm32-timer-cnt.c:106:13: warning: implicit conversion from 'enum stm32_count_function' to 'enum counter_function' [-Wenum-conversion]
     106 |   *function = STM32_COUNT_ENCODER_MODE_3;
         |             ^
--
>> drivers/counter/stm32-lptimer-cnt.c:139:2: warning: implicit conversion from 'enum stm32_lptim_cnt_function' to 'enum counter_function' [-Wenum-conversion]
     139 |  STM32_LPTIM_COUNTER_INCREASE,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-lptimer-cnt.c:140:2: warning: implicit conversion from 'enum stm32_lptim_cnt_function' to 'enum counter_function' [-Wenum-conversion]
     140 |  STM32_LPTIM_ENCODER_BOTH_EDGE,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/stm32-lptimer-cnt.c: In function 'stm32_lptim_cnt_function_read':
   drivers/counter/stm32-lptimer-cnt.c:195:13: warning: implicit conversion from 'enum stm32_lptim_cnt_function' to 'enum counter_function' [-Wenum-conversion]
     195 |   *function = STM32_LPTIM_COUNTER_INCREASE;
         |             ^
   drivers/counter/stm32-lptimer-cnt.c:200:13: warning: implicit conversion from 'enum stm32_lptim_cnt_function' to 'enum counter_function' [-Wenum-conversion]
     200 |   *function = STM32_LPTIM_ENCODER_BOTH_EDGE;
         |             ^
--
>> drivers/counter/ftm-quaddec.c:162:2: warning: implicit conversion from 'enum ftm_quaddec_count_function' to 'enum counter_function' [-Wenum-conversion]
     162 |  FTM_QUADDEC_COUNT_ENCODER_MODE_1
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/counter/ftm-quaddec.c: In function 'ftm_quaddec_count_function_read':
   drivers/counter/ftm-quaddec.c:199:12: warning: implicit conversion from 'enum ftm_quaddec_count_function' to 'enum counter_function' [-Wenum-conversion]
     199 |  *function = FTM_QUADDEC_COUNT_ENCODER_MODE_1;
         |            ^


vim +55 drivers/counter/stm32-timer-cnt.c

490c9a9a44e9c6 William Breathitt Gray 2021-08-03  53  
490c9a9a44e9c6 William Breathitt Gray 2021-08-03  54  static const enum counter_function stm32_count_functions[] = {
fae6f62e6a580b William Breathitt Gray 2021-02-26 @55  	STM32_COUNT_SLAVE_MODE_DISABLED,
ad29937e206f5e Benjamin Gaignard      2019-04-02  56  	STM32_COUNT_ENCODER_MODE_1,
ad29937e206f5e Benjamin Gaignard      2019-04-02  57  	STM32_COUNT_ENCODER_MODE_2,
ad29937e206f5e Benjamin Gaignard      2019-04-02  58  	STM32_COUNT_ENCODER_MODE_3,
ad29937e206f5e Benjamin Gaignard      2019-04-02  59  };
ad29937e206f5e Benjamin Gaignard      2019-04-02  60  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60682 bytes --]