From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: r8188eu: Remove wrappers for kalloc() and kzalloc()
Date: Wed, 4 Aug 2021 16:15:50 +0300 [thread overview]
Message-ID: <20210804131550.GL1931@kadam> (raw)
In-Reply-To: <20210802151546.31797-2-Larry.Finger@lwfinger.net>
On Mon, Aug 02, 2021 at 10:15:41AM -0500, Larry Finger wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c.rej b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
> new file mode 100644
> index 000000000000..18113389acce
> --- /dev/null
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
;) Something went wrong.
(I'm not going to review the rest of this series.)
> @@ -0,0 +1,11 @@
> +--- drivers/staging/r8188eu/core/rtw_br_ext.c
> ++++ drivers/staging/r8188eu/core/rtw_br_ext.c
> +@@ -420,7 +420,7 @@ static void __nat25_db_network_insert(st
> + }
> + db = db->next_hash;
> + }
> +- db = (struct nat25_network_db_entry *) rtw_malloc(sizeof(*db));
> ++ db = kmalloc(sizeof(*db), GFP_KERNEL);
> + if (db == NULL) {
> + spin_unlock_bh(&priv->br_ext_lock);
> + return;
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-04 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 15:15 [PATCH 0/6] Clean up some extraneous wrappers and some empty routines Larry Finger
2021-08-02 15:15 ` [PATCH 1/6] staging: r8188eu: Remove wrappers for kalloc() and kzalloc() Larry Finger
2021-08-04 13:15 ` Dan Carpenter [this message]
2021-08-04 13:47 ` Larry Finger
2021-08-02 15:15 ` [PATCH 2/6] staging: r8188eu: Remove wrapper around vfree Larry Finger
2021-08-02 17:50 ` kernel test robot
2021-08-02 17:50 ` kernel test robot
2021-08-02 15:15 ` [PATCH 3/6] staging: r8188eu: Remove wrappers for atomic operations Larry Finger
2021-08-02 15:15 ` [PATCH 4/6] staging: r8188eu: Remove 4 empty routines from os_sep/service.c Larry Finger
2021-08-02 15:15 ` [PATCH 5/6] staging: r8188eu: Remove all calls to _rtw_spinlock_free() Larry Finger
2021-08-02 15:15 ` [PATCH 6/6] staging: r8188eu: Remove more empty routines Larry Finger
2021-08-02 17:19 ` [PATCH 0/6] Clean up some extraneous wrappers and some " Fabio Aiuto
2021-08-02 18:51 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804131550.GL1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.