From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, Nishanth Menon <nmenon@kernel.org>
Subject: Re: [PATCH] ARM: Fix Keystone 2 kernel mapping regression
Date: Wed, 4 Aug 2021 15:10:42 +0100 [thread overview]
Message-ID: <20210804141042.GQ22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210804135747.737233-1-linus.walleij@linaro.org>
Hi Linus,
Looks fine. An improvement:
On Wed, Aug 04, 2021 at 03:57:47PM +0200, Linus Walleij wrote:
> @@ -250,7 +253,12 @@ __create_page_tables:
> add r0, r4, #KERNEL_OFFSET >> (SECTION_SHIFT - PMD_ORDER)
> ldr r6, =(_end - 1)
> adr_l r5, kernel_sec_start @ _pa(kernel_sec_start)
> - str r8, [r5] @ Save physical start of kernel
> +#ifdef CONFIG_CPU_ENDIAN_BE8
> + add r5, r5, #4 @ Move to the upper 32bit word
> + str r8, [r5] @ Save physical start of kernel (BE)
These two instructions can simply be replaced with:
str r8, [r5, #4]
> +#else
> + str r8, [r5] @ Save physical start of kernel (LE)
> +#endif
> orr r3, r8, r7 @ Add the MMU flags
> add r6, r4, r6, lsr #(SECTION_SHIFT - PMD_ORDER)
> 1: str r3, [r0], #1 << PMD_ORDER
> @@ -259,7 +267,12 @@ __create_page_tables:
> bls 1b
> eor r3, r3, r7 @ Remove the MMU flags
> adr_l r5, kernel_sec_end @ _pa(kernel_sec_end)
> - str r3, [r5] @ Save physical end of kernel
> +#ifdef CONFIG_CPU_ENDIAN_BE8
> + add r5, r5, #4 @ Move to the upper 32bit word
> + str r8, [r5] @ Save physical end of kernel (BE)
Same here.
The patch can still usefully be tested by Nishanth without these
changes... it'll tell us if this was indeed the issue.
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-04 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 13:57 [PATCH] ARM: Fix Keystone 2 kernel mapping regression Linus Walleij
2021-08-04 14:10 ` Russell King (Oracle) [this message]
2021-08-04 16:23 ` Grygorii Strashko
2021-08-04 16:40 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804141042.GQ22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nmenon@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.