Re: [PATCH V4 2/2] gpio: virtio: Add IRQ support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5329 bytes --]

Hi Viresh,

I love your patch! Perhaps something to improve:

[auto build test WARNING on soc/for-next]
[also build test WARNING on vhost/linux-next linus/master v5.14-rc4 next-20210803]
[cannot apply to gpio/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Viresh-Kumar/gpio-Add-virtio-based-driver/20210803-193849
base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8dd9cb7c610a2132488399e36ff7fe34115035ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Viresh-Kumar/gpio-Add-virtio-based-driver/20210803-193849
        git checkout 8dd9cb7c610a2132488399e36ff7fe34115035ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/gpio/driver.h:5,
                    from drivers/gpio/gpio-virtio.c:14:
   drivers/gpio/gpio-virtio.c: In function 'vgpio_work_handler':
>> drivers/gpio/gpio-virtio.c:364:17: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
     364 |    dev_err(dev, "irq with incorrect length (%u : %lu)\n",
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
      19 | #define dev_fmt(fmt) fmt
         |                      ^~~
   drivers/gpio/gpio-virtio.c:364:4: note: in expansion of macro 'dev_err'
     364 |    dev_err(dev, "irq with incorrect length (%u : %lu)\n",
         |    ^~~~~~~
   drivers/gpio/gpio-virtio.c:364:52: note: format string is defined here
     364 |    dev_err(dev, "irq with incorrect length (%u : %lu)\n",
         |                                                  ~~^
         |                                                    |
         |                                                    long unsigned int
         |                                                  %u
   drivers/gpio/gpio-virtio.c: At top level:
   drivers/gpio/gpio-virtio.c:623:4: error: 'VIRTIO_ID_GPIO' undeclared here (not in a function); did you mean 'VIRTIO_ID_GPU'?
     623 |  { VIRTIO_ID_GPIO, VIRTIO_DEV_ANY_ID },
         |    ^~~~~~~~~~~~~~
         |    VIRTIO_ID_GPU


vim +364 drivers/gpio/gpio-virtio.c

   346	
   347	static void vgpio_work_handler(struct work_struct *work)
   348	{
   349		struct virtio_gpio *vgpio = container_of(work, struct virtio_gpio,
   350							 work);
   351		struct device *dev = &vgpio->vdev->dev;
   352		struct vgpio_irq_line *irq_line;
   353		int irq, gpio, ret;
   354		unsigned int len;
   355	
   356		mutex_lock(&vgpio->irq_lock);
   357	
   358		while (true) {
   359			irq_line = virtqueue_get_buf(vgpio->event_vq, &len);
   360			if (!irq_line)
   361				break;
   362	
   363			if (len != sizeof(irq_line->ires)) {
 > 364				dev_err(dev, "irq with incorrect length (%u : %lu)\n",
   365					len, sizeof(irq_line->ires));
   366				continue;
   367			}
   368	
   369			WARN_ON(!irq_line->queued);
   370			irq_line->queued = false;
   371	
   372			/* Buffer is returned after interrupt is masked */
   373			if (irq_line->ires.status == VIRTIO_GPIO_IRQ_STATUS_INVALID)
   374				continue;
   375	
   376			if (WARN_ON(irq_line->ires.status != VIRTIO_GPIO_IRQ_STATUS_VALID))
   377				continue;
   378	
   379			/*
   380			 * Find GPIO line number from the offset of irq_line within the
   381			 * irq_lines block. We can also get GPIO number from
   382			 * irq-request, but better not rely on a value returned by
   383			 * remote.
   384			 */
   385			gpio = irq_line - vgpio->irq_lines;
   386			WARN_ON(gpio >= vgpio->config.ngpio);
   387	
   388			irq = irq_find_mapping(vgpio->gc.irq.domain, gpio);
   389			WARN_ON(!irq);
   390	
   391			local_irq_disable();
   392			ret = generic_handle_irq(irq);
   393			local_irq_enable();
   394	
   395			if (ret)
   396				dev_err(dev, "failed to handle interrupt: %d\n", ret);
   397	
   398			/* The interrupt may have been disabled by now */
   399			if (irq_line->update_pending && irq_line->masked)
   400				update_irq_type(vgpio, gpio, VIRTIO_GPIO_IRQ_TYPE_NONE);
   401			else
   402				virtio_gpio_irq_prepare(vgpio, gpio);
   403	
   404			irq_line->update_pending = false;
   405		};
   406	
   407		mutex_unlock(&vgpio->irq_lock);
   408	}
   409	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60681 bytes --]