From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:49528 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234423AbhHDO4d (ORCPT ); Wed, 4 Aug 2021 10:56:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=1oyiLvNDjr30GERaxT9m5SuvebD82Fqb9o5PTc/CdVw=; b=ylsYu1IAz733g6T469lWjbHRWzKhk2qlyZhwafB+d9CgyjpT71X4WjlmY5lOuOnBvoCG l/VvwIu6Yhw4kk2JzK5zFBYEGFTlrmQCIamdw0ZlvAqaJlLAnnhaAnWfHzwBytuLzrsP OtAPiiYCk5tuL6nl9RhB+R9WY2Fl4RnaUO5rWxu5NhgYclVFbXBzIQq5N7yVH8m3UHID 8iZt57hllx8sIp6NGaqV+PwA5CqqESMaNA/pjzmZm6cLmKdGh9R/+XcxtTW0gjl3xYnn S7smcibuuSVKr8DYKjRa3feqKHdZho/jY1nxySkcy5BkmFKwOjJ6Mt1fb91U6tzpb6MR SA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=1oyiLvNDjr30GERaxT9m5SuvebD82Fqb9o5PTc/CdVw=; b=bWWZ4e4j9Gp+T+BvwIVQhpfEma1wMqQGtuvsHxHa7WgBrmHRHHMVhoWdoww6/QoZfL+9 B9DaLEN+RbkpCiCr0jXdnlT1M/NStLoFAXYnW0euwNDgkbsteo/OPahbq5FsVola9NAV tqRnL/pu8T4c5TGSPq5cFhFG8OyulsPDIOLAnJJUwp6O19EXrFuLWR5filcgC3Dyh4CO SKbWZfPek5jd8enZZQyHz/6iirhHb9uWI5Py1TMCePxWnH7/ulf+SfJs8oI67sFIhyVU ReGUBDWmGf6fLG58U2QT4UXuiHg9Dd625yk/aXy21LtdRGFfwJpbd0eAqGxEvR3k6qFX 0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oyiLvNDjr30GERaxT9m5SuvebD82Fqb9o5PTc/CdVw=; b=lbhzsQ4uZkNzx6Ax0A5CWWoKzb2oStsB0S1PjSjYlaqChGDn/c7qPhcX2yBrV5IVVd5aqpvsKXL1vyZWYPj18GGSTe9q3Zbzrs8ySkzpG4TDBLtnT5xC76q5PmeHGRC6MFSDyQ3tIwo4uGgJbGykL+qhHo61W/wAmQcZq5rv/jo= Date: Wed, 4 Aug 2021 17:55:57 +0300 From: Dan Carpenter Subject: Re: [PATCH] check_netdev_priv: warn about using netdev priv data after free_netdev Message-ID: <20210804145557.GH22532@kadam> References: <20210802210022.5226-1-paskripkin@gmail.com> <20210804143532.GM1931@kadam> <638a2d48-59d3-30c3-8ef4-56d9f0d3f56a@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <638a2d48-59d3-30c3-8ef4-56d9f0d3f56a@gmail.com> MIME-Version: 1.0 List-ID: To: Pavel Skripkin Cc: smatch@vger.kernel.org On Wed, Aug 04, 2021 at 05:44:09PM +0300, Pavel Skripkin wrote: > On 8/4/21 5:35 PM, Dan Carpenter wrote: > > Pushed! > > > > This finds two bugs in my allmodconfig. They're both real bugs. > > > > drivers/net/ethernet/freescale/fec_main.c:3994 fec_drv_remove() error: Using fep after free_{netdev,candev}(ndev); > > drivers/net/ethernet/freescale/fec_main.c:3995 fec_drv_remove() error: Using fep after free_{netdev,candev}(ndev); > > drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev); > > drivers/net/ethernet/neterion/vxge/vxge-main.c:3518 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev); > > drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev); > > drivers/net/ethernet/neterion/vxge/vxge-main.c:3520 vxge_device_unregister() error: Using vdev after free_{netdev,candev}(dev); > > > > I can send patches to fix these errors with Reported-by tag, or You will > take care of it? Yes, please send the fixes. These are your discovery. You get first dibs. ;) regards, dan carpenter