From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ren Date: Wed, 4 Aug 2021 18:19:51 -0700 Subject: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC In-Reply-To: References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> Message-ID: <20210805011951.GA28444@taoren-ubuntu-R90MNF91> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > From: Tao Ren > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > I like to read what kind of platform the BMC is going into if you can > add that detail, but it's not essential. Sure. I will add more details in v2. > > +&spi1 { > > + status = "okay"; > > + > > + /* > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > + * the bus) to save vmalloc space. > > + */ > > + reg = < 0x1e630000 0xc4 > > + 0x30000000 0x2000000 >; > > Which driver supports this? > > It would be great to see Facebook work to get the SPI NOR driver for > the ast2600 merged to mainline. > > I doubt the IBM team will get to this, as we are using eMMC instead. Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought the driver patches were also upstreamed. Let me remove the entry for now, and will add it back when the driver is ready. > > > + > > + flash at 0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "spi1.0"; > > + spi-max-frequency = <5000000>; > > + > > + partitions { > > + compatible = "fixed-partitions"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + flash1 at 0 { > > + reg = <0x0 0x2000000>; > > + label = "system-flash"; > > + }; > > + }; > > + }; > > +}; > > > +&ehci1 { > > + status = "okay"; > > +}; > > Have you verified that USB works with mainline? I've had reports of it > working on 5.8 but it seems to have regressed as of v5.10. It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence"): ehci_handshake() returns error because HCHalted bit EHCI24[12] stays at 1. I have a dirty hack in my tree (ignoring the halt bit) and it "works" on AST2500 and AST2600. Let me send an email to openbmc and aspeed email groups to see if anyone has more context. Meanwhile, should I delete the entry until the fix is ready in driver? > > +&mdio1 { > > + status = "okay"; > > + > > + ethphy3: ethernet-phy at 13 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x0d>; > > + }; > > +}; > > + > > +&mac3 { > > + phy-handle = <ðphy3>; > > status = okay? > > You should specify the pinmux too I think, even if the default happens > to work, so that other devices cannot claim the pins. status is set in ast2600 common dtsi, but let me set it here to avoid confusion. Will update pinmux in v2. Thanks. > > Cheers, > > Joel Cheers, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853D6C4338F for ; Thu, 5 Aug 2021 01:20:30 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D25560F38 for ; Thu, 5 Aug 2021 01:20:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D25560F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Gg9lc4JpVz3bZ3 for ; Thu, 5 Aug 2021 11:20:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=czFhfxgA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::634; helo=mail-pl1-x634.google.com; envelope-from=rentao.bupt@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=czFhfxgA; dkim-atps=neutral Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Gg9l61mZDz3079; Thu, 5 Aug 2021 11:20:00 +1000 (AEST) Received: by mail-pl1-x634.google.com with SMTP id e21so5118530pla.5; Wed, 04 Aug 2021 18:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=czFhfxgAUEDaFdM3Hcun5CUGzve9qBhEHhdgHBmOX7olliuFKN8DXgEe+rmKmWat+L 9mJyEreTCcY9wJOpkumioORcnXgQzD2mgUmfb8cHczaZku6gWfEFHyDULFrbZ1Qkc2Fb w63Puypnh8M8XBOv2KOl5W9ml8QulLssN8QoK10Wjo+2Y386UtpiMhlLjuhbVj4TdOuB pvqKjUhBeZHINJCJM53M/eymo4U+UKhmtE5VcRQ+hQFyt9j6QvVl0xQWmwI7zrDcM1sm tFrqNxnw9BmxW3fhzyQMf8dW7uptS6+uWujOdhQ9442difFXq0vS6iTGzqqcdk7ixPDW IKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=XfgVdJF7VbOi0v3H9kN9j23vkXhJd8MzBb8dbiZtCRER7Qr8fxYBjK/vxckWcyQ2m8 PMK6yh2Vcco5ENIbroUTGe3n5ZUdvfpwujj/HhdP2r5ATKDTbfdsp0w2CoAY2GFFz4ap Emb9CSGR0vDpm/0ITqCwgaIyyedxwyDYvPVP9lE4MYuwUn4NuzxQAvu0cG67Z17Xgkod aNsPBggOVmEhA9HgQo/ee84yXPahegfN94VeZiYEwCUwyDYpHsi1XiXDR0JHUJw6k1R3 8Mu/MSiaEKt3iOxUvdJvSBGeIjwdKbN4B6vf4eSDpPjC9/Ko2aWEiN08mdTYE8UzQyBf zbdg== X-Gm-Message-State: AOAM531uMbSwR46bs6QLJfJZ7o+Qm5Rd2ugegFXNLqCRfLTJCEd0YwRN eKauLcyZ3OEweqg3z/gelDE= X-Google-Smtp-Source: ABdhPJwslt4nxz+RxhRYj1bs+nrlsiTP9TyPu0faSLQ6tV7d4GwOgf/ab8jE0Nsc/c/E4gjD42jt7w== X-Received: by 2002:a65:6088:: with SMTP id t8mr1796538pgu.371.1628126397724; Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id g11sm3775073pju.13.2021.08.04.18.19.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Date: Wed, 4 Aug 2021 18:19:51 -0700 From: Tao Ren To: Joel Stanley Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805011951.GA28444@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Tao Ren , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > From: Tao Ren > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > I like to read what kind of platform the BMC is going into if you can > add that detail, but it's not essential. Sure. I will add more details in v2. > > +&spi1 { > > + status = "okay"; > > + > > + /* > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > + * the bus) to save vmalloc space. > > + */ > > + reg = < 0x1e630000 0xc4 > > + 0x30000000 0x2000000 >; > > Which driver supports this? > > It would be great to see Facebook work to get the SPI NOR driver for > the ast2600 merged to mainline. > > I doubt the IBM team will get to this, as we are using eMMC instead. Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought the driver patches were also upstreamed. Let me remove the entry for now, and will add it back when the driver is ready. > > > + > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "spi1.0"; > > + spi-max-frequency = <5000000>; > > + > > + partitions { > > + compatible = "fixed-partitions"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + flash1@0 { > > + reg = <0x0 0x2000000>; > > + label = "system-flash"; > > + }; > > + }; > > + }; > > +}; > > > +&ehci1 { > > + status = "okay"; > > +}; > > Have you verified that USB works with mainline? I've had reports of it > working on 5.8 but it seems to have regressed as of v5.10. It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence"): ehci_handshake() returns error because HCHalted bit EHCI24[12] stays at 1. I have a dirty hack in my tree (ignoring the halt bit) and it "works" on AST2500 and AST2600. Let me send an email to openbmc and aspeed email groups to see if anyone has more context. Meanwhile, should I delete the entry until the fix is ready in driver? > > +&mdio1 { > > + status = "okay"; > > + > > + ethphy3: ethernet-phy@13 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x0d>; > > + }; > > +}; > > + > > +&mac3 { > > + phy-handle = <ðphy3>; > > status = okay? > > You should specify the pinmux too I think, even if the default happens > to work, so that other devices cannot claim the pins. status is set in ast2600 common dtsi, but let me set it here to avoid confusion. Will update pinmux in v2. Thanks. > > Cheers, > > Joel Cheers, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E901FC4338F for ; Thu, 5 Aug 2021 01:21:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9FFB60F58 for ; Thu, 5 Aug 2021 01:21:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A9FFB60F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AkFDhg8nZq0tKh02wuhBaMe2NYUmQZpyM8zSvUZAzEQ=; b=DZCY/sxxBvrLc6 nEoXCO/JtXqyitwrFpG0/XKVNtDFkeBrpGE+xkospK00x+skC6FNWvV+0kI6TqZJFtusayGrgPG9D +xJ/8nzaJuLhgmfnrFAff5aJevN1NN9PpkQPEsZ6InZoyXh3cV848XZd/PoTkTN/Dwje0Jq4CZhMl AamzYz3tqe2L0x5xbIgm8FVoaQgDOh4XTCM/z/WPeQjExmMlxIg7ze2PBjs2eyL/hlmcq+BjQIJCO YXUPSsVQFN2/+jczQDpNUOiYIju9VCw/coxk8FHl/rLs0Jnp8syydeGTzj3tlGNrlBS6gPmKHLFtN hZ4ub2cUnirI2ZyMBx/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBS3G-007nzT-W7; Thu, 05 Aug 2021 01:20:03 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBS3D-007nyw-7G for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 01:20:00 +0000 Received: by mail-pl1-x636.google.com with SMTP id c16so5100897plh.7 for ; Wed, 04 Aug 2021 18:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=czFhfxgAUEDaFdM3Hcun5CUGzve9qBhEHhdgHBmOX7olliuFKN8DXgEe+rmKmWat+L 9mJyEreTCcY9wJOpkumioORcnXgQzD2mgUmfb8cHczaZku6gWfEFHyDULFrbZ1Qkc2Fb w63Puypnh8M8XBOv2KOl5W9ml8QulLssN8QoK10Wjo+2Y386UtpiMhlLjuhbVj4TdOuB pvqKjUhBeZHINJCJM53M/eymo4U+UKhmtE5VcRQ+hQFyt9j6QvVl0xQWmwI7zrDcM1sm tFrqNxnw9BmxW3fhzyQMf8dW7uptS6+uWujOdhQ9442difFXq0vS6iTGzqqcdk7ixPDW IKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=Hf56hGhVymbG34bVooQLtj22t+6w+C4lDSzUvDUJPv92UsrQ9FOzx7mqhk4rS9hZHs VItcQmm9MEA6wjWqUouqEWLAVDs3qlUTk06mLIA3eqmRna6uxg5qjgKCw/vU6eLXwu3v 1D5rp/Tlph+6smTKUTvNMPC6snjqPEwqxAcxszI27Yxl3pMyz5UkU8Z6XMKFpVY6NYuk huijZ8yqJwxbFEFysTjRzZYFDBtAZ6z0eK6QNcoeSyl2wvkduBD24gNorB6g0IFxOUrk S/Nja5+2vt5hwjUtFbpvveXF07I6o877B59525R+pa1IZgrIrGeWsjHjRjiKIcrZTdrj C5Eg== X-Gm-Message-State: AOAM532oGShFOzF+KAo0DY5S55s9eU+yzp6DiDn03G5nBW5ngABTkwQd clYTixmlDdEM/Ga+NjRKdu8= X-Google-Smtp-Source: ABdhPJwslt4nxz+RxhRYj1bs+nrlsiTP9TyPu0faSLQ6tV7d4GwOgf/ab8jE0Nsc/c/E4gjD42jt7w== X-Received: by 2002:a65:6088:: with SMTP id t8mr1796538pgu.371.1628126397724; Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id g11sm3775073pju.13.2021.08.04.18.19.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Date: Wed, 4 Aug 2021 18:19:51 -0700 From: Tao Ren To: Joel Stanley Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805011951.GA28444@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_181959_328278_3D66137D X-CRM114-Status: GOOD ( 30.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > From: Tao Ren > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > I like to read what kind of platform the BMC is going into if you can > add that detail, but it's not essential. Sure. I will add more details in v2. > > +&spi1 { > > + status = "okay"; > > + > > + /* > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > + * the bus) to save vmalloc space. > > + */ > > + reg = < 0x1e630000 0xc4 > > + 0x30000000 0x2000000 >; > > Which driver supports this? > > It would be great to see Facebook work to get the SPI NOR driver for > the ast2600 merged to mainline. > > I doubt the IBM team will get to this, as we are using eMMC instead. Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought the driver patches were also upstreamed. Let me remove the entry for now, and will add it back when the driver is ready. > > > + > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "spi1.0"; > > + spi-max-frequency = <5000000>; > > + > > + partitions { > > + compatible = "fixed-partitions"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + flash1@0 { > > + reg = <0x0 0x2000000>; > > + label = "system-flash"; > > + }; > > + }; > > + }; > > +}; > > > +&ehci1 { > > + status = "okay"; > > +}; > > Have you verified that USB works with mainline? I've had reports of it > working on 5.8 but it seems to have regressed as of v5.10. It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence"): ehci_handshake() returns error because HCHalted bit EHCI24[12] stays at 1. I have a dirty hack in my tree (ignoring the halt bit) and it "works" on AST2500 and AST2600. Let me send an email to openbmc and aspeed email groups to see if anyone has more context. Meanwhile, should I delete the entry until the fix is ready in driver? > > +&mdio1 { > > + status = "okay"; > > + > > + ethphy3: ethernet-phy@13 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x0d>; > > + }; > > +}; > > + > > +&mac3 { > > + phy-handle = <ðphy3>; > > status = okay? > > You should specify the pinmux too I think, even if the default happens > to work, so that other devices cannot claim the pins. status is set in ast2600 common dtsi, but let me set it here to avoid confusion. Will update pinmux in v2. Thanks. > > Cheers, > > Joel Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF82C4338F for ; Thu, 5 Aug 2021 01:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E121D610A8 for ; Thu, 5 Aug 2021 01:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236569AbhHEBUM (ORCPT ); Wed, 4 Aug 2021 21:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbhHEBUM (ORCPT ); Wed, 4 Aug 2021 21:20:12 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 367FEC061765; Wed, 4 Aug 2021 18:19:58 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so11612863pjr.1; Wed, 04 Aug 2021 18:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=czFhfxgAUEDaFdM3Hcun5CUGzve9qBhEHhdgHBmOX7olliuFKN8DXgEe+rmKmWat+L 9mJyEreTCcY9wJOpkumioORcnXgQzD2mgUmfb8cHczaZku6gWfEFHyDULFrbZ1Qkc2Fb w63Puypnh8M8XBOv2KOl5W9ml8QulLssN8QoK10Wjo+2Y386UtpiMhlLjuhbVj4TdOuB pvqKjUhBeZHINJCJM53M/eymo4U+UKhmtE5VcRQ+hQFyt9j6QvVl0xQWmwI7zrDcM1sm tFrqNxnw9BmxW3fhzyQMf8dW7uptS6+uWujOdhQ9442difFXq0vS6iTGzqqcdk7ixPDW IKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e3XwsW9dcpK2inuw4CP3wWTFfrJpkqjKUp1ALe4OcSw=; b=uB/nbMJb/9dFMl2poOLPL9PWZOv/gHibgXOV4n3MA9FOn5DZ8T4Kjk4NoJ4xYJTTq4 pCwAAelo8e6a6RSSEgif3y2JGoVdZGY0FhJ39bVq95stMe3ReorA+uAlVKfZmOTOmWCP 5p0IMGNXCS8zUllcSQll1iA3V/9ZVZOzlSdOhRdO9lf+w2kjqLOYGndpD/y6j3E0tQIb Gy19wSjrmmU0IWsI4+MSn+HjtmQKN3n/d3Hv6v9LAyX31k1J7/EagQSsBjowVZyhfFDk /n2ID7xKHwzoNp144gBQkJKH+o08U0Hja50DbLjgYWcdCPpP2nDNesLiXMVUoMNIpyLs 8zgg== X-Gm-Message-State: AOAM533Rs7h60ybIjkmIOvCoojhjc9JNJ5fRXO1wlBEQf7iytBweiY3h 0cKLWzpFeOWR1bjXsFGtwjc= X-Google-Smtp-Source: ABdhPJwslt4nxz+RxhRYj1bs+nrlsiTP9TyPu0faSLQ6tV7d4GwOgf/ab8jE0Nsc/c/E4gjD42jt7w== X-Received: by 2002:a65:6088:: with SMTP id t8mr1796538pgu.371.1628126397724; Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id g11sm3775073pju.13.2021.08.04.18.19.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 18:19:57 -0700 (PDT) Date: Wed, 4 Aug 2021 18:19:51 -0700 From: Tao Ren To: Joel Stanley Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805011951.GA28444@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > From: Tao Ren > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > I like to read what kind of platform the BMC is going into if you can > add that detail, but it's not essential. Sure. I will add more details in v2. > > +&spi1 { > > + status = "okay"; > > + > > + /* > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > + * the bus) to save vmalloc space. > > + */ > > + reg = < 0x1e630000 0xc4 > > + 0x30000000 0x2000000 >; > > Which driver supports this? > > It would be great to see Facebook work to get the SPI NOR driver for > the ast2600 merged to mainline. > > I doubt the IBM team will get to this, as we are using eMMC instead. Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought the driver patches were also upstreamed. Let me remove the entry for now, and will add it back when the driver is ready. > > > + > > + flash@0 { > > + status = "okay"; > > + m25p,fast-read; > > + label = "spi1.0"; > > + spi-max-frequency = <5000000>; > > + > > + partitions { > > + compatible = "fixed-partitions"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + flash1@0 { > > + reg = <0x0 0x2000000>; > > + label = "system-flash"; > > + }; > > + }; > > + }; > > +}; > > > +&ehci1 { > > + status = "okay"; > > +}; > > Have you verified that USB works with mainline? I've had reports of it > working on 5.8 but it seems to have regressed as of v5.10. It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI host controller initialization sequence"): ehci_handshake() returns error because HCHalted bit EHCI24[12] stays at 1. I have a dirty hack in my tree (ignoring the halt bit) and it "works" on AST2500 and AST2600. Let me send an email to openbmc and aspeed email groups to see if anyone has more context. Meanwhile, should I delete the entry until the fix is ready in driver? > > +&mdio1 { > > + status = "okay"; > > + > > + ethphy3: ethernet-phy@13 { > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x0d>; > > + }; > > +}; > > + > > +&mac3 { > > + phy-handle = <ðphy3>; > > status = okay? > > You should specify the pinmux too I think, even if the default happens > to work, so that other devices cannot claim the pins. status is set in ast2600 common dtsi, but let me set it here to avoid confusion. Will update pinmux in v2. Thanks. > > Cheers, > > Joel Cheers, Tao