From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ren Date: Wed, 4 Aug 2021 19:09:46 -0700 Subject: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC In-Reply-To: References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> Message-ID: <20210805020946.GA29371@taoren-ubuntu-R90MNF91> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Aug 05, 2021 at 01:37:29AM +0000, Joel Stanley wrote: > On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > > > On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > > > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > > > > > From: Tao Ren > > > > > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > > > > > I like to read what kind of platform the BMC is going into if you can > > > add that detail, but it's not essential. > > > > Sure. I will add more details in v2. > > > > > > +&spi1 { > > > > + status = "okay"; > > > > + > > > > + /* > > > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > > > + * the bus) to save vmalloc space. > > > > + */ > > > > + reg = < 0x1e630000 0xc4 > > > > + 0x30000000 0x2000000 >; > > > > > > Which driver supports this? > > > > > > It would be great to see Facebook work to get the SPI NOR driver for > > > the ast2600 merged to mainline. > > > > > > I doubt the IBM team will get to this, as we are using eMMC instead. > > > > Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought > > the driver patches were also upstreamed. Let me remove the entry for now, > > and will add it back when the driver is ready. > > If it helps you, I don't mind it staying in your dts. I would like to > see some effort on the driver though. > > > > > > > > > > + > > > > + flash at 0 { > > > > + status = "okay"; > > > > + m25p,fast-read; > > > > + label = "spi1.0"; > > > > + spi-max-frequency = <5000000>; > > > > + > > > > + partitions { > > > > + compatible = "fixed-partitions"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + > > > > + flash1 at 0 { > > > > + reg = <0x0 0x2000000>; > > > > + label = "system-flash"; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > > > > +&ehci1 { > > > > + status = "okay"; > > > > +}; > > > > > > Have you verified that USB works with mainline? I've had reports of it > > > working on 5.8 but it seems to have regressed as of v5.10. > > > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > > host controller initialization sequence"): ehci_handshake() returns > > error because HCHalted bit EHCI24[12] stays at 1. > > > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > > groups to see if anyone has more context. > > We discovered the same, except in my testing it wasn't actually > "working" on my EVB. I have a A3 EVB on my desk and when plugging in a > USB key nothing happened. We have a non-removable USB device on Fuji (AST2600) BMC and it can be enumerated successfully (after applying the hack). Let me vist the lab and plug a USB key to CMM (AST2500) BMC sometime next week. Will collect results and send out email then. > > > > > Meanwhile, should I delete the entry until the fix is ready in driver? > > Again, leave it in I think. > > > > > > > +&mdio1 { > > > > + status = "okay"; > > > > + > > > > + ethphy3: ethernet-phy at 13 { > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > + reg = <0x0d>; > > > > + }; > > > > +}; > > > > + > > > > +&mac3 { > > > > + phy-handle = <ðphy3>; > > > > > > status = okay? > > > > > > You should specify the pinmux too I think, even if the default happens > > > to work, so that other devices cannot claim the pins. > > > > status is set in ast2600 common dtsi, but let me set it here to avoid > > confusion. Will update pinmux in v2. Thanks. > > Are you looking at mainline? I think it's disabled by default there: > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 Sorry for the confusion, Joel. I mean the device is enabled in "ast2600-facebook-netbmc-common.dtsi" (patch #3 in the series). Do we still need to set status to "okay" explicitly in platform dts (to avoid confusion)? &mac3 { status = "okay"; phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_rgmii4_default>; }; > > > > > > > > > Cheers, > > > > > > Joel > > > > Cheers, > > > > Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74FC2C4338F for ; Thu, 5 Aug 2021 02:10:30 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4B0861078 for ; Thu, 5 Aug 2021 02:10:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4B0861078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GgBsJ171Tz3cT4 for ; Thu, 5 Aug 2021 12:10:28 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=gbxJaA7X; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62c; helo=mail-pl1-x62c.google.com; envelope-from=rentao.bupt@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=gbxJaA7X; dkim-atps=neutral Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GgBrk0ZL5z2ymN; Thu, 5 Aug 2021 12:09:57 +1000 (AEST) Received: by mail-pl1-x62c.google.com with SMTP id u2so5210749plg.10; Wed, 04 Aug 2021 19:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=gbxJaA7XOAhLlxfezEgRXPviamNE+pDtYHJgokLsRio1ffkZgpLGC/k5m/3IU3m/Ed H+HLg7odROgTrh0FHMu1TiqZk8MRW8hSbXzGCUEYiCDhpa4ONExdHFQ9kX8kcaqN7Yg8 m7nzs0LfhCEY88AEcyAPSkqeMugQTdXiXxduBCYTAZinSwQMwz2yynNPZOxJbi9AsDDA 8SCMJj3k/0gBQS0S09Gc00KRHLeAXsIRJWnsEDkx7HvJksUDhxK7lDr1wOnrIk3qshY2 MfLZw59IOhN6AJKTxVixu//fYNODZ9xfOUUMpCqVqvU5ZV+IfST6zjRujaDy75NctJnd msnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=kRRTSgSLD3BDRJulCbuRL8shFKN+GwssKvVoTnKTk8/GloFfTf910jSjjvufTo6JIJ IqqYzTcGposDXSYQcPjAyXbfFocU+TBy/9lgOeyWs00Sur76U5PFyN7tRXH1ZyhceXAy KVzLVXymc/k7P49qOzRTrkQddHSaGD+ekYZdNjYgl1pw5wahpWzXCT68NNCPbOpPEUsE yuZtwxeBGqE8psWVs9oUiQdJ6aKJzwsp46KTNTeUDtiA+HuqVyULoLhogFvyO4eFwzng ouzHnEaEUwF0RpFxil6Q2hZHr+UEI1y7hrQtKXUD5CIo518y/VdjYVGFVOQCVGWYz+u/ oLbA== X-Gm-Message-State: AOAM533kvx+MKvgF3JSlBC2TIfXxzBDfNZAKP4EoirnslbQID25M2Tf3 DLZEZLYH/kCkV85/XCeV7aE= X-Google-Smtp-Source: ABdhPJxs/lH462HevDdQYzdAuskPQJACBS+taPHcjQaHrNLfbXS9sBF86pf7I2q+GX4JSgto84yy7Q== X-Received: by 2002:a62:36c5:0:b029:32b:83fa:3a3e with SMTP id d188-20020a6236c50000b029032b83fa3a3emr2426065pfa.52.1628129393615; Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id a20sm7375508pjh.46.2021.08.04.19.09.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Date: Wed, 4 Aug 2021 19:09:46 -0700 From: Tao Ren To: Joel Stanley Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805020946.GA29371@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Tao Ren , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Aug 05, 2021 at 01:37:29AM +0000, Joel Stanley wrote: > On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > > > On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > > > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > > > > > From: Tao Ren > > > > > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > > > > > I like to read what kind of platform the BMC is going into if you can > > > add that detail, but it's not essential. > > > > Sure. I will add more details in v2. > > > > > > +&spi1 { > > > > + status = "okay"; > > > > + > > > > + /* > > > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > > > + * the bus) to save vmalloc space. > > > > + */ > > > > + reg = < 0x1e630000 0xc4 > > > > + 0x30000000 0x2000000 >; > > > > > > Which driver supports this? > > > > > > It would be great to see Facebook work to get the SPI NOR driver for > > > the ast2600 merged to mainline. > > > > > > I doubt the IBM team will get to this, as we are using eMMC instead. > > > > Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought > > the driver patches were also upstreamed. Let me remove the entry for now, > > and will add it back when the driver is ready. > > If it helps you, I don't mind it staying in your dts. I would like to > see some effort on the driver though. > > > > > > > > > > + > > > > + flash@0 { > > > > + status = "okay"; > > > > + m25p,fast-read; > > > > + label = "spi1.0"; > > > > + spi-max-frequency = <5000000>; > > > > + > > > > + partitions { > > > > + compatible = "fixed-partitions"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + > > > > + flash1@0 { > > > > + reg = <0x0 0x2000000>; > > > > + label = "system-flash"; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > > > > +&ehci1 { > > > > + status = "okay"; > > > > +}; > > > > > > Have you verified that USB works with mainline? I've had reports of it > > > working on 5.8 but it seems to have regressed as of v5.10. > > > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > > host controller initialization sequence"): ehci_handshake() returns > > error because HCHalted bit EHCI24[12] stays at 1. > > > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > > groups to see if anyone has more context. > > We discovered the same, except in my testing it wasn't actually > "working" on my EVB. I have a A3 EVB on my desk and when plugging in a > USB key nothing happened. We have a non-removable USB device on Fuji (AST2600) BMC and it can be enumerated successfully (after applying the hack). Let me vist the lab and plug a USB key to CMM (AST2500) BMC sometime next week. Will collect results and send out email then. > > > > > Meanwhile, should I delete the entry until the fix is ready in driver? > > Again, leave it in I think. > > > > > > > +&mdio1 { > > > > + status = "okay"; > > > > + > > > > + ethphy3: ethernet-phy@13 { > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > + reg = <0x0d>; > > > > + }; > > > > +}; > > > > + > > > > +&mac3 { > > > > + phy-handle = <ðphy3>; > > > > > > status = okay? > > > > > > You should specify the pinmux too I think, even if the default happens > > > to work, so that other devices cannot claim the pins. > > > > status is set in ast2600 common dtsi, but let me set it here to avoid > > confusion. Will update pinmux in v2. Thanks. > > Are you looking at mainline? I think it's disabled by default there: > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 Sorry for the confusion, Joel. I mean the device is enabled in "ast2600-facebook-netbmc-common.dtsi" (patch #3 in the series). Do we still need to set status to "okay" explicitly in platform dts (to avoid confusion)? &mac3 { status = "okay"; phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_rgmii4_default>; }; > > > > > > > > > Cheers, > > > > > > Joel > > > > Cheers, > > > > Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30465C4338F for ; Thu, 5 Aug 2021 02:11:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E251061037 for ; Thu, 5 Aug 2021 02:11:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E251061037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z/FM/Oe/mWaC6P0XttEuUNp9ktZlarvFX3r9qvxLzH0=; b=EfS+I80USneyq0 ydxPvj84SY6pBUzA94kGpJGcm5bSMwQHfryrgGsObwiFH2f/9Cyk6dhRXJI/tZfAuzw5Ptfm0Ulzs PGjjBxbOtrx4P2EJLgc26mHLzPP/esFAcE9sEwjEdxZO1AAxN8YKOXNHmAD69Ff2tGB8txchrlMm6 A1tTU0/i5EmD8FRQ85Fuaw84Kr3GITHkPVCVgCMDeL38t9R3NhV67t8yX+U/bDE1MotLEpmUAQL/d uzzr6oJ8EXeWaevmJUD2aLriratXASEXGKE04QLslqhRi08dPSWPrv3SLoyHJCrm8stclpkT+hzHL N8RwyeMdxM8DRH+m/5GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSpb-007rtL-Li; Thu, 05 Aug 2021 02:09:59 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSpW-007rrI-Qt for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 02:09:56 +0000 Received: by mail-pj1-x1036.google.com with SMTP id t7-20020a17090a5d87b029017807007f23so8567256pji.5 for ; Wed, 04 Aug 2021 19:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=gbxJaA7XOAhLlxfezEgRXPviamNE+pDtYHJgokLsRio1ffkZgpLGC/k5m/3IU3m/Ed H+HLg7odROgTrh0FHMu1TiqZk8MRW8hSbXzGCUEYiCDhpa4ONExdHFQ9kX8kcaqN7Yg8 m7nzs0LfhCEY88AEcyAPSkqeMugQTdXiXxduBCYTAZinSwQMwz2yynNPZOxJbi9AsDDA 8SCMJj3k/0gBQS0S09Gc00KRHLeAXsIRJWnsEDkx7HvJksUDhxK7lDr1wOnrIk3qshY2 MfLZw59IOhN6AJKTxVixu//fYNODZ9xfOUUMpCqVqvU5ZV+IfST6zjRujaDy75NctJnd msnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=eus7k22G5rCHTorVKoXID6IaOJT/WylZc0PHboxjdV3OL/aRtZHv+JSeYHtRcUwIMn T1JqvGprRoeWSvm8Nzwio3H35Cs4krNVLoivMm+rBO4oLzI1yjMpjGyMc1O8xKO2MP/V QU+rJvGySO52L66oGll78WCpIMzYjPeRJlYCd+wuNPIAZe+vttz3itQoNmbChKLXtVxw 6gtnygL4P2dXpEuupYWBS8viRmQBAF9oDHaftAQ8b1ZpimmF+TqoaxGi1KJReLilo67v /ls5OR1UhehAlMyAM1P1qu3XObFgrf9TVF4sOJwvczZxnP6liukakoHRlSZy/zbAZAus PimA== X-Gm-Message-State: AOAM5309a37bgUMTqltt7cGMyP5Rd3hAAaxwNlmGvx6JL15tzyqXwUUn xv4iHrnRa4DcM5OZQ8bQQF62MuWdaWupMS31FGo= X-Google-Smtp-Source: ABdhPJxs/lH462HevDdQYzdAuskPQJACBS+taPHcjQaHrNLfbXS9sBF86pf7I2q+GX4JSgto84yy7Q== X-Received: by 2002:a62:36c5:0:b029:32b:83fa:3a3e with SMTP id d188-20020a6236c50000b029032b83fa3a3emr2426065pfa.52.1628129393615; Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id a20sm7375508pjh.46.2021.08.04.19.09.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Date: Wed, 4 Aug 2021 19:09:46 -0700 From: Tao Ren To: Joel Stanley Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805020946.GA29371@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_190954_923811_EC8E1866 X-CRM114-Status: GOOD ( 43.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 05, 2021 at 01:37:29AM +0000, Joel Stanley wrote: > On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > > > On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > > > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > > > > > From: Tao Ren > > > > > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > > > > > I like to read what kind of platform the BMC is going into if you can > > > add that detail, but it's not essential. > > > > Sure. I will add more details in v2. > > > > > > +&spi1 { > > > > + status = "okay"; > > > > + > > > > + /* > > > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > > > + * the bus) to save vmalloc space. > > > > + */ > > > > + reg = < 0x1e630000 0xc4 > > > > + 0x30000000 0x2000000 >; > > > > > > Which driver supports this? > > > > > > It would be great to see Facebook work to get the SPI NOR driver for > > > the ast2600 merged to mainline. > > > > > > I doubt the IBM team will get to this, as we are using eMMC instead. > > > > Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought > > the driver patches were also upstreamed. Let me remove the entry for now, > > and will add it back when the driver is ready. > > If it helps you, I don't mind it staying in your dts. I would like to > see some effort on the driver though. > > > > > > > > > > + > > > > + flash@0 { > > > > + status = "okay"; > > > > + m25p,fast-read; > > > > + label = "spi1.0"; > > > > + spi-max-frequency = <5000000>; > > > > + > > > > + partitions { > > > > + compatible = "fixed-partitions"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + > > > > + flash1@0 { > > > > + reg = <0x0 0x2000000>; > > > > + label = "system-flash"; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > > > > +&ehci1 { > > > > + status = "okay"; > > > > +}; > > > > > > Have you verified that USB works with mainline? I've had reports of it > > > working on 5.8 but it seems to have regressed as of v5.10. > > > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > > host controller initialization sequence"): ehci_handshake() returns > > error because HCHalted bit EHCI24[12] stays at 1. > > > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > > groups to see if anyone has more context. > > We discovered the same, except in my testing it wasn't actually > "working" on my EVB. I have a A3 EVB on my desk and when plugging in a > USB key nothing happened. We have a non-removable USB device on Fuji (AST2600) BMC and it can be enumerated successfully (after applying the hack). Let me vist the lab and plug a USB key to CMM (AST2500) BMC sometime next week. Will collect results and send out email then. > > > > > Meanwhile, should I delete the entry until the fix is ready in driver? > > Again, leave it in I think. > > > > > > > +&mdio1 { > > > > + status = "okay"; > > > > + > > > > + ethphy3: ethernet-phy@13 { > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > + reg = <0x0d>; > > > > + }; > > > > +}; > > > > + > > > > +&mac3 { > > > > + phy-handle = <ðphy3>; > > > > > > status = okay? > > > > > > You should specify the pinmux too I think, even if the default happens > > > to work, so that other devices cannot claim the pins. > > > > status is set in ast2600 common dtsi, but let me set it here to avoid > > confusion. Will update pinmux in v2. Thanks. > > Are you looking at mainline? I think it's disabled by default there: > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 Sorry for the confusion, Joel. I mean the device is enabled in "ast2600-facebook-netbmc-common.dtsi" (patch #3 in the series). Do we still need to set status to "okay" explicitly in platform dts (to avoid confusion)? &mac3 { status = "okay"; phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_rgmii4_default>; }; > > > > > > > > > Cheers, > > > > > > Joel > > > > Cheers, > > > > Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EB4C4338F for ; Thu, 5 Aug 2021 02:09:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A6CB6109F for ; Thu, 5 Aug 2021 02:09:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238197AbhHECKI (ORCPT ); Wed, 4 Aug 2021 22:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232116AbhHECKI (ORCPT ); Wed, 4 Aug 2021 22:10:08 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 390D2C061765; Wed, 4 Aug 2021 19:09:54 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id mz5-20020a17090b3785b0290176ecf64922so11743474pjb.3; Wed, 04 Aug 2021 19:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=gbxJaA7XOAhLlxfezEgRXPviamNE+pDtYHJgokLsRio1ffkZgpLGC/k5m/3IU3m/Ed H+HLg7odROgTrh0FHMu1TiqZk8MRW8hSbXzGCUEYiCDhpa4ONExdHFQ9kX8kcaqN7Yg8 m7nzs0LfhCEY88AEcyAPSkqeMugQTdXiXxduBCYTAZinSwQMwz2yynNPZOxJbi9AsDDA 8SCMJj3k/0gBQS0S09Gc00KRHLeAXsIRJWnsEDkx7HvJksUDhxK7lDr1wOnrIk3qshY2 MfLZw59IOhN6AJKTxVixu//fYNODZ9xfOUUMpCqVqvU5ZV+IfST6zjRujaDy75NctJnd msnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cwuq2KjV5PT9ZJMXdePEjRCatXRYF+kDCB8wvMO+fn0=; b=EUIufoDyrMERKvBC7zA6ZLobiLqajf3SCHw6YZYMHwNuplqML9bUuiKvF2JB51ouEH 5wkK8XHMgE+0UebWiTjr8uGPA1ALEta8p6ztcKQxOsB0XqWUkurqM4mqSyeROhNsAQrZ QakyKNaJFaxlAntJ/praPIRIETQGu3yjiZ01wMCuqrMAccXFFxfhehrj7B0TQnIarVq7 1omUCm3MdM7ApB/E0FhWMX5BGn6RJzB37ZeltJXtcSN7dvErJXn7ilJLGJvDUOGoyORG OjTfskjGEfu8kBPvL+jmKmX22TlVbc3POQ6aer/nVlBbFTq7yV0diW9MBV+v+YSJvb5A mKkw== X-Gm-Message-State: AOAM530N1/teUB1vAZBDaUN4Wt4rTsRhQFVAZMO+mwSmlsjHO6m9YYL0 OPAJQtWeJWr0kfoW1c3qUPs= X-Google-Smtp-Source: ABdhPJxs/lH462HevDdQYzdAuskPQJACBS+taPHcjQaHrNLfbXS9sBF86pf7I2q+GX4JSgto84yy7Q== X-Received: by 2002:a62:36c5:0:b029:32b:83fa:3a3e with SMTP id d188-20020a6236c50000b029032b83fa3a3emr2426065pfa.52.1628129393615; Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id a20sm7375508pjh.46.2021.08.04.19.09.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 19:09:53 -0700 (PDT) Date: Wed, 4 Aug 2021 19:09:46 -0700 From: Tao Ren To: Joel Stanley Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC Message-ID: <20210805020946.GA29371@taoren-ubuntu-R90MNF91> References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 05, 2021 at 01:37:29AM +0000, Joel Stanley wrote: > On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > > > On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > > > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > > > > > From: Tao Ren > > > > > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > > > > > I like to read what kind of platform the BMC is going into if you can > > > add that detail, but it's not essential. > > > > Sure. I will add more details in v2. > > > > > > +&spi1 { > > > > + status = "okay"; > > > > + > > > > + /* > > > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > > > + * the bus) to save vmalloc space. > > > > + */ > > > > + reg = < 0x1e630000 0xc4 > > > > + 0x30000000 0x2000000 >; > > > > > > Which driver supports this? > > > > > > It would be great to see Facebook work to get the SPI NOR driver for > > > the ast2600 merged to mainline. > > > > > > I doubt the IBM team will get to this, as we are using eMMC instead. > > > > Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought > > the driver patches were also upstreamed. Let me remove the entry for now, > > and will add it back when the driver is ready. > > If it helps you, I don't mind it staying in your dts. I would like to > see some effort on the driver though. > > > > > > > > > > + > > > > + flash@0 { > > > > + status = "okay"; > > > > + m25p,fast-read; > > > > + label = "spi1.0"; > > > > + spi-max-frequency = <5000000>; > > > > + > > > > + partitions { > > > > + compatible = "fixed-partitions"; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + > > > > + flash1@0 { > > > > + reg = <0x0 0x2000000>; > > > > + label = "system-flash"; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > > > > +&ehci1 { > > > > + status = "okay"; > > > > +}; > > > > > > Have you verified that USB works with mainline? I've had reports of it > > > working on 5.8 but it seems to have regressed as of v5.10. > > > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > > host controller initialization sequence"): ehci_handshake() returns > > error because HCHalted bit EHCI24[12] stays at 1. > > > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > > groups to see if anyone has more context. > > We discovered the same, except in my testing it wasn't actually > "working" on my EVB. I have a A3 EVB on my desk and when plugging in a > USB key nothing happened. We have a non-removable USB device on Fuji (AST2600) BMC and it can be enumerated successfully (after applying the hack). Let me vist the lab and plug a USB key to CMM (AST2500) BMC sometime next week. Will collect results and send out email then. > > > > > Meanwhile, should I delete the entry until the fix is ready in driver? > > Again, leave it in I think. > > > > > > > +&mdio1 { > > > > + status = "okay"; > > > > + > > > > + ethphy3: ethernet-phy@13 { > > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > > + reg = <0x0d>; > > > > + }; > > > > +}; > > > > + > > > > +&mac3 { > > > > + phy-handle = <ðphy3>; > > > > > > status = okay? > > > > > > You should specify the pinmux too I think, even if the default happens > > > to work, so that other devices cannot claim the pins. > > > > status is set in ast2600 common dtsi, but let me set it here to avoid > > confusion. Will update pinmux in v2. Thanks. > > Are you looking at mainline? I think it's disabled by default there: > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 Sorry for the confusion, Joel. I mean the device is enabled in "ast2600-facebook-netbmc-common.dtsi" (patch #3 in the series). Do we still need to set status to "okay" explicitly in platform dts (to avoid confusion)? &mac3 { status = "okay"; phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_rgmii4_default>; }; > > > > > > > > > Cheers, > > > > > > Joel > > > > Cheers, > > > > Tao