From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBD0C4338F for ; Thu, 5 Aug 2021 09:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 208AE60E53 for ; Thu, 5 Aug 2021 09:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239602AbhHEJRp (ORCPT ); Thu, 5 Aug 2021 05:17:45 -0400 Received: from elvis.franken.de ([193.175.24.41]:46920 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239523AbhHEJRm (ORCPT ); Thu, 5 Aug 2021 05:17:42 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mBZV8-0005ti-03; Thu, 05 Aug 2021 11:17:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D48DCC052F; Thu, 5 Aug 2021 11:12:18 +0200 (CEST) Date: Thu, 5 Aug 2021 11:12:18 +0200 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org, Will Deacon , Palmer Dabbelt , Michael Ellerman , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Message-ID: <20210805091218.GD5979@alpha.franken.de> References: <20210731060020.12913-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > [..] > arch/mips/vdso/Makefile | 2 -- Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466CCC4338F for ; Thu, 5 Aug 2021 09:18:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF47660E53 for ; Thu, 5 Aug 2021 09:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF47660E53 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R5TpN7KJUwiazRJcpoQdFthiJhoYQAZWRleP+kmr1eA=; b=MsDWFFS2EVedaQ ZomppC05h1p2Y5H0kFuj2YiTlR6e+Y3cRPSGAwkt5skr1PSwZDT3OtzU2D5tCkZ0Rwydn41MpuVnn ga9wEbTXMfEaCtxnkVDgdap5HWoj18Cm4Hm9O5Ys5sb6LdUXD3U0VdqiPAGL/kW6WEp0zw4CgvjHD bAEnB29xZFyKc2O8WW6ssfZy3VQ39PUr/0vcozkkyaTQjzVuK/XvBJXlPw9A1m+Dz0kfCjbmd7yON NtIEzTIPWlbyKcobL8pqi1yLlMbycGbcnz39TmslcKCR0V4ty9QXUuTt2hmDmN4j+pcMTyonBzfBe XDOdphxyXYO+XxdzeL+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZVP-008pyh-69; Thu, 05 Aug 2021 09:17:35 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZVL-008pxH-TV; Thu, 05 Aug 2021 09:17:33 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mBZV8-0005ti-03; Thu, 05 Aug 2021 11:17:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D48DCC052F; Thu, 5 Aug 2021 11:12:18 +0200 (CEST) Date: Thu, 5 Aug 2021 11:12:18 +0200 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org, Will Deacon , Palmer Dabbelt , Michael Ellerman , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Message-ID: <20210805091218.GD5979@alpha.franken.de> References: <20210731060020.12913-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_021732_202258_4D194A52 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > [..] > arch/mips/vdso/Makefile | 2 -- Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8796CC4320A for ; Thu, 5 Aug 2021 09:18:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D61C61029 for ; Thu, 5 Aug 2021 09:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D61C61029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GgNLb4TXzz3cWN for ; Thu, 5 Aug 2021 19:17:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=elvis.franken.de (client-ip=193.175.24.41; helo=elvis.franken.de; envelope-from=tsbogend@alpha.franken.de; receiver=) Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lists.ozlabs.org (Postfix) with ESMTP id 4GgNL866smz307n for ; Thu, 5 Aug 2021 19:17:34 +1000 (AEST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mBZV8-0005ti-03; Thu, 05 Aug 2021 11:17:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D48DCC052F; Thu, 5 Aug 2021 11:12:18 +0200 (CEST) Date: Thu, 5 Aug 2021 11:12:18 +0200 From: Thomas Bogendoerfer To: Masahiro Yamada Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Message-ID: <20210805091218.GD5979@alpha.franken.de> References: <20210731060020.12913-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , Russell King , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, Andy Lutomirski , Catalin Marinas , Guo Ren , Thomas Gleixner , Vincenzo Frascino , Will Deacon , linux-riscv@lists.infradead.org, Paul Mackerras Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > [..] > arch/mips/vdso/Makefile | 2 -- Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457E0C432BE for ; Thu, 5 Aug 2021 09:19:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FD9160E53 for ; Thu, 5 Aug 2021 09:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0FD9160E53 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=by60ZqHPrdTjw9SI0pikpqrrgaoAFsA7qQ25+OvVZGw=; b=Ht8IpChqG1+msP k+KQCRpDJicXqZI3WHgQzoFAZ1Hgno0lEWYLHx6VEg0YxPspt2ft7Dw1mZqi6lf0CQP5sWfHXCnHY XhSrYgdiU4Da5ozr1uC2bXzhVcdHWSafdSPXqmmOy2zH+AfwMLjQzip6311s4thBSBmVgMtzs+gTh VjuTBh7QbyaFUM5ZGymAE1jPBHnkQDotKNKmTLhH5k4lxGIiixTYXYVjEK3YoDkGku/MW630SlFNE cdT5tF7fMvIKAhijHqrekBS4AiWLjsT3tlyOZC9j/5xErGuAIiywoM7rJULdgetc9EgECZhIvpYN2 aUpq1Vf5Tw7rN6XVV4Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZVW-008q1Q-Nl; Thu, 05 Aug 2021 09:17:42 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBZVL-008pxH-TV; Thu, 05 Aug 2021 09:17:33 +0000 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mBZV8-0005ti-03; Thu, 05 Aug 2021 11:17:18 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id D48DCC052F; Thu, 5 Aug 2021 11:12:18 +0200 (CEST) Date: Thu, 5 Aug 2021 11:12:18 +0200 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , linux-kernel@vger.kernel.org, Will Deacon , Palmer Dabbelt , Michael Ellerman , Catalin Marinas , Benjamin Herrenschmidt , Guo Ren , linux-mips@vger.kernel.org, Paul Mackerras , linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, Albert Ou , linuxppc-dev@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Paul Walmsley Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y) Message-ID: <20210805091218.GD5979@alpha.franken.de> References: <20210731060020.12913-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210731060020.12913-1-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_021732_202258_4D194A52 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that > condition. So, you can always define CFLAGS_vgettimeofday.o > > Remove all the meaningless conditionals. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: > - Fix csky as well > > [..] > arch/mips/vdso/Makefile | 2 -- Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel