All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [linux-next:master 3894/5318] net/mctp/device.c:133 mctp_dump_addrinfo() error: uninitialized symbol 'idx'.
Date: Thu, 05 Aug 2021 15:31:49 +0800	[thread overview]
Message-ID: <202108051545.DcUtze2W-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4126 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Jeremy Kerr <jk@codeconstruct.com.au>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   2f73937c9aa561e2082839bc1a8efaac75d6e244
commit: 583be982d93479ea3d85091b0fd0b01201ede87d [3894/5318] mctp: Add device handling and netlink interface
:::::: branch date: 14 hours ago
:::::: commit date: 7 days ago
config: nios2-randconfig-m031-20210804 (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
net/mctp/device.c:133 mctp_dump_addrinfo() error: uninitialized symbol 'idx'.

Old smatch warnings:
arch/nios2/include/asm/thread_info.h:71 current_thread_info() error: uninitialized symbol 'sp'.

vim +/idx +133 net/mctp/device.c

583be982d93479 Jeremy Kerr 2021-07-29   93  
583be982d93479 Jeremy Kerr 2021-07-29   94  static int mctp_dump_addrinfo(struct sk_buff *skb, struct netlink_callback *cb)
583be982d93479 Jeremy Kerr 2021-07-29   95  {
583be982d93479 Jeremy Kerr 2021-07-29   96  	struct mctp_dump_cb *mcb = (void *)cb->ctx;
583be982d93479 Jeremy Kerr 2021-07-29   97  	struct net *net = sock_net(skb->sk);
583be982d93479 Jeremy Kerr 2021-07-29   98  	struct hlist_head *head;
583be982d93479 Jeremy Kerr 2021-07-29   99  	struct net_device *dev;
583be982d93479 Jeremy Kerr 2021-07-29  100  	struct ifaddrmsg *hdr;
583be982d93479 Jeremy Kerr 2021-07-29  101  	struct mctp_dev *mdev;
583be982d93479 Jeremy Kerr 2021-07-29  102  	int ifindex;
583be982d93479 Jeremy Kerr 2021-07-29  103  	int idx, rc;
583be982d93479 Jeremy Kerr 2021-07-29  104  
583be982d93479 Jeremy Kerr 2021-07-29  105  	hdr = nlmsg_data(cb->nlh);
583be982d93479 Jeremy Kerr 2021-07-29  106  	// filter by ifindex if requested
583be982d93479 Jeremy Kerr 2021-07-29  107  	ifindex = hdr->ifa_index;
583be982d93479 Jeremy Kerr 2021-07-29  108  
583be982d93479 Jeremy Kerr 2021-07-29  109  	rcu_read_lock();
583be982d93479 Jeremy Kerr 2021-07-29  110  	for (; mcb->h < NETDEV_HASHENTRIES; mcb->h++, mcb->idx = 0) {
583be982d93479 Jeremy Kerr 2021-07-29  111  		idx = 0;
583be982d93479 Jeremy Kerr 2021-07-29  112  		head = &net->dev_index_head[mcb->h];
583be982d93479 Jeremy Kerr 2021-07-29  113  		hlist_for_each_entry_rcu(dev, head, index_hlist) {
583be982d93479 Jeremy Kerr 2021-07-29  114  			if (idx >= mcb->idx &&
583be982d93479 Jeremy Kerr 2021-07-29  115  			    (ifindex == 0 || ifindex == dev->ifindex)) {
583be982d93479 Jeremy Kerr 2021-07-29  116  				mdev = __mctp_dev_get(dev);
583be982d93479 Jeremy Kerr 2021-07-29  117  				if (mdev) {
583be982d93479 Jeremy Kerr 2021-07-29  118  					rc = mctp_dump_dev_addrinfo(mdev,
583be982d93479 Jeremy Kerr 2021-07-29  119  								    skb, cb);
583be982d93479 Jeremy Kerr 2021-07-29  120  					// Error indicates full buffer, this
583be982d93479 Jeremy Kerr 2021-07-29  121  					// callback will get retried.
583be982d93479 Jeremy Kerr 2021-07-29  122  					if (rc < 0)
583be982d93479 Jeremy Kerr 2021-07-29  123  						goto out;
583be982d93479 Jeremy Kerr 2021-07-29  124  				}
583be982d93479 Jeremy Kerr 2021-07-29  125  			}
583be982d93479 Jeremy Kerr 2021-07-29  126  			idx++;
583be982d93479 Jeremy Kerr 2021-07-29  127  			// reset for next iteration
583be982d93479 Jeremy Kerr 2021-07-29  128  			mcb->a_idx = 0;
583be982d93479 Jeremy Kerr 2021-07-29  129  		}
583be982d93479 Jeremy Kerr 2021-07-29  130  	}
583be982d93479 Jeremy Kerr 2021-07-29  131  out:
583be982d93479 Jeremy Kerr 2021-07-29  132  	rcu_read_unlock();
583be982d93479 Jeremy Kerr 2021-07-29 @133  	mcb->idx = idx;
583be982d93479 Jeremy Kerr 2021-07-29  134  
583be982d93479 Jeremy Kerr 2021-07-29  135  	return skb->len;
583be982d93479 Jeremy Kerr 2021-07-29  136  }
583be982d93479 Jeremy Kerr 2021-07-29  137  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32193 bytes --]

                 reply	other threads:[~2021-08-05  7:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108051545.DcUtze2W-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.