From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/net/wireless/mediatek/mt76/sdio.c:67 mt76s_alloc_tx() warn: passing a valid pointer to 'PTR_ERR'
Date: Fri, 06 Aug 2021 04:41:41 +0800 [thread overview]
Message-ID: <202108060436.JmSHWiIS-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2768 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Lorenzo Bianconi <lorenzo@kernel.org>
CC: Felix Fietkau <nbd@nbd.name>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 251a1524293d0a90c4d5060f65f42a3016280049
commit: a2a93548db88b73f5781f4c3df3c757656d50c67 mt76: sdio: introduce mt76s_alloc_tx_queue
date: 8 months ago
:::::: branch date: 25 hours ago
:::::: commit date: 8 months ago
config: i386-randconfig-m021-20210804 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/mediatek/mt76/sdio.c:67 mt76s_alloc_tx() warn: passing a valid pointer to 'PTR_ERR'
Old smatch warnings:
drivers/net/wireless/mediatek/mt76/sdio.c:75 mt76s_alloc_tx() warn: passing a valid pointer to 'PTR_ERR'
vim +/PTR_ERR +67 drivers/net/wireless/mediatek/mt76/sdio.c
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 58
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 59 static int mt76s_alloc_tx(struct mt76_dev *dev)
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 60 {
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 61 struct mt76_queue *q;
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 62 int i;
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 63
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 64 for (i = 0; i <= MT_TXQ_PSD; i++) {
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 65 q = mt76s_alloc_tx_queue(dev);
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 66 if (IS_ERR(q))
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 @67 return PTR_ERR(q);
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 68
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 69 q->qid = i;
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 70 dev->q_tx[i] = q;
d39b52e31aa641 Sean Wang 2020-07-15 71 }
d39b52e31aa641 Sean Wang 2020-07-15 72
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 73 q = mt76s_alloc_tx_queue(dev);
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 74 if (IS_ERR(q))
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 75 return PTR_ERR(q);
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 76
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 77 q->qid = MT_TXQ_MCU;
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 78 dev->q_tx[MT_TXQ_MCU] = q;
a2a93548db88b7 Lorenzo Bianconi 2020-11-11 79
d39b52e31aa641 Sean Wang 2020-07-15 80 return 0;
d39b52e31aa641 Sean Wang 2020-07-15 81 }
d39b52e31aa641 Sean Wang 2020-07-15 82
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36418 bytes --]
next reply other threads:[~2021-08-05 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 20:41 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-19 12:38 drivers/net/wireless/mediatek/mt76/sdio.c:67 mt76s_alloc_tx() warn: passing a valid pointer to 'PTR_ERR' kernel test robot
2021-07-01 8:38 kernel test robot
2021-03-08 14:20 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108060436.JmSHWiIS-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.