From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Mehmet Sami Tok <mehmetsamitok@gmail.com>
Cc: Peter Seiderer <ps.report@gmx.net>,
Julien Corjon <corjon.j@ecagroup.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt5: remove optimize by default on debug builds made with qmake
Date: Fri, 6 Aug 2021 14:47:57 +0200 [thread overview]
Message-ID: <20210806144757.2f194d57@windsurf> (raw)
In-Reply-To: <CAPsw1ZrjE45daCMAZB+eMpm9q4tz9G=O6ep_g2Gc4uSJd_oh9g@mail.gmail.com>
Hello Mehmet,
On Fri, 6 Aug 2021 14:39:07 +0300
Mehmet Sami Tok <mehmetsamitok@gmail.com> wrote:
> Thanks for the response. This is an old patch and I don't know if the
> problem is still there. But the main point of this patch was not changing
> flags of Qt package build.
> When you want to use gcc toolchain and qmake generated by buildroot, It was
> affecting your application builds. These flags directly passed to qt
> toolchain and even if you want to build a debug build of any application,
> it is built with -o2. So the problem is not occuring when root file system
> is created, it appears when you want to build something else with toolchain
> generated by buildroot.
I see. Indeed in this case we might consider that we should obey to the
particular flags you specify rather than the ones from the Buildroot
configuration.
However, unless I misread your patch, it removed optimization flags
even for qmake packages built within Buildroot, which is not what we
want.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-06 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 12:32 [Buildroot] [PATCH 0/1] remove optimize by default while using qmake Mehmet Sami Tok
2020-01-07 12:32 ` [Buildroot] [PATCH 1/1] package/qt5: remove optimize by default on debug builds made with qmake Mehmet Sami Tok
2021-08-05 20:03 ` Thomas Petazzoni
2021-08-06 11:39 ` Mehmet Sami Tok
2021-08-06 12:47 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806144757.2f194d57@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=mehmetsamitok@gmail.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.