Re: [Buildroot] [PATCH 1/1] package/ffmpeg: add -latomic to libavformat.pc

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fabrice, All,

On 2021-08-07 17:01 +0200, Fabrice Fontaine spake thusly:
> Le sam. 7 août 2021 à 11:50, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2021-08-06 16:36 +0200, Fabrice Fontaine spake thusly:
> > > -latomic was added to extralibs to fix static build of ffmpeg in commit
> > > fc8798197b57488a852e2c14b4677b5eb0114a0b. However, extralibs is not
> > > added to libavformat.pc resulting in the following static build failure
[--SNIP--]
> > > So add a patch to add extralibs (and so -latomic) to libavformat.pc
[--SNIP--]
> > > +diff --git a/configure b/configure
> > > +index 0bb3a7cf2b..cb366c3ba6 100755
> > > +--- a/configure
> > > ++++ b/configure
> > > +@@ -7604,7 +7604,7 @@ LIBPREF=${LIBPREF}
> > > + LIBSUF=${LIBSUF}
> > > + extralibs_avutil="$avutil_extralibs"
> > > + extralibs_avcodec="$avcodec_extralibs"
> > > +-extralibs_avformat="$avformat_extralibs"
> > > ++extralibs_avformat="$avformat_extralibs $extralibs"
> > > + extralibs_avdevice="$avdevice_extralibs"
> > > + extralibs_avfilter="$avfilter_extralibs"
> > > + extralibs_avresample="$avresample_extralibs"
> >
> > Shouldn't we also add $extralibs to all, instead of just avformat?
> I don't know if all ffmpeg libraries depend on libatomic so I only
> updated avformat as it is enough to fix the build failure but I can
> update all of them if you think it's better.

Thing is, $extralibs is used in the link of all ffmpeg libraries, so it
would make sense it is also added to all the per-library extralibs.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot