From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Jared Bents <jared.bents@rockwellcollins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11
Date: Sun, 8 Aug 2021 23:12:33 +0200 [thread overview]
Message-ID: <20210808231233.615ba5a1@windsurf> (raw)
In-Reply-To: <20210807162742.490256-1-fontaine.fabrice@gmail.com>
On Sat, 7 Aug 2021 18:27:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> libvirt unconditionally uses HWCAP_CPUID on arm which is only available
> since kernel 4.11 and
> https://github.com/torvalds/linux/commit/77c97b4ee21290f5f083173d957843b615abbff2
> resulting in the following build failure since the addition of the
> packahe in commit ccfc90e1010e42e6529afae3a5ea8bf7226dabc1:
>
> ../src/cpu/cpu_arm.c: In function 'virCPUarmCpuDataFromRegs':
> ../src/cpu/cpu_arm.c:562:20: error: 'HWCAP_CPUID' undeclared (first use in this function); did you mean 'HWCAP_PMULL'?
> if (!(hwcaps & HWCAP_CPUID)) {
> ^~~~~~~~~~~
> HWCAP_PMULL
>
> Fixes:
> - http://autobuild.buildroot.org/results/85bf7b4dad73a748bf439e63874eb64d9a53088f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libvirt/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 2f191882cc..e231511906 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -1,6 +1,6 @@
> config BR2_PACKAGE_LIBVIRT_ARCH_SUPPORTS
> bool
> - default y if BR2_aarch64
> + default y if BR2_aarch64 && BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11
What bothers me is that for kernel headers dependencies, we normally
have a comment. Is it worth it in this case? Perhaps not.
Yann, Arnout, Peter?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-08 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 16:27 [Buildroot] [PATCH 1/1] package/libvirt: aarch64 needs headers >= 4.11 Fabrice Fontaine
2021-08-08 21:12 ` Thomas Petazzoni [this message]
2021-08-19 21:42 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808231233.615ba5a1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=jared.bents@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.