From: Dan Carpenter <dan.carpenter@oracle.com>
To: Michael Straube <straube.linux@gmail.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_p2p.c
Date: Mon, 9 Aug 2021 17:57:23 +0300 [thread overview]
Message-ID: <20210809145722.GS1931@kadam> (raw)
In-Reply-To: <20210807101119.16085-8-straube.linux@gmail.com>
On Sat, Aug 07, 2021 at 12:11:09PM +0200, Michael Straube wrote:
> @@ -155,10 +155,10 @@ static void issue_group_disc_req(struct wifidirect_info *pwdinfo, u8 *da)
> pattrib->pktlen = sizeof(struct rtw_ieee80211_hdr_3addr);
>
> /* Build P2P action frame header */
> - pframe = rtw_set_fixed_ie(pframe, 1, &(category), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &(pattrib->pktlen));
> - pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &(pattrib->pktlen));
> + pframe = rtw_set_fixed_ie(pframe, 1, &(category), &pattrib->pktlen);
> + pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&(p2poui), &pattrib->pktlen);
> + pframe = rtw_set_fixed_ie(pframe, 1, &(oui_subtype), &pattrib->pktlen);
> + pframe = rtw_set_fixed_ie(pframe, 1, &(dialogToken), &pattrib->pktlen);
Same thing as the earlier patch. Only the fourth parameter is fixed and
not the others.
regards,
dan carpenter
next prev parent reply other threads:[~2021-08-09 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 10:11 [PATCH 00/17] staging: r8188eu: remove unnecessary parentheses Michael Straube
2021-08-07 10:11 ` [PATCH 01/17] staging: r8188eu: remove unnecessary parentheses in os_dep dir Michael Straube
2021-08-07 10:11 ` [PATCH 02/17] staging: r8188eu: remove unnecessary parentheses in hal dir Michael Straube
2021-08-07 10:11 ` [PATCH 03/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme_ext.c Michael Straube
2021-08-09 14:55 ` Dan Carpenter
2021-08-07 10:11 ` [PATCH 04/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_ap.c Michael Straube
2021-08-07 10:11 ` [PATCH 05/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_wlan_util.c Michael Straube
2021-08-07 10:11 ` [PATCH 06/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_led.c Michael Straube
2021-08-07 10:11 ` [PATCH 07/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_p2p.c Michael Straube
2021-08-09 14:57 ` Dan Carpenter [this message]
2021-08-07 10:11 ` [PATCH 08/17] staging: r8188eu: clean up comparsions to true/false Michael Straube
2021-08-07 10:11 ` [PATCH 09/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_mlme.c Michael Straube
2021-08-07 10:11 ` [PATCH 10/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_xmit.c Michael Straube
2021-08-07 10:11 ` [PATCH 11/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_sta_mgt.c Michael Straube
2021-08-07 10:11 ` [PATCH 12/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_recv.c Michael Straube
2021-08-07 10:11 ` [PATCH 13/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_pwrctrl.c Michael Straube
2021-08-07 10:11 ` [PATCH 14/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_io.c Michael Straube
2021-08-07 10:11 ` [PATCH 15/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_ioctl_set.c Michael Straube
2021-08-07 10:11 ` [PATCH 16/17] staging: r8188eu: remove unnecessary parentheses in core/rtw_cmd.c Michael Straube
2021-08-07 10:11 ` [PATCH 17/17] staging: r8188eu: remove remaining unnecessary parentheses in core dir Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809145722.GS1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.