Re: [RFC PATCH 16/20] jfs: Do not use broken utf8 NLS table for iocharset=utf8 mount option

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3342 bytes --]

Hi "Pali,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on cifs/for-next]
[also build test WARNING on shaggy/jfs-next linus/master v5.14-rc5 next-20210809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pali-Roh-r/fs-Remove-usage-of-broken-nls_utf8-and-drop-it/20210809-002825
base:   git://git.samba.org/sfrench/cifs-2.6.git for-next
config: i386-randconfig-s031-20210809 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/fb17de54426f1b09f419d677cb3d8aa079825dd5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pali-Roh-r/fs-Remove-usage-of-broken-nls_utf8-and-drop-it/20210809-002825
        git checkout fb17de54426f1b09f419d677cb3d8aa079825dd5
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> fs/jfs/jfs_unicode.c:50:42: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short const [usertype] *pwcs @@     got restricted __le16 const [usertype] *from @@
   fs/jfs/jfs_unicode.c:50:42: sparse:     expected unsigned short const [usertype] *pwcs
   fs/jfs/jfs_unicode.c:50:42: sparse:     got restricted __le16 const [usertype] *from

vim +50 fs/jfs/jfs_unicode.c

    12	
    13	/*
    14	 * NAME:	jfs_strfromUCS()
    15	 *
    16	 * FUNCTION:	Convert little-endian unicode string to character string
    17	 *
    18	 */
    19	int jfs_strfromUCS_le(char *to, int maxlen, const __le16 * from,
    20			      int len, struct nls_table *codepage)
    21	{
    22		int i;
    23		int outlen = 0;
    24		static int warn_again = 5;	/* Only warn up to 5 times total */
    25		int warn = !!warn_again;	/* once per string */
    26	
    27		if (codepage) {
    28			for (i = 0; (i < len) && from[i] && outlen < maxlen-1; i++) {
    29				int charlen;
    30				charlen =
    31				    codepage->uni2char(le16_to_cpu(from[i]),
    32						       &to[outlen],
    33						       maxlen-1-outlen);
    34				if (charlen > 0)
    35					outlen += charlen;
    36				else {
    37					to[outlen++] = '?';
    38					if (unlikely(warn)) {
    39						warn--;
    40						warn_again--;
    41						printk(KERN_ERR
    42				"non-latin1 character 0x%x found in JFS file name\n",
    43						       le16_to_cpu(from[i]));
    44						printk(KERN_ERR
    45					"mount with iocharset=utf8 to access\n");
    46					}
    47				}
    48			}
    49		} else {
  > 50			outlen = utf16s_to_utf8s(from, len,
    51						 UTF16_LITTLE_ENDIAN, to, maxlen-1);
    52		}
    53		to[outlen] = 0;
    54		return outlen;
    55	}
    56	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42366 bytes --]