From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>,
linux-block@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 4/5] block: move the bdi from the request_queue to the gendisk
Date: Tue, 10 Aug 2021 18:44:07 +0200 [thread overview]
Message-ID: <20210810164407.GA20662@lst.de> (raw)
In-Reply-To: <20210809154728.GH30319@quack2.suse.cz>
On Mon, Aug 09, 2021 at 05:47:28PM +0200, Jan Kara wrote:
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 2c4ac51e54eb..d2725f94491d 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -525,7 +525,7 @@ void blk_mq_free_request(struct request *rq)
> > __blk_mq_dec_active_requests(hctx);
> >
> > if (unlikely(laptop_mode && !blk_rq_is_passthrough(rq)))
> > - laptop_io_completion(q->backing_dev_info);
> > + laptop_io_completion(queue_to_disk(q)->bdi);
> >
>
> E.g. cannot this get called for a queue that is without a disk?
As Jens already explained we need the gendisk for non-passthrough
commands. Same for the wbt case.
next prev parent reply other threads:[~2021-08-10 16:44 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:17 move the bdi from the request_queue to the gendisk Christoph Hellwig
2021-08-09 14:17 ` [PATCH 1/5] mm: hide laptop_mode_wb_timer entirely behind the BDI API Christoph Hellwig
2021-08-09 14:17 ` Christoph Hellwig
2021-08-09 14:33 ` Johannes Thumshirn
2021-08-09 14:33 ` Johannes Thumshirn
[not found] ` <20210809141744.1203023-2-hch-jcswGhMUV9g@public.gmane.org>
2021-08-09 15:10 ` Jan Kara
2021-08-09 15:10 ` Jan Kara
2021-08-10 21:56 ` Guenter Roeck
2021-08-10 21:56 ` Guenter Roeck
2021-08-11 5:22 ` Christoph Hellwig
2021-08-11 5:22 ` Christoph Hellwig
2021-08-09 14:17 ` [PATCH 4/5] block: move the bdi from the request_queue to the gendisk Christoph Hellwig
2021-08-09 14:38 ` Johannes Thumshirn
2021-08-09 14:38 ` Johannes Thumshirn
2021-08-09 15:47 ` Jan Kara
[not found] ` <20210809154728.GH30319-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2021-08-09 17:57 ` Jens Axboe
2021-08-09 17:57 ` Jens Axboe
2021-08-09 21:29 ` Jan Kara
2021-08-10 16:44 ` Christoph Hellwig [this message]
2021-10-14 14:31 ` [sparc64] kernel OOPS (was: [PATCH 4/5] block: move the bdi from the request_queue to the gendisk) Anatoly Pugachev
[not found] ` <20211014143123.GA22126-DK4qA7C3Vp/Dd9xlW2Tctw@public.gmane.org>
2021-10-14 14:32 ` Christoph Hellwig
2021-10-14 14:32 ` Christoph Hellwig
2021-10-14 20:27 ` Anatoly Pugachev
[not found] ` <20210809141744.1203023-1-hch-jcswGhMUV9g@public.gmane.org>
2021-08-09 14:17 ` [PATCH 2/5] block: pass a gendisk to blk_queue_update_readahead Christoph Hellwig
2021-08-09 14:17 ` Christoph Hellwig
2021-08-09 14:35 ` Johannes Thumshirn
2021-08-09 15:17 ` Jan Kara
2021-08-09 14:17 ` [PATCH 3/5] block: add a queue_has_disk helper Christoph Hellwig
2021-08-09 14:17 ` Christoph Hellwig
2021-08-09 14:37 ` Johannes Thumshirn
2021-08-09 15:18 ` Jan Kara
2021-08-09 14:17 ` [PATCH 5/5] block: remove the bd_bdi in struct block_device Christoph Hellwig
2021-08-09 14:17 ` Christoph Hellwig
2021-08-09 14:55 ` Johannes Thumshirn
2021-08-09 15:49 ` Jan Kara
2021-08-09 21:42 ` move the bdi from the request_queue to the gendisk Jens Axboe
2021-08-09 21:42 ` Jens Axboe
2021-08-10 19:36 ` Qian Cai
2021-08-10 19:36 ` Qian Cai
[not found] ` <e5e19d15-7efd-31f4-941a-a5eb2f94b898-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org>
2021-08-10 20:02 ` Christoph Hellwig
2021-08-10 20:02 ` Christoph Hellwig
[not found] ` <20210810200256.GA30809-jcswGhMUV9g@public.gmane.org>
2021-08-11 2:28 ` Qian Cai
2021-08-11 2:28 ` Qian Cai
2021-08-11 11:25 ` Jan Kara
[not found] ` <20210811112514.GC14725-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2021-08-11 11:51 ` Christoph Hellwig
2021-08-11 11:51 ` Christoph Hellwig
2021-08-11 12:47 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810164407.GA20662@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.