All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Widawsky, Ben" <ben.widawsky@intel.com>
Subject: Re: [bug report] Merge branch 'akpm-current/current'
Date: Wed, 11 Aug 2021 16:13:53 +0800	[thread overview]
Message-ID: <20210811081353.GA84640@shbuild999.sh.intel.com> (raw)
In-Reply-To: <20210811080600.GA15247@kili>

Hi Dan,

On Wed, Aug 11, 2021 at 04:06:00PM +0800, Dan Carpenter wrote:
> [ I do a git show 2db9f815409f and it doesn't show that hugetlb.c was
>   modified but it the git log the merge commit is listed.  I don't
>   know git well enough to explain it.  But I think this was a merge
>   issue.  - dan ]
> 
> Hello Stephen Rothwell,
> 
> The patch 2db9f815409f: "Merge branch 'akpm-current/current'" from
> Aug 10, 2021, leads to the following
> Smatch static checker warning:
> 
> 	mm/hugetlb.c:2172 alloc_buddy_huge_page_with_mpol()
> 	error: uninitialized symbol 'page'.
> 
> mm/hugetlb.c
>     2151 static
>     2152 struct page *alloc_buddy_huge_page_with_mpol(struct hstate *h,
>     2153 		struct vm_area_struct *vma, unsigned long addr)
>     2154 {
>     2155 	struct page *page;
> 
> This should be "struct page *page = NULL;"

Thanks for the report! This was also reported by Nathan Chancellor,
who gave a quick fix: https://lore.kernel.org/lkml/20210810200632.3812797-1-nathan@kernel.org/
and Andrew has taken it to the -mm tree.

Sorry for the inconvenience.

- Feng


      reply	other threads:[~2021-08-11  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11  8:06 [bug report] Merge branch 'akpm-current/current' Dan Carpenter
2021-08-11  8:13 ` Feng Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210811081353.GA84640@shbuild999.sh.intel.com \
    --to=feng.tang@intel.com \
    --cc=ben.widawsky@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.