From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: michael.chan@broadcom.com, huangjw@broadcom.com,
eddie.wai@broadcom.com, prashant@broadcom.com,
gospo@broadcom.com, netdev@vger.kernel.org,
edwin.peer@broadcom.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net 4/4] bnxt: count Tx drops
Date: Wed, 11 Aug 2021 12:32:39 -0700 [thread overview]
Message-ID: <20210811193239.3155396-5-kuba@kernel.org> (raw)
In-Reply-To: <20210811193239.3155396-1-kuba@kernel.org>
Drivers should count packets they are dropping.
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b80ed556c28b..d5049e714c94 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -393,6 +393,7 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
i = skb_get_queue_mapping(skb);
if (unlikely(i >= bp->tx_nr_rings)) {
dev_kfree_skb_any(skb);
+ atomic_long_inc(&dev->tx_dropped);
return NETDEV_TX_OK;
}
@@ -673,6 +674,7 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
tx_buf->skb = NULL;
if (txr->kick_pending)
bnxt_txr_db_kick(bp, txr, prod);
+ atomic_long_inc(&dev->tx_dropped);
return NETDEV_TX_OK;
}
--
2.31.1
prev parent reply other threads:[~2021-08-11 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 19:32 [PATCH net 0/4] bnxt: Tx NAPI disabling resiliency improvements Jakub Kicinski
2021-08-11 19:32 ` [PATCH net 1/4] bnxt: don't lock the tx queue from napi poll Jakub Kicinski
2021-08-11 20:13 ` Edwin Peer
2021-08-11 20:42 ` Michael Chan
2021-08-11 21:09 ` Jakub Kicinski
2021-08-11 19:32 ` [PATCH net 2/4] bnxt: disable napi before cancelling DIM Jakub Kicinski
2021-08-11 19:32 ` [PATCH net 3/4] bnxt: make sure xmit_more + errors does not miss doorbells Jakub Kicinski
2021-08-11 21:12 ` Michael Chan
2021-08-11 19:32 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811193239.3155396-5-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=eddie.wai@broadcom.com \
--cc=edwin.peer@broadcom.com \
--cc=gospo@broadcom.com \
--cc=huangjw@broadcom.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.