Re: [PATCH v2 1/1] iio: ltc2983: fix device probe

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Thu, 12 Aug 2021 06:54:13 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Wednesday, August 11, 2021 6:15 PM
> > To: Sa, Nuno <Nuno.Sa@analog.com>
> > Cc: linux-iio <linux-iio@vger.kernel.org>; Jonathan Cameron
> > <jic23@kernel.org>; Lars-Peter Clausen <lars@metafoo.de>; Drew
> > Fustini <drew@pdp7.com>
> > Subject: Re: [PATCH v2 1/1] iio: ltc2983: fix device probe
> > 
> > [External]
> > 
> > On Wed, Aug 11, 2021 at 4:32 PM Nuno Sá <nuno.sa@analog.com>
> > wrote:
> > 
> > Thanks for an update, my comments below.
> > Depending on Jonathan's wishes it may or may not require a v3.
> > If you address the minor issues I commented on, take mine
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> >   
> 
> Thanks for reviewing... Yeah, I will wait for Jonathan's feedback before
> sending a v3. It might be that he can apply your inputs when applying
> the patch.

Patch looks sensible. I can make the tweaks whilst applying when I
happen to be on the right computer.

Having glanced at the datasheet, I wonder if you ever had the
reset pin wired up (and perhaps decided to drop that
complexity later)?  The driver rather oddly
include of_gpio.h and has no gpio accesses which makes me
wonder ;)

Jonathan

> 
> Thanks!
> - Nuno Sá