From: Andre Przywara <andre.przywara@arm.com>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, "Jagan Teki" <jagan@amarulasolutions.com>,
"Jernej Škrabec" <jernej.skrabec@gmail.com>
Subject: Re: U-Boot sunxi DM_I2C migration?
Date: Thu, 12 Aug 2021 22:22:07 +0100 [thread overview]
Message-ID: <20210812222207.02126e3c@slackpad.fritz.box> (raw)
In-Reply-To: <20210812174930.GZ858@bill-the-cat>
On Thu, 12 Aug 2021 13:49:30 -0400
Tom Rini <trini@konsulko.com> wrote:
Hi Tom,
> As I try and migrate more CONFIG symbols to be Kconfig only, I see that
> sunxi is still using the legacy I2C drivers. Is there something
> specific holding up migration? Thanks!
Do you mean a DM_I2C conversion, or just moving those base address
symbols to Kconfig? The latter is rather easy, let me know if I should
give it a shot.
For DM_I2C, it's the usual sunxi issue: we are using both: DM_I2C and
DT based probing for U-Boot proper, and hardcoded CONFIG_ symbols for
the SPL. *Some* boards need the set up the PMIC early (for increasing
the CPU frequency or setting the proper DRAM voltage), so this needs to
be done in the SPL. I don't know how to fix this "properly",
but introducing DM (and DT) into the SPL is surely not worth the
trouble. Alternatively we could have a separate, cut-down SPL-only
driver, like we have for SPI (arch/arm/mach-sunxi/spl_spi_sunxi.c),
but not sure that's really better.
If there is something in particular that annoys you about the
situation, we could try to improve this particular issue instead?
Moving the non-DM code into a separate file, maybe?
Cheers,
Andre
next prev parent reply other threads:[~2021-08-12 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 17:49 U-Boot sunxi DM_I2C migration? Tom Rini
2021-08-12 21:22 ` Andre Przywara [this message]
2021-08-12 21:40 ` Tom Rini
2021-08-17 19:23 ` Tom Rini
2021-08-18 5:20 ` Samuel Holland
2021-08-18 13:31 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812222207.02126e3c@slackpad.fritz.box \
--to=andre.przywara@arm.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.