From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH android-common] ANDROID: dma-buf: system_heap: freelist_waitqueue can be static
Date: Fri, 13 Aug 2021 06:24:35 +0800 [thread overview]
Message-ID: <20210812222435.GA31038@80bb7eebdec3> (raw)
In-Reply-To: <202108130639.75aQNjfh-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
drivers/dma-buf/heaps/deferred-free-helper.c:23:19: warning: symbol 'freelist_waitqueue' was not declared. Should it be static?
drivers/dma-buf/heaps/deferred-free-helper.c:24:20: warning: symbol 'freelist_task' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
deferred-free-helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/heaps/deferred-free-helper.c b/drivers/dma-buf/heaps/deferred-free-helper.c
index dd09c4b1271cf..fb54d28c917b6 100644
--- a/drivers/dma-buf/heaps/deferred-free-helper.c
+++ b/drivers/dma-buf/heaps/deferred-free-helper.c
@@ -20,8 +20,8 @@
static LIST_HEAD(free_list);
static size_t list_nr_pages;
-wait_queue_head_t freelist_waitqueue;
-struct task_struct *freelist_task;
+static wait_queue_head_t freelist_waitqueue;
+static struct task_struct *freelist_task;
static DEFINE_SPINLOCK(free_list_lock);
void deferred_free(struct deferred_freelist_item *item,
prev parent reply other threads:[~2021-08-12 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 22:24 [android-common:android12-5.4 5/9] drivers/dma-buf/heaps/deferred-free-helper.c:23:19: sparse: sparse: symbol 'freelist_waitqueue' was not declared. Should it be static? kernel test robot
2021-08-12 22:24 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812222435.GA31038@80bb7eebdec3 \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.