From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/flatbuffers: fix locale independent on musl
Date: Thu, 12 Aug 2021 23:42:47 +0200 [thread overview]
Message-ID: <20210812234247.3618da82@windsurf> (raw)
In-Reply-To: <20210810120134.3972324-1-fontaine.fabrice@gmail.com>
On Tue, 10 Aug 2021 14:01:34 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix locale indepdendent which is enabled on musl since version 1.11.0
> and
> https://github.com/google/flatbuffers/commit/5f32f948102e65eaeea461b44f3b43f96c7a7a5a
> resulting in the following build failure on snort3 since bump to version
> 3.1.6 in commit e66f2fd310374779d415fa683813cc5f5ccf6be9:
>
> In file included from /tmp/instance-0/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/flatbuffers/flexbuffers.h:24,
> from /tmp/instance-0/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/flatbuffers/idl.h:26,
> from /tmp/instance-0/output-1/build/snort3-3.1.6.0/src/network_inspectors/perf_monitor/fbs_formatter.cc:29:
> /tmp/instance-0/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/flatbuffers/util.h: In function 'void flatbuffers::strtoval_impl(int64_t*, const char*, char**, int)':
> /tmp/instance-0/output-1/host/x86_64-buildroot-linux-musl/sysroot/usr/include/flatbuffers/util.h:258:12: error: 'strtoll_l' was not declared in this scope; did you mean 'strcoll_l'?
> 258 | *val = __strtoll_impl(str, endptr, base);
> | ^~~~~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/68045b83e94f8caa337b1af7ed5f493ac1a55c47
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...flatbuffers-base.h-fix-build-on-musl.patch | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 package/flatbuffers/0001-include-flatbuffers-base.h-fix-build-on-musl.patch
I have seen the feedback from upstream that this workaround potentially
breaks bionic and BSD systems, but as we don't care about these in
Buildroot, I applied your patch to master as a work-around. Hopefully
upstream will implement a better/long-term solution.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-12 21:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 12:01 [Buildroot] [PATCH 1/1] package/flatbuffers: fix locale independent on musl Fabrice Fontaine
2021-08-12 21:42 ` Thomas Petazzoni [this message]
[not found] ` <20210812234247.3618da82__12747.8516822279$1628804602$gmane$org@windsurf>
2022-07-30 16:23 ` Bernd Kuhls
2022-08-01 17:46 ` Arnout Vandecappelle
2022-08-01 17:56 ` Bernd Kuhls
2022-08-01 18:13 ` Arnout Vandecappelle
2022-08-01 20:32 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812234247.3618da82@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.