From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: song@kernel.org
Cc: linux-raid@vger.kernel.org, jens@chianterastutte.eu
Subject: [PATCH] raid1: ensure bio doesn't have more than BIO_MAX_VECS sectors
Date: Fri, 13 Aug 2021 14:05:10 +0800 [thread overview]
Message-ID: <20210813060510.3545109-1-guoqing.jiang@linux.dev> (raw)
From: Guoqing Jiang <jiangguoqing@kylinos.cn>
We can't split bio with more than BIO_MAX_VECS sectors, otherwise the
below call trace was triggered because we could allocate oversized
write behind bio later.
[ 8.097936] bvec_alloc+0x90/0xc0
[ 8.098934] bio_alloc_bioset+0x1b3/0x260
[ 8.099959] raid1_make_request+0x9ce/0xc50 [raid1]
[ 8.100988] ? __bio_clone_fast+0xa8/0xe0
[ 8.102008] md_handle_request+0x158/0x1d0 [md_mod]
[ 8.103050] md_submit_bio+0xcd/0x110 [md_mod]
[ 8.104084] submit_bio_noacct+0x139/0x530
[ 8.105127] submit_bio+0x78/0x1d0
[ 8.106163] ext4_io_submit+0x48/0x60 [ext4]
[ 8.107242] ext4_writepages+0x652/0x1170 [ext4]
[ 8.108300] ? do_writepages+0x41/0x100
[ 8.109338] ? __ext4_mark_inode_dirty+0x240/0x240 [ext4]
[ 8.110406] do_writepages+0x41/0x100
[ 8.111450] __filemap_fdatawrite_range+0xc5/0x100
[ 8.112513] file_write_and_wait_range+0x61/0xb0
[ 8.113564] ext4_sync_file+0x73/0x370 [ext4]
[ 8.114607] __x64_sys_fsync+0x33/0x60
[ 8.115635] do_syscall_64+0x33/0x40
[ 8.116670] entry_SYSCALL_64_after_hwframe+0x44/0xae
[1]. https://bugs.archlinux.org/task/70992
Reported-by: Jens Stutte <jens@chianterastutte.eu>
Tested-by: Jens Stutte <jens@chianterastutte.eu>
Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
Note: this depends on commit 018eca456c4b4dca56aaf1ec27f309c74d0fe246
in linux-block for-next branch.
drivers/md/raid1.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 3c44c4bb40fc..ab21abc056b8 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1454,6 +1454,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
goto retry_write;
}
+ max_sectors = min_t(int, max_sectors, BIO_MAX_VECS * PAGE_SECTORS);
if (max_sectors < bio_sectors(bio)) {
struct bio *split = bio_split(bio, max_sectors,
GFP_NOIO, &conf->bio_split);
--
2.25.1
next reply other threads:[~2021-08-13 6:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 6:05 Guoqing Jiang [this message]
2021-08-13 7:49 ` [PATCH] raid1: ensure bio doesn't have more than BIO_MAX_VECS sectors Christoph Hellwig
2021-08-13 8:38 ` Guoqing Jiang
2021-08-14 7:55 ` Christoph Hellwig
2021-08-14 8:57 ` Ming Lei
2021-08-16 6:27 ` Guoqing Jiang
2021-08-16 7:13 ` Ming Lei
2021-08-16 9:37 ` Christoph Hellwig
2021-08-16 11:40 ` Ming Lei
2021-08-17 5:06 ` Christoph Hellwig
2021-08-17 12:32 ` Ming Lei
2021-09-24 15:34 ` Jens Stutte (Archiv)
2021-09-25 23:02 ` Guoqing Jiang
2021-08-13 9:27 ` kernel test robot
2021-08-13 9:27 ` kernel test robot
2021-08-13 10:12 ` kernel test robot
2021-08-13 10:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813060510.3545109-1-guoqing.jiang@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=jens@chianterastutte.eu \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.