From: Christoph Hellwig <hch@lst.de>
To: David Howells <dhowells@redhat.com>
Cc: willy@infradead.org, trond.myklebust@primarydata.com,
darrick.wong@oracle.com, hch@lst.de, viro@zeniv.linux.org.uk,
jlayton@kernel.org, sfrench@samba.org,
torvalds@linux-foundation.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 5/5] mm: Remove swap BIO paths and only use DIO paths [BROKEN]
Date: Fri, 13 Aug 2021 09:14:15 +0200 [thread overview]
Message-ID: <20210813071415.GD26339@lst.de> (raw)
In-Reply-To: <162879976139.3306668.12495248062404308890.stgit@warthog.procyon.org.uk>
On Thu, Aug 12, 2021 at 09:22:41PM +0100, David Howells wrote:
> [!] NOTE: This doesn't work and might damage your disk's contents.
>
> Delete the BIO-generating swap read/write paths and always use
> ->direct_IO(). This puts the mapping layer in the filesystem.
>
> This doesn't work - probably due to ki_pos being set to
> page_file_offset(page) which then gets remapped.
Also because most common block file systems do not actually implement
a ->direct_IO that does anything (noop_direct_IO).
prev parent reply other threads:[~2021-08-13 7:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 20:21 [RFC PATCH v2 0/5] mm: Fix NFS swapfiles and use DIO for swapfiles David Howells
2021-08-12 20:22 ` [RFC PATCH v2 1/5] nfs: Fix write to swapfile failure due to generic_write_checks() David Howells
2021-08-13 3:09 ` Matthew Wilcox
2021-08-13 7:02 ` Christoph Hellwig
2021-08-19 22:38 ` NeilBrown
2021-08-12 20:22 ` [RFC PATCH v2 2/5] mm: Remove the callback func argument from __swap_writepage() David Howells
2021-08-13 7:03 ` Christoph Hellwig
2021-08-12 20:22 ` [RFC PATCH v2 3/5] mm: Make swap_readpage() for SWP_FS_OPS use ->direct_IO() not ->readpage() David Howells
2021-08-12 21:23 ` Matthew Wilcox
2021-08-13 7:12 ` Christoph Hellwig
2021-08-12 20:22 ` [RFC PATCH v2 4/5] mm: Make __swap_writepage() do async DIO if asked for it David Howells
2021-08-12 20:22 ` [RFC PATCH v2 5/5] mm: Remove swap BIO paths and only use DIO paths [BROKEN] David Howells
2021-08-13 7:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813071415.GD26339@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.