From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>,
djwong@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [bug report] xfs: pass the goal of the incore inode walk to xfs_inode_walk()
Date: Fri, 13 Aug 2021 10:15:07 +0200 [thread overview]
Message-ID: <20210813081507.GA28382@lst.de> (raw)
In-Reply-To: <20210813073812.GX22532@kadam>
On Fri, Aug 13, 2021 at 10:38:12AM +0300, Dan Carpenter wrote:
> >
> > i.e. the enum is defined to clearly contain negative values and so
> > GCC should be defining it as a signed integer regardless of the
> > version of C being used...
>
> You're analysis is correct, but I'm looking at a newer version of the
> code and I blamed the wrong commit. It should be commit 777eb1fa857e
> ("xfs: remove xfs_dqrele_all_inodes")
> https://lore.kernel.org/linux-xfs/20210809065938.1199181-3-hch@lst.de/
> That commit removes the "XFS_ICWALK_DQRELE = -1," line which
> changes the enum type from int to unsigned int.
>
> So this suggests that we should just remove the check for negative
> values.
Remove the check as in removing the XFS code: yes. I just prepared a
patch for that. As in remove the check in smach: As usual these
kind of checks tend to find something fishy. Be that real bugs,
dead code or just the need to document weirdness better.
prev parent reply other threads:[~2021-08-13 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 6:42 [bug report] xfs: pass the goal of the incore inode walk to xfs_inode_walk() Dan Carpenter
2021-08-12 21:40 ` Dave Chinner
2021-08-12 22:41 ` Darrick J. Wong
2021-08-12 23:57 ` Dave Chinner
2021-08-13 8:12 ` Dan Carpenter
2021-08-13 7:38 ` Dan Carpenter
2021-08-13 8:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210813081507.GA28382@lst.de \
--to=hch@lst.de \
--cc=dan.carpenter@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.