From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [sound:topic/memalloc-noncontig 26/146] sound/pci/es1938.c:1585 snd_es1938_create() warn: 'pci' not released on lines: 1573.
Date: Fri, 13 Aug 2021 11:53:37 +0800 [thread overview]
Message-ID: <202108131124.82IbQLnT-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5384 bytes --]
CC: kbuild-all(a)lists.01.org
CC: alsa-devel(a)alsa-project.org
TO: Takashi Iwai <tiwai@suse.de>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git topic/memalloc-noncontig
head: aac54027424d36ebfff88350e5e4d99f310d4fce
commit: 08e9d3ab4cc1435ff96af563087894c482533c9e [26/146] ALSA: es1938: Allocate resources with device-managed APIs
:::::: branch date: 17 hours ago
:::::: commit date: 4 weeks ago
config: microblaze-randconfig-m031-20210812 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
sound/pci/es1938.c:1585 snd_es1938_create() warn: 'pci' not released on lines: 1573.
Old smatch warnings:
arch/microblaze/include/asm/thread_info.h:91 current_thread_info() error: uninitialized symbol 'sp'.
vim +/pci +1585 sound/pci/es1938.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 1538
e23e7a143620721 Bill Pemberton 2012-12-06 1539 static int snd_es1938_create(struct snd_card *card,
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1540 struct pci_dev *pci)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1541 {
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1542 struct es1938 *chip = card->private_data;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1543 int err;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1544
^1da177e4c3f415 Linus Torvalds 2005-04-16 1545 /* enable PCI device */
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1546 err = pcim_enable_device(pci);
3dc52815408b90e Takashi Iwai 2021-06-08 1547 if (err < 0)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1548 return err;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1549 /* check, if we can restrict PCI DMA transfers to 24 bits */
669f65eaeb969ef Takashi Iwai 2021-01-14 1550 if (dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(24))) {
ebebecaa0a9a26a Takashi Iwai 2014-02-25 1551 dev_err(card->dev,
ebebecaa0a9a26a Takashi Iwai 2014-02-25 1552 "architecture does not support 24bit PCI busmaster DMA\n");
^1da177e4c3f415 Linus Torvalds 2005-04-16 1553 return -ENXIO;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1554 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1555
^1da177e4c3f415 Linus Torvalds 2005-04-16 1556 spin_lock_init(&chip->reg_lock);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1557 spin_lock_init(&chip->mixer_lock);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1558 chip->card = card;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1559 chip->pci = pci;
30b35399ceb2398 Takashi Iwai 2006-10-11 1560 chip->irq = -1;
3dc52815408b90e Takashi Iwai 2021-06-08 1561 err = pci_request_regions(pci, "ESS Solo-1");
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1562 if (err < 0)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1563 return err;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1564 chip->io_port = pci_resource_start(pci, 0);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1565 chip->sb_port = pci_resource_start(pci, 1);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1566 chip->vc_port = pci_resource_start(pci, 2);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1567 chip->mpu_port = pci_resource_start(pci, 3);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1568 chip->game_port = pci_resource_start(pci, 4);
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1569 /* still use non-managed irq handler as it's re-acquired at PM resume */
437a5a4606c12ab Takashi Iwai 2006-11-21 1570 if (request_irq(pci->irq, snd_es1938_interrupt, IRQF_SHARED,
934c2b6d0cb50f9 Takashi Iwai 2011-06-10 1571 KBUILD_MODNAME, chip)) {
ebebecaa0a9a26a Takashi Iwai 2014-02-25 1572 dev_err(card->dev, "unable to grab IRQ %d\n", pci->irq);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1573 return -EBUSY;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1574 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1575 chip->irq = pci->irq;
6b276e6281b6df9 Takashi Iwai 2019-12-10 1576 card->sync_irq = chip->irq;
08e9d3ab4cc1435 Takashi Iwai 2021-07-15 1577 card->private_free = snd_es1938_free;
ebebecaa0a9a26a Takashi Iwai 2014-02-25 1578 dev_dbg(card->dev,
ebebecaa0a9a26a Takashi Iwai 2014-02-25 1579 "create: io: 0x%lx, sb: 0x%lx, vc: 0x%lx, mpu: 0x%lx, game: 0x%lx\n",
^1da177e4c3f415 Linus Torvalds 2005-04-16 1580 chip->io_port, chip->sb_port, chip->vc_port, chip->mpu_port, chip->game_port);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1581
^1da177e4c3f415 Linus Torvalds 2005-04-16 1582 chip->ddma_port = chip->vc_port + 0x00; /* fix from Thomas Sailer */
^1da177e4c3f415 Linus Torvalds 2005-04-16 1583
^1da177e4c3f415 Linus Torvalds 2005-04-16 1584 snd_es1938_chip_init(chip);
^1da177e4c3f415 Linus Torvalds 2005-04-16 @1585 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1586 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 1587
:::::: The code at line 1585 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39689 bytes --]
reply other threads:[~2021-08-13 3:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108131124.82IbQLnT-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.