From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ren Date: Fri, 13 Aug 2021 22:22:29 -0700 Subject: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC In-Reply-To: References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-5-rentao.bupt@gmail.com> <20210813034016.GA21895@taoren-ubuntu-R90MNF91> Message-ID: <20210814052228.GA1298@taoren-ubuntu-R90MNF91> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Andrew, On Fri, Aug 13, 2021 at 04:45:58PM +0200, Andrew Lunn wrote: > On Thu, Aug 12, 2021 at 08:40:17PM -0700, Tao Ren wrote: > > On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote: > > > On Thu, 5 Aug 2021 at 22:28, wrote: > > > > +&mdio1 { > > > > + status = "okay"; > > > > > > You're enabling this but it looks like it's unused? > > > > Thanks Joel for the careful review. The MDIO controller is not paired > > with BMC MAC; instead, it's connected to the MDC/MDIO interface of the > > on-board switch (whose ports are connected to BMC, Host and front panel > > management port). > > What switch is it? Is there a DSA driver for it? drivers/net/dsa/* > Ideally you want Linux to be controlling the switch, in the standard > linux way. > > Andrew Thanks for jumping in. We are using BCM5389 and the MDIO bus is used to access BCM5389 MDC/MDIO interface in Pseudo-PHY mode. I didn't know drivers/net/dsa, but let me check out the drivers and see if it works in the Cloudripper environment. Thanks, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE6BC4338F for ; Sat, 14 Aug 2021 05:23:26 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDD5E60F51 for ; Sat, 14 Aug 2021 05:23:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EDD5E60F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Gmpjm2LjPz3cMW for ; Sat, 14 Aug 2021 15:23:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=OQqyGWEn; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102f; helo=mail-pj1-x102f.google.com; envelope-from=rentao.bupt@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=OQqyGWEn; dkim-atps=neutral Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Gmphv3dh9z2ymS; Sat, 14 Aug 2021 15:22:38 +1000 (AEST) Received: by mail-pj1-x102f.google.com with SMTP id hv22-20020a17090ae416b0290178c579e424so19057054pjb.3; Fri, 13 Aug 2021 22:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=OQqyGWEnIPLyf3mXTtyAaEWzqjlcyCUdbsTZsFKYqa8gAZOSlHOHrA++SGAjDCM22p anVJ+uBmvz9kl/eeKRiNY53lZBTvP4HgO021aS2HzrnH0XB3vWa/khh3xHM367OVTYRE 8CpdEsiV5Duh5fXigEio/fXfI1uyps2jzP4LWgQQU3ckEhDYLd6enyJJUkooyVLbdsAa 69I0VwvlzYUdSkA9d/D5fqBq4F9eCUXJ6GlF8wWTLjY31rZseLDIaNp+yh+hbwzbdTGK Sh40dkDnJUbxJaTx6hsdpIhjI9TlMVFj2aWH0qJ5ZO+A9bWGoaT0ufqA25AHNn39HLpW SpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=jhsBL88NSXbqqzV2aEEaHHfE63kR39O0ogQCZT8EH50f1KpT7xVNex1btFTOPMQz8Z hlb+41HKmlJRqOHNDAlRYa4sQhoXXtR6zhQFMcnP3swR61ip35d1gA1cp30yp6M+h0/j VRt799hzDrir3XaU2pGfLR5PdnD7YGvv0r/yi0sZi3O/QkEnHQrJFPsY8N+vgLirgt96 NYTBwnhrrIr+GROcUuGG1QjPBYRUb7jZEcSwkIIhTLvcX9AR5B/r7TXMBMurZHu8mLUi 9RvKyMalB8GHW1jxDwFE480ks6xwP1ufMciyG/HM1Lbz0o6zKW3qHKb8uayqh57LPNQ4 9qfA== X-Gm-Message-State: AOAM532/MdmghEhLhQIFYLo7ZY977hbxPCkacSPsXWUmw0K9B8qg5qqp iMm4kLKJ0PZQadfknUNff1Q= X-Google-Smtp-Source: ABdhPJwD5gIcmIVuMlWVrreOkxKSMiaVBIuW/nBKpzkRSs0ejSmabXcCcl3mKEjdXsaLElfILCT8Bg== X-Received: by 2002:a65:608f:: with SMTP id t15mr5420277pgu.452.1628918556102; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-92-48-112.hsd1.ca.comcast.net. [73.92.48.112]) by smtp.gmail.com with ESMTPSA id b3sm4102861pfi.179.2021.08.13.22.22.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Aug 2021 22:22:35 -0700 (PDT) Date: Fri, 13 Aug 2021 22:22:29 -0700 From: Tao Ren To: Andrew Lunn Subject: Re: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC Message-ID: <20210814052228.GA1298@taoren-ubuntu-R90MNF91> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-5-rentao.bupt@gmail.com> <20210813034016.GA21895@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Tao Ren , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Andrew, On Fri, Aug 13, 2021 at 04:45:58PM +0200, Andrew Lunn wrote: > On Thu, Aug 12, 2021 at 08:40:17PM -0700, Tao Ren wrote: > > On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote: > > > On Thu, 5 Aug 2021 at 22:28, wrote: > > > > +&mdio1 { > > > > + status = "okay"; > > > > > > You're enabling this but it looks like it's unused? > > > > Thanks Joel for the careful review. The MDIO controller is not paired > > with BMC MAC; instead, it's connected to the MDC/MDIO interface of the > > on-board switch (whose ports are connected to BMC, Host and front panel > > management port). > > What switch is it? Is there a DSA driver for it? drivers/net/dsa/* > Ideally you want Linux to be controlling the switch, in the standard > linux way. > > Andrew Thanks for jumping in. We are using BCM5389 and the MDIO bus is used to access BCM5389 MDC/MDIO interface in Pseudo-PHY mode. I didn't know drivers/net/dsa, but let me check out the drivers and see if it works in the Cloudripper environment. Thanks, Tao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BA8C4338F for ; Sat, 14 Aug 2021 05:24:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D689B60F51 for ; Sat, 14 Aug 2021 05:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D689B60F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y3XsWynzKzQn2E26M1YjH6v/Dlc/yY2QXSuYO4LHWrU=; b=dcyNmYchtMyF0R lyhTXQIJnL7Ndfcd3WzIk5Jf4ALer4cpIXg2TmMkMPTZpOBpnpYr4yi/1E6fFetv77K7xEWh44GqU WgpRldx4+cVs8GqTMQ0JX8GkwohhlF489CAgF2IErKjhxUr/USIwuGCq7TpjSMaqrkPskmTWz/sS8 71vD8oG2NHF+aes/wgrN6dsXnvndzggmgaojvVREVlZ6NFx40AY5dG5PDrYoNXKJCz7iNx2F4yjoR HI7otwGHnKoS93414h/XQpcCX+vMxcxhxgE4hL13KvGzeEACyY4ofrSMJQNSIGKUmTNjBkRTZieG7 qR5XbKvCl7KjOiB2DHYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEm81-00DsL1-Uv; Sat, 14 Aug 2021 05:22:42 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEm7y-00DsKQ-26 for linux-arm-kernel@lists.infradead.org; Sat, 14 Aug 2021 05:22:39 +0000 Received: by mail-pj1-x102a.google.com with SMTP id om1-20020a17090b3a8100b0017941c44ce4so5534527pjb.3 for ; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=OQqyGWEnIPLyf3mXTtyAaEWzqjlcyCUdbsTZsFKYqa8gAZOSlHOHrA++SGAjDCM22p anVJ+uBmvz9kl/eeKRiNY53lZBTvP4HgO021aS2HzrnH0XB3vWa/khh3xHM367OVTYRE 8CpdEsiV5Duh5fXigEio/fXfI1uyps2jzP4LWgQQU3ckEhDYLd6enyJJUkooyVLbdsAa 69I0VwvlzYUdSkA9d/D5fqBq4F9eCUXJ6GlF8wWTLjY31rZseLDIaNp+yh+hbwzbdTGK Sh40dkDnJUbxJaTx6hsdpIhjI9TlMVFj2aWH0qJ5ZO+A9bWGoaT0ufqA25AHNn39HLpW SpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=Iv60wo8Y1188Qw1/ryJD1aH1HLx90G9eX5AmV82iL0E/PZwxK93VmeLUjK+drvItiM uUy5sLZu8UjT9M5Mu8U1DEsb47xJuKQzeLDU6+0gpdpbph4ordd3AEnOdpwe1E0rwNb5 8LhJzS0FtywBfUeTanCScTYLZzat7ahyw/tmImp8WALsBHGPD/n/iYt1pkHUzUGMqwM/ TkGH4l/yQwK2EU+Im4pv/Y6S0O+r0nSUo9UE41epjgelfh7XX2dhInltHSK3rFaYIB+v TKFa53hpfzyvOe6+sMuZ8ohiLiWA7y9I1YnkmCD3jdVtInodtykF68iKVefJINqJOv6r Mdbw== X-Gm-Message-State: AOAM531tECD2AaLDm8Ez0V0mPTZwdufTjEFPrNwrVbmMMXvAx8RwmJN3 BLY0iXFwRFSzq1GwmmivogU= X-Google-Smtp-Source: ABdhPJwD5gIcmIVuMlWVrreOkxKSMiaVBIuW/nBKpzkRSs0ejSmabXcCcl3mKEjdXsaLElfILCT8Bg== X-Received: by 2002:a65:608f:: with SMTP id t15mr5420277pgu.452.1628918556102; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-92-48-112.hsd1.ca.comcast.net. [73.92.48.112]) by smtp.gmail.com with ESMTPSA id b3sm4102861pfi.179.2021.08.13.22.22.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Aug 2021 22:22:35 -0700 (PDT) Date: Fri, 13 Aug 2021 22:22:29 -0700 From: Tao Ren To: Andrew Lunn Cc: Joel Stanley , Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC Message-ID: <20210814052228.GA1298@taoren-ubuntu-R90MNF91> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-5-rentao.bupt@gmail.com> <20210813034016.GA21895@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_222238_170452_CD47E15E X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Fri, Aug 13, 2021 at 04:45:58PM +0200, Andrew Lunn wrote: > On Thu, Aug 12, 2021 at 08:40:17PM -0700, Tao Ren wrote: > > On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote: > > > On Thu, 5 Aug 2021 at 22:28, wrote: > > > > +&mdio1 { > > > > + status = "okay"; > > > > > > You're enabling this but it looks like it's unused? > > > > Thanks Joel for the careful review. The MDIO controller is not paired > > with BMC MAC; instead, it's connected to the MDC/MDIO interface of the > > on-board switch (whose ports are connected to BMC, Host and front panel > > management port). > > What switch is it? Is there a DSA driver for it? drivers/net/dsa/* > Ideally you want Linux to be controlling the switch, in the standard > linux way. > > Andrew Thanks for jumping in. We are using BCM5389 and the MDIO bus is used to access BCM5389 MDC/MDIO interface in Pseudo-PHY mode. I didn't know drivers/net/dsa, but let me check out the drivers and see if it works in the Cloudripper environment. Thanks, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F98C4338F for ; Sat, 14 Aug 2021 05:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 785D960F51 for ; Sat, 14 Aug 2021 05:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233172AbhHNFXE (ORCPT ); Sat, 14 Aug 2021 01:23:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231890AbhHNFXE (ORCPT ); Sat, 14 Aug 2021 01:23:04 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE39C061575; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id j12-20020a17090aeb0c00b00179530520b3so3418671pjz.0; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=OQqyGWEnIPLyf3mXTtyAaEWzqjlcyCUdbsTZsFKYqa8gAZOSlHOHrA++SGAjDCM22p anVJ+uBmvz9kl/eeKRiNY53lZBTvP4HgO021aS2HzrnH0XB3vWa/khh3xHM367OVTYRE 8CpdEsiV5Duh5fXigEio/fXfI1uyps2jzP4LWgQQU3ckEhDYLd6enyJJUkooyVLbdsAa 69I0VwvlzYUdSkA9d/D5fqBq4F9eCUXJ6GlF8wWTLjY31rZseLDIaNp+yh+hbwzbdTGK Sh40dkDnJUbxJaTx6hsdpIhjI9TlMVFj2aWH0qJ5ZO+A9bWGoaT0ufqA25AHNn39HLpW SpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qUlgCGK8+0KVcRwvfAdukdAi2gP9bLhzHb2DkcgfzQY=; b=txpOHCG2uwglZ3XdScTqqN6RL1guxTGu1vlDEXPVG6uCHzzFy5WxmGD7AVkakCBMa6 ImTpbKt8/Cx+VEC88/0N6AR+jLX5MxQm6Vsqb9a417gI3xPuni5qrCgRs3d47P5bF7xx yGe7vs5F+luWITS0oxPLAyPoKcggJfz1blKLRYUpXy9H9Jp2YY71hd3suzZaVFVjzIzG kQpOJaMuUdKsG3MBFCdomxYUEL+bv7WKDAaOKW++7cGpOaOksmjRckyelVDbx0FimqE3 1x5Gx4JkRihA84KVBqJCIe6BeVNMuF3/9txavOj+7hTk1vtsCoUYsv3ivnKY8OTFiPLR yFoQ== X-Gm-Message-State: AOAM533O4X40Xax52D6p4YY4WQnHEuKG+XLVfy4alydzOl46o79TjsyS wuhZqJwSiERy8Yt8NPZoJbM= X-Google-Smtp-Source: ABdhPJwD5gIcmIVuMlWVrreOkxKSMiaVBIuW/nBKpzkRSs0ejSmabXcCcl3mKEjdXsaLElfILCT8Bg== X-Received: by 2002:a65:608f:: with SMTP id t15mr5420277pgu.452.1628918556102; Fri, 13 Aug 2021 22:22:36 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-92-48-112.hsd1.ca.comcast.net. [73.92.48.112]) by smtp.gmail.com with ESMTPSA id b3sm4102861pfi.179.2021.08.13.22.22.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Aug 2021 22:22:35 -0700 (PDT) Date: Fri, 13 Aug 2021 22:22:29 -0700 From: Tao Ren To: Andrew Lunn Cc: Joel Stanley , Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren Subject: Re: [PATCH v2 4/6] ARM: dts: aspeed: Add Facebook Cloudripper (AST2600) BMC Message-ID: <20210814052228.GA1298@taoren-ubuntu-R90MNF91> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-5-rentao.bupt@gmail.com> <20210813034016.GA21895@taoren-ubuntu-R90MNF91> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Andrew, On Fri, Aug 13, 2021 at 04:45:58PM +0200, Andrew Lunn wrote: > On Thu, Aug 12, 2021 at 08:40:17PM -0700, Tao Ren wrote: > > On Fri, Aug 13, 2021 at 01:29:17AM +0000, Joel Stanley wrote: > > > On Thu, 5 Aug 2021 at 22:28, wrote: > > > > +&mdio1 { > > > > + status = "okay"; > > > > > > You're enabling this but it looks like it's unused? > > > > Thanks Joel for the careful review. The MDIO controller is not paired > > with BMC MAC; instead, it's connected to the MDC/MDIO interface of the > > on-board switch (whose ports are connected to BMC, Host and front panel > > management port). > > What switch is it? Is there a DSA driver for it? drivers/net/dsa/* > Ideally you want Linux to be controlling the switch, in the standard > linux way. > > Andrew Thanks for jumping in. We are using BCM5389 and the MDIO bus is used to access BCM5389 MDC/MDIO interface in Pseudo-PHY mode. I didn't know drivers/net/dsa, but let me check out the drivers and see if it works in the Cloudripper environment. Thanks, Tao