Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

2021-08-14 08:55 (UTC-0700), William Tu:
> Hi Dmitry,
> 
> I'm looking at this patch and have some questions.
> 
> On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com> wrote:
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> >  drivers/net/virtio/virtio_ethdev.c            |   4 +
> >  kernel/windows/netuio/netuio.inf              |   6 +
> >  lib/librte_eal/windows/eal/eal.c              |   4 +  
> 
> Why do we need these change below?

1. At the time of the patch there was no dpdk-kmods repo.

2. The patch is for dpdk-draft-windows repo,
   which was using Vistual Studio projects instead of meson.

> I thought to add a new Windows driver support, we only need to
> compile the drivers/net/xxx, and add the device ID to netuio.inf,
> at the dpdk-kmod repo?

Yes.
Particularly for virtio it would also be required to support reading PCI
config space in bus/pci/windows (netuio already provides the support).

> 
> >  mk/exec-env/windows/dpdk.sln                  | 754 +++++++++---------
> >  mk/exec-env/windows/l2fwd/l2fwd.vcxproj       | 242 +++---
> >  mk/exec-env/windows/l3fwd/l3fwd.vcxproj       | 292 +++----
> >  .../librte_pmd_i40e.vcxproj.filters           | 198 +++++
> >  .../librte_pmd_net_virtio.vcxproj             | 129 +++
> >  8 files changed, 989 insertions(+), 640 deletions(-)
> >  create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_i40e.vcxproj.filters
> >  create mode 100644 mk/exec-env/windows/librte_pmd_net_virtio/librte_pmd_net_virtio.vcxproj  
> 
> Thanks
> William