From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDE3C4320A for ; Mon, 16 Aug 2021 07:14:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F14C361A89 for ; Mon, 16 Aug 2021 07:14:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F14C361A89 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D39889C2C; Mon, 16 Aug 2021 07:14:09 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFA8A89C93; Sun, 15 Aug 2021 09:19:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2576E6736F; Sun, 15 Aug 2021 11:19:36 +0200 (CEST) Date: Sun, 15 Aug 2021 11:19:35 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v6 07/13] mm: add generic type support to migrate_vma helpers Message-ID: <20210815091935.GD25067@lst.de> References: <20210813063150.2938-1-alex.sierra@amd.com> <20210813063150.2938-8-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813063150.2938-8-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Mon, 16 Aug 2021 07:13:00 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Aug 13, 2021 at 01:31:44AM -0500, Alex Sierra wrote: > Device generic type case added for migrate_vma_pages and > migrate_vma_check_page helpers. > Both, generic and private device types have the same > conditions to decide to migrate pages from/to device > memory. This reas a little weird mostly because it doesn't use up the line length nicely: Add the device generic type case to the migrate_vma_pages and migrate_vma_check_page helpers. This new case is handled identically to the existing device private case. > + * We support migrating to private and generic types for device > + * zone memory. Don't spill comments over 80 characters. Otherwise looks good: Reviewed-by: Christoph Hellwig