From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 16 Aug 2021 01:07:19 -0400 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2] virtio-mmio: Specify wait needed in driver during reset Message-ID: <20210816010636-mutt-send-email-mst@kernel.org> References: <20210813145351.GA5604@quicinc.com> <20210816045718.GB5604@quicinc.com> MIME-Version: 1.0 In-Reply-To: <20210816045718.GB5604@quicinc.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Srivatsa Vaddagiri Cc: Jason Wang , Cornelia Huck , Virtio-Dev , Trilok Soni , Pratik Patel List-ID: On Mon, Aug 16, 2021 at 10:27:18AM +0530, Srivatsa Vaddagiri wrote: > * Jason Wang [2021-08-16 10:10:56]: > > > > +After writing 0 to \field{Status}, which triggers a reset of device, the driver MUST wait for a read of > > > +\field{Status} to return 0 before proceeding with the remaining steps of initializing the device. > > > + > > > > Do we need to limit this behaviour to 0x3 only? > > I felt it will be simple for drivers to unconditionally poll for reset > completion (which is the right thing to do IMO), but can make it conditional to > version 3 only if you say so. > > - vatsa We can't make spec changes that declare all existing drivers non-conformant. > --- > > Qualcomm Innovation Center, Inc. is submitting the attached "feedback" as a > non-member to the virtio-dev mailing list for consideration and inclusion. >