From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C853A2FAE for ; Mon, 16 Aug 2021 03:23:55 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id i9so10937917lfg.10 for ; Sun, 15 Aug 2021 20:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B07EO9ccjm4sJBL35vstmYWtRuMt5BN5atqWj1gYKMU=; b=VqcjzqMxg1JPoSOTGNdjSrYRyiutl2kQvwGxfG+Ol6L6WmrZwSwBNyoRd8n+eDhW3p nel5nQc2YicEsmVIKf6g5SkB/LPRluLWskJxvLNvSVoFGDMwm8G2aCmZoCaCvWZEQt+Y olHiwffAQ1QZ23zbm324s+nFES/bE28kQlzlxF9z6srU+gqgHTL0043e7FUImLIgn+Bk fdUoxEwvMyx17GSX0tI3wmSGuMnzjC6LhERdVFcsPfK/4GVml2tuwtp+IjlG9NPsjraf x3znroqMtvQt147OrQv/7v/rupL1JS1d99nG3RZrOd/6/+rIVTNDDZEJ1A/ZNFLHxTtG mSig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B07EO9ccjm4sJBL35vstmYWtRuMt5BN5atqWj1gYKMU=; b=lq9s7DVUYHNsQssPGPASQ4n7ZP1cO2asFaxPFscOsgxAX9nDUj7qhRwYR9ek9Cad9R wVY+eEgOm5VdNTtlCVUdEbmFycO4LHePKngh2Vxm2Xu3yDajlPp3Y/juYMhA6mvWLG8M HuriKZ1Atz+vcNtw77VYofIJBoCed0sHbLRuhPM/KVEOuyKNj/vAUjwmwOHcAfrF0xI+ BFmi07HvKMLAKdrMz9S2+V0tAYIeLHW5o0ENIqt4aEqqV7u+NF52R/cPpX1pJPkzfSiF GC8c53ruScFBeGyI1pjLmK5gd+Rx5U27wroaMo2LXbemn5rd+VWZKCOyWYeYkpT9uK6o mW/Q== X-Gm-Message-State: AOAM533Mf4qnZw0asdrD2bjqz/UJKYgvKnsqPvxadl7U1Q9NGfJ8ODsJ HFtTb+c6whzCJ+gHVN8IEEA= X-Google-Smtp-Source: ABdhPJz0J4cOcTPGA3nDyS9oOLzAi7k0UQFfwJxLcWmK7DYwHWCwWBChv2k3p6hmRSguRF20gGuKHw== X-Received: by 2002:ac2:562b:: with SMTP id b11mr8527015lff.586.1629084233942; Sun, 15 Aug 2021 20:23:53 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id o20sm821249lfu.148.2021.08.15.20.23.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Aug 2021 20:23:53 -0700 (PDT) Date: Mon, 16 Aug 2021 06:23:51 +0300 From: Kari Argillander To: Konstantin Komarov , Christoph Hellwig Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Pali =?utf-8?B?Um9ow6Fy?= , Matthew Wilcox Subject: Re: [RFC PATCH 1/4] fs/ntfs3: Use new api for mounting Message-ID: <20210816032351.yo7lkfrwsio3qvjw@kari-VirtualBox> References: <20210816024703.107251-1-kari.argillander@gmail.com> <20210816024703.107251-2-kari.argillander@gmail.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816024703.107251-2-kari.argillander@gmail.com> On Mon, Aug 16, 2021 at 05:47:00AM +0300, Kari Argillander wrote: > We have now new mount api as described in Documentation/filesystems. We > should use it as it gives us some benefits which are desribed here > https://lore.kernel.org/linux-fsdevel/159646178122.1784947.11705396571718464082.stgit@warthog.procyon.org.uk/ > > Nls loading is changed a little bit because new api not have default > optioni for mount parameters. So we need to load nls table before and > change that if user specifie someting else. > > Also try to use fsparam_flag_no as much as possible. This is just nice > little touch and is not mandatory but it should not make any harm. It > is just convenient that we can use example acl/noacl mount options. I would like that if someone can comment can we do reconfigure so that we change mount options? Can we example change iocharset and be ok after that? I have look some other fs drivers and in my eyes it seems to be quite random if driver should let reconfigure all parameters. Right now code is that we can reconfigure every mount parameter but I do not know if this is right call.