From: Christoph Hellwig <hch@lst.de>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+aa0801b6b32dca9dda82@syzkaller.appspotmail.com>,
axboe@kernel.dk, Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] general protection fault in wb_timer_fn
Date: Mon, 16 Aug 2021 11:33:36 +0200 [thread overview]
Message-ID: <20210816093336.GA3950@lst.de> (raw)
In-Reply-To: <20210816091041.3313-1-hdanton@sina.com>
On Mon, Aug 16, 2021 at 05:10:41PM +0800, Hillf Danton wrote:
> Remove and free all qos callbacks added, with cb->timer deleted in
> blk_stat_remove_callback().
>
> only for thoughts.
>
> +++ x/block/blk-sysfs.c
> @@ -800,9 +800,7 @@ static void blk_release_queue(struct kob
>
> might_sleep();
>
> - if (test_bit(QUEUE_FLAG_POLL_STATS, &q->queue_flags))
> - blk_stat_remove_callback(q, q->poll_cb);
> - blk_stat_free_callback(q->poll_cb);
> + rq_qos_exit(q);
rq_qos_exit is already called in blk_cleanup_queue, and the blk-mq
pollig doesn't even use the qos framework. So I'm not sure what this
is supposed to help.
next prev parent reply other threads:[~2021-08-16 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 11:57 [syzbot] general protection fault in wb_timer_fn syzbot
[not found] ` <20210816091041.3313-1-hdanton@sina.com>
2021-08-16 9:33 ` Christoph Hellwig [this message]
2021-08-19 9:03 ` Sven Schnelle
2021-08-19 9:05 ` Christoph Hellwig
2021-08-19 9:10 ` Sven Schnelle
2021-08-19 13:10 ` Sven Schnelle
2021-08-19 13:53 ` Christoph Hellwig
2021-08-21 7:48 ` Yi Zhang
2021-08-24 7:23 ` Christoph Hellwig
2021-08-25 5:59 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816093336.GA3950@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hdanton@sina.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+aa0801b6b32dca9dda82@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.