All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: "André Zwing" <nerv@dawncrow.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libkrb5: disable with libressl
Date: Tue, 17 Aug 2021 23:02:13 +0200	[thread overview]
Message-ID: <20210817210213.GX27036@scaer> (raw)
In-Reply-To: <20210816065458.1726927-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-08-16 08:54 +0200, Fabrice Fontaine spake thusly:
> libkrb5 does not build with libressl since commit
> b7a5b9d06d484700fc4fcbd354f2c15e0422688c and upstream is not interested
> in fixing this issue as a PR is opened for more than 4 years
> (https://github.com/krb5/krb5/pull/607):
> 
> pkinit_crypto_openssl.c: In function 'cms_signeddata_verify':
> pkinit_crypto_openssl.c:1700:22: error: implicit declaration of function 'OBJ_get0_data'; did you mean 'BIO_get_data'? [-Werror=implicit-function-declaration]
>  1700 |         print_buffer(OBJ_get0_data(etype), OBJ_length(etype));
>       |                      ^~~~~~~~~~~~~
>       |                      BIO_get_data
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e623f4e1d6b6004e98815b8b7da3938238890bd8
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libkrb5/libkrb5.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> index 89f219d913..5b30fbba2c 100644
> --- a/package/libkrb5/libkrb5.mk
> +++ b/package/libkrb5/libkrb5.mk
> @@ -41,7 +41,7 @@ else
>  LIBKRB5_CONF_OPTS += --without-ldap
>  endif
>  
> -ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)

Don't forget that an openssl provider can be provided by a br2-external
tree. If we force the condition to BR2_PACKAGE_LIBOPENSSL, then it
prevents any such provider to be used.

So, I think the best solution is to exclude libressl, rather than limit
to libopenssl. I've tried to come up with a simple conditional block:

    # An openssl provider is needed, but libressl is no match.
    # A provider from a br2-external is supposed to match.
    ifeq ($(BR2_PACKAGE_OPENSSL),y)
    ifeq ($(BR2_PACKAGE_LIBRESSL),)
    LIBKRB5_SSL = y
    endif
    endif
    ifeq ($(LIBKRB5_SSL),y)
    LIBKRB5_DEPENDENCIES += openssl
    LIBKRB5_CONF_OPTS += \
        --enable-pkinit \
        ...
    endif

Regards,
Yann E. MORIN.

>  LIBKRB5_CONF_OPTS += \
>  	--enable-pkinit \
>  	--with-crypto-impl=openssl \
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-17 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16  6:54 [Buildroot] [PATCH 1/1] package/libkrb5: disable with libressl Fabrice Fontaine
2021-08-17 21:02 ` Yann E. MORIN [this message]
2021-08-17 21:55   ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817210213.GX27036@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=nerv@dawncrow.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.